[JASS] Ability based on # of units nearby

[Penguin_Buddha]

OK, so Im creating a map with JASS for the first time. Im very inexperienced. I want an outline for how to code an ability type. The generic type is that a unit gets a numerical bonus to a stat based on the number of friendly units (of the same type) within a certain range of the unit.

For Example; The militia unit gets +1 damage for every other friendly militia unit within 300 range of it. 5 militia units are all within 300 range of one another. Each militia unit would gain +4 to its damage.

Any idea on how to code this in JASS. Also, would it take up to much memory? I mean if there are 40 militia units, would It severely slow down the computer?

Thanks for any help.

 

[Saishy]

Do a dmg aura that stacks.
I don't know if its possible, just a ideia.

 

[RolePlaynGamer]

This should work.

function Trig_Peasant_Attack_Conditions takes nothing returns boolean
  return GetUnitTypeId(GetAttacker()) == 'Hpea'
endfunction

function PeasantAttack_Filter takes nothing returns boolean
  return IsUnitAlly(GetAttacker(), GetFilterUnit())
endfunction

function Trig_Peasant_Attack_Actions takes nothing returns nothing
  local group group = CreateGroup()
  local boolexpr Boolexpr = Condition(function PeasantAttack_Filter)
  local real X = GetUnitX(GetAttacker())
  local real Y = GetUnitY(GetAttacker())
  local integer Count
  
  call GroupEnumUnitsInRange(Group, X, Y, 300, Boolexpr)
  set Count = CountUnitsInGroup(Group)
  call UnitDamageTarget(GetAttacker(), GetTriggerUnit(), count, true, false, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_NORMAL, WEAPON_TYPE_METAL_LIGHT_CHOP) 

  call DestroyGroup(Group)
  set Group = null
  call DestroyBoolExpr(Boolexpr)
  set Boolexpr = null
endfunction

//===========================================================================
function InitTrig_Peasant_Attack takes nothing returns nothing
    set gg_trg_Peasant_Attack = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Peasant_Attack, EVENT_PLAYER_UNIT_ATTACKED )
    call TriggerAddCondition( gg_trg_Peasant_Attack, Condition( function Trig_Peasant_Attack_Conditions ) )
    call TriggerAddAction( gg_trg_Peasant_Attack, function Trig_Peasant_Attack_Actions )
endfunction

 

[Saishy]

It will not work because in the 5th line there is a "erturns"

xD

 

[RolePlaynGamer]

~Fixed~

Now it should work =)

 

[Earth-Fury]

This should work.

function Trig_Peasant_Attack_Conditions takes nothing returns boolean
  return GetUnitTypeId(GetAttacker()) == 'Hpea'
endfunction

function PeasantAttack_Filter takes nothing returns boolean
  return IsUnitAlly(GetAttacker(), GetFilterUnit())
endfunction

function Trig_Peasant_Attack_Actions takes nothing returns nothing
  local group group = CreateGroup()
  local boolexpr Boolexpr = Condition(function PeasantAttack_Filter)
  local real X = GetUnitX(GetAttacker())
  local real Y = GetUnitY(GetAttacker())
  local integer Count
  
  call GroupEnumUnitsInRange(Group, X, Y, 300, Boolexpr)
  set Count = CountUnitsInGroup(Group)
  call UnitDamageTarget(GetAttacker(), GetTriggerUnit(), count, true, false, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_NORMAL, WEAPON_TYPE_METAL_LIGHT_CHOP) 

  call DestroyGroup(Group)
  set Group = null
  call DestroyBoolExpr(Boolexpr)
  set Boolexpr = null
endfunction

//===========================================================================
function InitTrig_Peasant_Attack takes nothing returns nothing
    set gg_trg_Peasant_Attack = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Peasant_Attack, EVENT_PLAYER_UNIT_ATTACKED )
    call TriggerAddCondition( gg_trg_Peasant_Attack, Condition( function Trig_Peasant_Attack_Conditions ) )
    call TriggerAddAction( gg_trg_Peasant_Attack, function Trig_Peasant_Attack_Actions )
endfunction

you don't have to destroy boolexprs. For the same input, Condition() will produce the same output. You also use some unneeded locals, and a few case errors. Fixing all i can see:

function Trig_Peasant_Attack_Conditions takes nothing returns boolean
  return GetUnitTypeId(GetAttacker()) == 'Hpea'
endfunction

function PeasantAttack_Filter takes nothing returns boolean
  return IsUnitAlly(GetAttacker(), GetFilterUnit())
endfunction

function Trig_Peasant_Attack_Actions takes nothing returns nothing
  local group Group = CreateGroup()
  
  call GroupEnumUnitsInRange(Group, GetUnitX(GetAttacker()), GetUnitY(GetAttacker()), 300, Condition(function PeasantAttack_Filter))
  call UnitDamageTarget(GetAttacker(), GetTriggerUnit(), CountUnitsInGroup(Group), true, false, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_NORMAL, WEAPON_TYPE_METAL_LIGHT_CHOP) 

  call DestroyGroup(Group)
  set Group = null
endfunction

//===========================================================================
function InitTrig_Peasant_Attack takes nothing returns nothing
    set gg_trg_Peasant_Attack = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Peasant_Attack, EVENT_PLAYER_UNIT_ATTACKED )
    call TriggerAddCondition( gg_trg_Peasant_Attack, Condition( function Trig_Peasant_Attack_Conditions ) )
    call TriggerAddAction( gg_trg_Peasant_Attack, function Trig_Peasant_Attack_Actions )
endfunction

Anyway, that won't work out so well anyway.

the "EVENT_PLAYER_UNIT_ATTACKED" event happens when a unit begins attacking, not when a unit finishes attacking. Thus, this can deal damage when the unit doesn't even have to finish an attack.

A better way to go about this would be using a periodic timer using GroupEnumUnitsInRange(), adjusting a damage bonus for how many allys are nearby. You can add a damage bonus with the Item Damage Bonus ability. Just add an ability based on it to add a damage bonus, and remove the ability to remove the bonus.

 

[Penguin_Buddha]

Thanks so much guys. So your saying I should have a timer, say every second, and a trigger that adjusts the damage bonus provided by an ability based upon the Item Damage Bonus ability?

 

[Saishy]

Thanks so much guys. So your saying I should have a timer, say every second, and a trigger that adjusts the damage bonus provided by an ability based upon the Item Damage Bonus ability?

I Really think that a stack aura is easier...
I just don't know if its possible xD