I thought I saw a car there. lol

Pound them hard!

Definitely a fun spell with some interesting potential uses.

I find the explode logic a bit weird, since the damage might be blocked by external factors but the unit explode on death tag remains regardless, at least in theory.

An awesome looking spell that will surely get a laugh out of players whenever it is used!

The spell works well and is easily configurable. There are, however, two things that need to be fixed:

• The use of zCP_Index variable for both the loop integer and the loop limit is quite confusing and makes the code hard to decipher. Please split these into two variables and give them more descriptive names.
• You're creating a lot of dummy units to stun the affected units. You can reduce the amount of dummies you need drastically by having one global dummy for your system that you use to cast the stun on all units. To do so, set its cast and backswing point to 0, turn rate to 3, movement type to none, movement speed to 0, and move it to the target unit before ordering it to cast (How to create a dummy that can cast more than once).

Awaiting Update

Antares said:

An awesome looking spell that will surely get a laugh out of players whenever it is used!

The spell works well and is easily configurable. There are, however, two things that need to be fixed:

• The use of zCP_Index variable for both the loop integer and the loop limit is quite confusing and makes the code hard to decipher. Please split these into two variables and give them more descriptive names.
• You're creating a lot of dummy units to stun the affected units. You can reduce the amount of dummies you need drastically by having one global dummy for your system that you use to cast the stun on all units. To do so, set its cast and backswing point to 0, turn rate to 3, movement speed to 0, and move it to the target unit before ordering it to cast (How to create a dummy that can cast more than once).

Awaiting Update

Click to expand...

What's turn rate needed for?

It isn't; move speed 0 + movement type none is what gives instant turning.

Pyrogasm said:

It isn't; move speed 0 + movement type none is what gives instant turning.

Click to expand...

Thanks, I forgot the movement type.

Antares said:

An awesome looking spell that will surely get a laugh out of players whenever it is used!

The spell works well and is easily configurable. There are, however, two things that need to be fixed:

• The use of zCP_Index variable for both the loop integer and the loop limit is quite confusing and makes the code hard to decipher. Please split these into two variables and give them more descriptive names.
• You're creating a lot of dummy units to stun the affected units. You can reduce the amount of dummies you need drastically by having one global dummy for your system that you use to cast the stun on all units. To do so, set its cast and backswing point to 0, turn rate to 3, movement type to none, movement speed to 0, and move it to the target unit before ordering it to cast (How to create a dummy that can cast more than once).

Awaiting Update

Click to expand...

Thanks for the review!

Consider them done. But I have one question about recycling point variables in the indexing. Will this leak?

• Custom script: call RemoveLocation(udg_zCP_Point[udg_zCP_CurrentIndex])
• Set VariableSet zCP_Point[zCP_CurrentIndex] = zCP_Point[zCP_MaxIndex]
• Custom script: set udg_zCP_Point[udg_zCP_MaxIndex] = null
• Set VariableSet zCP_MaxIndex = (zCP_MaxIndex - 1)
• Set VariableSet zCP_CurrentIndex = (zCP_CurrentIndex - 1)

I see, yes, it does leak in the current version, but only as a side-effect to a different problem. You're not transfering the location to the new index when you reorder your list after one instance of the spell finishes. This makes the still-running instance use the location you just removed, while the location it should use loses its references and leaks. You can observe the bug when you cast the spell on an empty location and shortly before it finishes on the footmen. You'll see that they take no damage.

It is also a potential issue that you're continuing with the execution of the code within the loop after you remove an instance. Flipping the order of the damage block and the check if stage is 4 block should prevent any bugs of that kind (just see that zCP_Stage isn't off by 1 in the calculations).

In the version you posted, there shouldn't be a leak. The nulling isn't necessary.

Issues were all fixed. (Small new issue: You disabled parts of the map init trigger in your test map)

An awesome spell shipped with its own well-fitting model, surely to get a laugh out of players whenever it is used!

High Quality

Antares said:

Issues were all fixed. (Small new issue: You disabled parts of the map init trigger in your test map)

An awesome spell shipped with its own well-fitting model, surely to get a laugh out of players whenever it is used!

High Quality

Click to expand...

Yes, I did it in order to test out-of-vision situations. Thanks for the moderation!