My spell lags hard

[Sharalala]

Ok i made a spell that bloodlust the unit and gives +5 damage per attack while bloodlusted, but the thing is the first time the unit cast the spell it freezes the game very hard (it doesnt lag if i use it for the second time for the same unit). I have no idea why this happens, i have longer spells and none of them lags at all :S
This are the triggers:

EDIT: i realized there is a mistake in the second line (i just learnt how to leak).

 

[mckill2009]

- for Player1 >>> TriggerPlayer
- Position of triggering unit >>> Posdumyblood
- always save the keys to an integer variable for faster and better performance
- Instead of making another trigger "AddDamage", you could check the
current order of the hero, then the buff in the "Blood Lust End" trigger...

sometimes it's better to do this...
- key triggering unit >>> key of last created unit
- Unit Group Add triggering unit >>> add bloodluster
coz trigger unit key will always overwrite the previous one

 

[Sharalala]

- for Player1 >>> TriggerPlayer
- Position of triggering unit >>> Posdumyblood

ye thanks i already changed that

- always save the keys to an integer variable for faster and better performance

Do you mean that i should put something like "Hashtable - Save (Triggering unit) as 3 of (Key ( "Some integer")) in Hastable"?

- Instead of making another trigger "AddDamage", you could check the
current order of the hero, then the buff in the "Blood Lust End" trigger...

i didnt know i could do that, but woulndt that add damage each times it reads the trigger instead of add damage for each attack?

sometimes it's better to do this...
- key triggering unit >>> key of last created unit
- Unit Group Add triggering unit >>> add bloodluster
coz trigger unit key will always overwrite the previous one

I dont really understand what you put here, why should i key the dummy?

thanks for the help

BTW by "lags hard" i mean it freezes completely the game for 1 second, and i have a very good computer. Maybe its not much but its annoying.

 

[Dr Super Good]

Leaks. If you remove the leaks I am prety sure performance will increase.

You leak atleast 1 location (the one I see is when you create the unit).
You leak internal values into the hashtable (nowhere do you flush it when instances of the spell end.

You might also get inital cast freeze due to loading units and abilities but that will only happen once per game session.

Further optimizations for better performance.
- More efficient algorthim (using an array based system for data lookup instead of hashtables and groups).
- Optimize code using JASS (GUI creates a lot of bloat code).
- Use shorter variable and function names (as JASS is intrpereted).

 

[Maker]

http://www.hiveworkshop.com/forums/miscellaneous-tutorials-456/how-easily-post-triggers-163285/

 

[mckill2009]

Do you mean that i should put something like "Hashtable - Save (Triggering unit) as 3 of (Key ( "Some integer")) in Hastable"?

I dont really understand what you put here, why should i key the dummy

make an integer variable, sample >>> ID

then...

• Custom script: set udg_ID = GetHandleId(GetTriggerUnit())
• Hashtable - Save BloodON as 1 ID in HashtableRouge

i didnt know i could do that, but woulndt that add damage each times it reads the trigger instead of add damage for each attack?

no, coz it checks if it's the "current" attack order
do something like this...

if GetUnitCurrentOrder(YOURUNIT)==851983 then
   //do actions here if your unit has buff
endif