GUI Spell System v1.8.0.0

[Nestharus]

Could we move to getting this a DC?

I personally think that this is a prime DC candidate.



Good job Bribe! : D

 

[Almia]

This should be a Dc. The features it provides is too big :V

 

[Bribe]

Thanks for the positive feedback, you two.

I have updated the demo map to include a "new" (old, actually) spell: Blizzard. It took me about an hour to figure out how to configure everything to line up with the one in Object Editor. The hope is to show how to understand the system by comparing it to a very familiar spell:

• Blizzard Config
  • Events
    • Map initialization
  • Conditions
  • Actions
    • -------- Set the ability from Object Editor which represents the spell --------
    • Set Spell__Ability = Edited Blizzard
    • -------- Set the duration at least as high as the maximum duration in Object Editor. It will stop as soon as the caster is done, anyway. --------
    • Set Spell__Duration = 10.00
    • -------- The Spell__Time is the time between waves. --------
    • Set Spell__Time = 1.00
    • -------- Configure the types of units to be damaged by Blizzard --------
    • Set Spell__Filter_AllowAlly = True
    • Set Spell__Filter_AllowFlying = True
    • Set Spell__Filter_AllowMechanical = True
    • Set Spell__Filter_AllowStructure = True
    • -------- Set the trigger to run when Blizzard is cast --------
    • Set Spell__Trigger_OnCast = Blizzard Start <gen>
    • -------- Set the trigger to run each interval: --------
    • Set Spell__Trigger_OnLoop = Blizzard Wave <gen>
    • -------- Lock in the settings with Spell System by running the system trigger: --------
    • Trigger - Run Spell System <gen> (ignoring conditions)
    • -------- --------
    • -------- Configure the AoE of Blizzard and the number & type of effects: --------
    • Set Blizzard_AoE = 200.00
    • Set Blizzard_Shards[1] = 6
    • Set Blizzard_Shards[2] = 7
    • Set Blizzard_Shards[3] = 10
    • Set Blizzard_FX = Abilities\Spells\Human\Blizzard\BlizzardTarget.mdl

• Blizzard Start
  • Events
  • Conditions
  • Actions
    • -------- Tell the system to run the wave trigger each Spell__Time until the caster is done channeling the ability. --------
    • Set Spell__StartDuration = True
    • -------- Create shards in advance so they hit the ground at the same time the damage is dealt --------
    • Trigger - Run Blizzard Shards <gen> (ignoring conditions)

• Blizzard Wave
  • Events
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Spell__Channeling Equal to False
      • Then - Actions
        • -------- Stop future triggered effects if the caster is no longer channeling the ability --------
        • Set Spell__Expired = True
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Spell__Expired Equal to False
          • Then - Actions
            • -------- Only create new shards if the spell will still continue for at least one more wave --------
            • Trigger - Run Blizzard Shards <gen> (ignoring conditions)
          • Else - Actions
    • -------- Pick all units within designated range of the target point --------
    • Set Spell__InRangePoint = Spell__TargetPoint
    • Set Spell__InRange = Blizzard_AoE
    • Unit Group - Pick every unit in Spell__InRangeGroup and do (Actions)
      • Loop - Actions
        • -------- Have the caster damage all units in the area for 30/40/50 per wave --------
        • -------- For simplicity, I did not do things like damage caps nor reduction against buildings --------
        • Unit - Cause Spell__Caster to damage (Picked unit), dealing (20.00 + (10.00 x Spell__LevelMultiplier)) damage of attack type Spells and damage type Normal

• Blizzard Shards
  • Events
  • Conditions
  • Actions
    • -------- Create shards at random points in the AoE --------
    • For each (Integer A) from 1 to Blizzard_Shards[Spell__Level], do (Actions)
      • Loop - Actions
        • Set TempPoint = (Spell__TargetPoint offset by (Random real number between 0.00 and Blizzard_AoE) towards (Random angle) degrees)
        • Special Effect - Create a special effect at TempPoint using Blizzard_FX
        • Special Effect - Destroy (Last created special effect)
        • Custom script: call RemoveLocation(udg_TempPoint)

 

[Skyflash]

Nice System Bribe
kinda delighted me specially for the clean up part
i should use it to understand it better but according to the video thats a nice Tool for GUI users like me the timer interval thing is nice thing though but still it`s a little complicated when you encounter it for the first time
Goodjob

 

[Bribe]

Updated in-game screenshot, added a spell preview GIF and made a list of all user-accessible variables for reference.

 

[Jampacked1]

Always adored your resources man, but you've really outdone yourself here. Really looking forward to using this in my map!

LOVE THE EFFICIENCY!

Edit: For some reason I feel like Spell_Filter_AllowCaster should be an option in the list of target filters. There are quite a few occasions where the mapmaker might want the spell to target allies but not his own hero. What do you think?

 

[Tasyen]

Awesome System.

 

[Tal'Rarity]

I can't tell what I did wrong in the second spell which is slash, the spin works fine but the slash fails to register a caster unit at the end of channeling.

 

[Bribe]

UPDATE to 1.6.0.0:

Added Spell__InRangeMax to limit the number of units selected by the group to that number. The system integrates a much faster version of "Random N Units in Unit Group" as any extra units are selected at random to be removed from the group.

Added Spell__Trigger_InRangeFilter so the user can specify their own conditions (if desired) to enhance the power of the InRange filter which was otherwise limited to whether the unit has certain properties. You can specify a trigger with only conditions for this variable to work properly. You'll be able to check for things like a unit having a certain buff or being in a certain unit group.

Deprecated Spell__Expired. For backwards-compatibility, it can still be read and set, but I recommend switching to the cleaner "Spell__Duration" reads and sets. When you previously checked if Spell__Expired is True to assess if the spell is about to end, you can now check if Spell__Duration is less than or equal to 0.00. When you previously wanted to terminate the duration early, set Spell__Duration to 0.00.



@DAT-C3 you have the debug message on a part of the code that only runs when the slash has expired.

 

[Tal'Rarity]

@DAT-C3 you have the debug message on a part of the code that only runs when the slash has expired.

Exactly, how come one works when the other fails?

 

[Bribe]

what do you mean? You only mentioned that one thing.

 

[Tal'Rarity]

what do you mean? You only mentioned that one thing.

One thing

[trigger=This works]MS Spin Wave
Events
Conditions
Actions
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
Spell__Channeling Equal to False
Then - Actions
-------- Stop future triggered effects if the caster is no longer channeling the ability --------
Set Spell__InRangePoint = Spell__TargetPoint
Game - Display to (All players) the text: (Name of Spell__Caster)
Set Spell__InRange = 256.00
Animation - Change Spell__Caster flying height to 0.00 at 0.00
Unit Group - Pick every unit in Spell__InRangeGroup and do (Actions)
Loop - Actions
Animation - Change (Picked unit) flying height to 0.00 at 0.00
Set Spell__Expired = True
Else - Actions
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
Spell__Expired Equal to False
Then - Actions
-------- Only create new shards if the spell will still continue for at least one more wave --------
Else - Actions
-------- Pick all units within designated range of the target point --------
Set Spell__InRangePoint = Spell__TargetPoint
Set Spell__InRange = 256.00
Animation - Change Spell__Caster flying height to ((Current flying height of Spell__Caster) + 10.00) at 0.00
Unit Group - Pick every unit in Spell__InRangeGroup and do (Actions)
Loop - Actions
Animation - Change (Picked unit) flying height to ((Current flying height of (Picked unit)) + 10.00) at 0.00
Unit - Cause Spell__Caster to damage (Picked unit), dealing (0.00 + (1.00 x Spell__LevelMultiplier)) damage of attack type Spells and damage type Normal
[/trigger]

[trigger= This doesn't work]slash run
Events
Conditions
Actions
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
Spell__Channeling Equal to False
Then - Actions
-------- Stop future triggered effects if the caster is no longer channeling the ability --------
Set Spell__InRangePoint = Spell__TargetPoint
Set Spell__InRange = 128.00
Animation - Change Spell__Caster's animation speed to 100.00% of its original speed
Game - Display to (All players) the text: (Name of Spell__Caster)
Set Spell__Expired = True
Else - Actions
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
Spell__Expired Equal to False
Then - Actions
-------- Only create new shards if the spell will still continue for at least one more wave --------
Else - Actions
-------- Pick all units within designated range of the target point --------
Set Spell__InRangePoint = Spell__TargetPoint
Set Spell__InRange = 160.00
Unit Group - Pick every unit in Spell__InRangeGroup and do (Actions)
Loop - Actions
Unit - Cause Spell__Caster to damage (Picked unit), dealing (50.00 + (1.00 x Spell__LevelMultiplier)) damage of attack type Spells and damage type Normal
[/trigger]

It doesn't set the casters animation speed back to 100 let alone know the caster from the looks of it.

 

[Spacebuns]

Can the Spell__Interval variable be changed?
Also, I have a spell using this system that needs debugging:

• Ghost viper config
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Set Spell__Ability = Ghost Viper
    • Set Spell__Trigger_OnEffect = Ghost viper effect <gen>
    • Set Spell__Trigger_OnLoop = Ghost viper loop <gen>
    • Trigger - Run Spell System <gen> (checking conditions)

• Ghost viper effect
  • Events
  • Conditions
  • Actions
    • Set Spell__Time = 0.02
    • Set Spell__Duration = 9.99
    • -------- --------
    • Set GhostOn[(Custom value of Spell__Caster)] = True
    • Unit - Add Permanent Invisibility to Spell__Caster
    • -------- --------

• Ghost viper loop
  • Events
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Or - Any (Conditions) are true
          • Conditions
            • UnitMoving[(Custom value of Spell__Caster)] Equal to True
            • Spell__Expired Equal to True
      • Then - Actions
        • Set GhostOn[(Custom value of Spell__Caster)] = False
        • Unit - Remove Permanent Invisibility from Spell__Caster
      • Else - Actions

The other triggers

• Ghost viper effect break attack
  • Events
    • Game - DamageModifierEvent becomes Equal to 1.00
  • Conditions
    • GhostOn[(Custom value of DamageEventSource)] Equal to True
  • Actions
    • Set DamageEventAmount = (DamageEventAmount + 100.00)
    • Set DamageEventType = DamageTypeCriticalStrike
    • Set GhostOn[(Custom value of DamageEventSource)] = False
    • Unit - Remove Permanent Invisibility from DamageEventSource

• Ghost viper effect break spell
  • Events
    • Unit - A unit Begins casting an ability
    • Unit - A unit Uses an item
  • Conditions
    • GhostOn[(Custom value of (Triggering unit))] Equal to True
  • Actions
    • Set GhostOn[(Custom value of (Triggering unit))] = False
    • Unit - Remove Permanent Invisibility from (Triggering unit)

Basically, this spell makes the caster invisible but it will lose invisibility if it moves, attacks, so on. I set duration to 10s. However, in-game, the Permanent Invisibility spell always lasts longer than 10 seconds (if the caster doesn't do any action to break invisibility) after activation.

 

[Bribe]

Can you post all the relevant trigger data?

Yes, you can change Spell__Interval, but you won't need to.

 

[Spacebuns]

I edited my main post.

 

[Bribe]

Hrm. Try setting Spell__Startduration to True when the spell is cast. Also, as it's not animating anything you could use 0.1 instead of 0.02 for the spell time.

 

[Elprede]

In my test map, I register a spell (FK) with the RegisterSpellSystem function, and its loop function does not run.

When I import this spell and its corresponding objects into your demo map, this spell as well as your spells do not function properly. Dummy units do not spawn, enemy units are not knockbacked, casting might even fail, etc.

Notes:
1. FK is registered in a scope initializer.
2. Other spells will work properly once the trigger for FK is disabled.
3. FK will succeed at OnEffect in your demo map if the code for this spell is not in a scope. The loop function still does not run, however.

What is happening? Corruption? What am I doing wrong? Should I not register the spell in a scope initializer?

I will recode the spell in GUI to see if above issues persist.

 

[Bribe]

You have to use the JASS initializer when running this from custom script, as the events might run before Spell System is initialized.

Instead of running the Spell System trigger, you would use something like this script:

function InitTrig_SS_Divine_Shield_Demo takes nothing returns nothing
    //Use of this spell requires you to copy the SpellSystem_Register function from the
    //map header or use the vJass library which contains it.
    call SpellSystem_Register('AHds', function SSDivineShieldDemoEffect, function SSDivineShieldDemoLoop)
endfunction

 

[Elprede]

Is this not the same?

function InitTrig_FK_Spell takes nothing returns nothing
    call RegisterSpellSystem(AbilityID(), function OnCast, function OnLoop)
endfunction

This is what I am currently doing. Problems occur with this setup.

 

[Bribe]

I gotta be honest my Netbook which I used to run WE has a dead battery which I will not replace, and as WE doesn't run on Mac even in the slightest I'm not going to be able to see your map.

That's why I'll need you to post more triggers so I can see your code to help you implement it properly.

 

[Kazeon]

@Bribe, may I suggest to add init event which fires after the spell system is finished configuring (using real events just like your indexer)? So user can register their spells on that event. Since even by using jass codes does not guarantee that it will be executed after your system, afaik.

 

[Bribe]

The JASS function initializes the system if it wasn't already.

 

[Elprede]

//CONFIGURATION
constant function AbilityID takes nothing returns integer
    return 'A003'
endfunction

constant function DummyID takes nothing returns integer
    return 'h000'
endfunction

constant function KnivesCount takes nothing returns integer
    return 18
endfunction

constant function Speed takes nothing returns real
    return 15.
endfunction

constant function Distance takes nothing returns real
    return 500.
endfunction

constant function Origin_Z takes nothing returns real
    return 50.
endfunction

constant function Anim_Speed takes nothing returns real
    return 45.
endfunction

constant function Spiral_Angle takes nothing returns real
    return 4.
endfunction

constant function Damage takes real level returns real
    return 75*level
endfunction

constant function CollisionSize takes nothing returns real
    return 90.
endfunction

constant function AttackType takes nothing returns attacktype
    return ATTACK_TYPE_NORMAL
endfunction

constant function DamageType takes nothing returns damagetype
    return DAMAGE_TYPE_UNIVERSAL
endfunction
//END CONFIGURATION

function OnLoop takes nothing returns nothing
    local integer count = udg_index
    local real angle
    local unit u
   
   
    call BJDebugMsg("Looping!")
   
    loop
        exitwhen count < 0
       
        set u = udg_knives[count]
       
        if udg_dist[count] > 0 then
            set angle = Deg2Rad(GetUnitFacing(u) + Spiral_Angle())
            call SetUnitX(u, GetUnitX(u) + Speed()*Cos(angle))
            call SetUnitY(u, GetUnitY(u) + Speed()*Sin(angle))
           
            set udg_dist[count] = udg_dist[count] - Speed()
        else
            call BJDebugMsg("Done!")
            call KillUnit(u)
            call RemoveUnit(u)
           
            set udg_knives[count] = udg_knives[udg_index]
            set udg_dist[count] = udg_dist[udg_index]
            set count = count - 1
            set udg_index = udg_index - 1
           
            if udg_index < 0 then
                set udg_Spell__Time = 0.
            endif
        endif
       
        set u = null
       
        set count = count - 1
    endloop
endfunction

function OnCast takes nothing returns nothing
    local integer count = KnivesCount()
    local real angle = 360/KnivesCount()
    local real angle2 = 0.
    local unit u = GetTriggerUnit()
   
    call BJDebugMsg("OnCast!")
   
    loop
        exitwhen count == 0

        set udg_knives[udg_index] = CreateUnit(Player(15), DummyID(), GetUnitX(u), GetUnitY(u), angle2)
        set udg_dist[udg_index] = Distance()
       
        if udg_index == 0 then
            call BJDebugMsg("Start Loop!")
            set udg_Spell__Time = 9999.
        endif
       
        set udg_index = udg_index + 1
       
        call SetUnitTimeScale(udg_knives[udg_index], Anim_Speed()*0.01)
        call SetUnitFlyHeight(udg_knives[udg_index], Origin_Z(), 0.)
       
        set angle2 = angle2 + angle
       
        set count = count - 1
    endloop
   
    set u = null
endfunction


function InitTrig_FK_Spell takes nothing returns nothing
    call RegisterSpellSystem(AbilityID(), function OnCast, function OnLoop)
endfunction

 

[Bribe]

I'm not sure what udg_index is, but it's not MUI. You would need it to be an array variable with Spell__Index as the index.

 

[Spacebuns]

Regarding my spell, I think setting Spell__Time to Spell__Interval was able to solve the problem described. However, the base spell has to be a "No Target" spell that will stop the unit upon casting. If the unit still moves after casting then it would defeat the purpose of the spell. Does anyone know of an instant spell in the game that stops the caster after casting?

 

[Elprede]

I'm not sure what udg_index is, but it's not MUI. You would need it to be an array variable with Spell__Index as the index.

udg_index is for placing the dummy units into a list (acts as an unit dummy group) for later reference. Anyway, I have fixed this already. However, this is not the major issue.

The loop function does not run in any tests that I have done until today.

This problem persevered until I used an initial duration as shown in your JASS example and made copies of the original triggers. Loop functions ran for the copies.

 

[Spacebuns]

I might ran into another problem. Spell__CastPoint seems to be not working.

I made a 2-phase spell: phase 1, create dummy units in a 72 degree area in front of the caster with Carrion Swarm, phase 2, when these dummy units cast Carrion Swarm move them forward to resemble a sweeping effect. When testing in the game, the dummy units seem to be moved to the center of the map, and the angles are very wonky.

Phase 1:

• Lance config
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Set Spell__Ability = Sweeping Fangs
    • Set Spell__Trigger_OnEffect = Lance effect <gen>
    • Trigger - Run Spell System <gen> (checking conditions)

• Lance effect
  • Events
  • Conditions
  • Actions
    • Set LanceStartingAngle[Spell__Index] = ((Facing of Spell__Caster) + 36.00)
    • For each (Integer A) from 1 to (2 + (Spell__Level x 2)), do (Actions)
      • Loop - Actions
        • Set LanceStartingAngle[Spell__Index] = (LanceStartingAngle[Spell__Index] - (72.00 / (2.00 + (2.00 x Spell__LevelMultiplier))))
        • Unit - Create 1 Spell__DummyType for Spell__CasterOwner at Spell__CastPoint facing LanceStartingAngle[Spell__Index] degrees
        • Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
        • Unit - Add Carrion Swarm (Neutral Hostile) to (Last created unit)
        • Unit - Order (Last created unit) to Undead Dreadlord - Carrion Swarm Spell__CastPoint

Phase 2:

• Dummy lance config
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Set Spell__Ability = Carrion Swarm (Neutral Hostile)
    • Set Spell__Trigger_OnEffect = Dummy lance effect <gen>
    • Set Spell__Trigger_OnLoop = Dummy lance loop <gen>
    • Trigger - Run Spell System <gen> (checking conditions)

• Dummy lance effect
  • Events
  • Conditions
  • Actions
    • -------- --------
    • Set Spell__Time = Spell__Interval
    • Set Spell__Duration = 1.00
    • -------- --------
    • Set LanceDest[Spell__Index] = Spell__CastPoint
    • Unit - Pause the expiration timer for Spell__Caster
    • Unit - Add Minus Armor Aura (Neutral Hostile) to Spell__Caster
    • Animation - Change Spell__Caster's size to (200.00%, 200.00%, 200.00%) of its original size
    • Animation - Change Spell__Caster flying height to 60.00 at 0.00
    • Special Effect - Create a special effect attached to the origin of Spell__Caster using Abilities\Spells\Undead\DevourMagic\DevourMagicBirthMissile.mdl
    • Set LanceFX[Spell__Index] = (Last created special effect)
    • Special Effect - Create a special effect attached to the origin of Spell__Caster using Abilities\Weapons\WardenMissile\WardenMissile.mdl
    • Set LanceFX2[Spell__Index] = (Last created special effect)

• Dummy lance loop
  • Events
  • Conditions
  • Actions
    • Set LanceDest[Spell__Index] = (LanceDest[Spell__Index] offset by 27.00 towards (Facing of Spell__Caster) degrees)
    • Unit - Move Spell__Caster instantly to LanceDest[Spell__Index], facing (Facing of Spell__Caster) degrees
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Spell__Expired Equal to True
      • Then - Actions
        • Unit - Unpause the expiration timer for Spell__Caster
        • Unit - Remove Minus Armor Aura (Neutral Hostile) from Spell__Caster
        • Special Effect - Destroy LanceFX[Spell__Index]
        • Special Effect - Destroy LanceFX2[Spell__Index]
      • Else - Actions
    • Custom script: call RemoveLocation(udg_LanceDest[udg_Spell__Index])

 

[Bribe]

I'm wondering if you have another spell in your map that's removing a location which is linked to Spell__CastPoint, as you'd get that if the point was removed.

 

[KILLCIDE]

@dtnmang the issue is here:

• Set LanceDest[Spell__Index] = Spell__CastPoint

Removing either of these points will remove both of them. You need to make sure they both have different reference ids, so something like this will work:

• Set LanceDest[Spell__Index] = (Target point of ability being cast)
• Set Spell__CastPoint = (Target point of ability being cast)

I know Spell__CastPoint is being handled in the Spell System, so you wouldn't actually do that, but I just put it down so you understand what i mean by making sure they have difference reference ids.

 

[Spacebuns]

Thanks for the input, @KILLCIDE.
I've tried to debug the spell a bit, here's the new result (I'll just repost them without the "config" triggers)

Phase 1

• Lance effect
  • Events
  • Conditions
  • Actions
    • Set LanceStartingAngle[Spell__Index] = ((Facing of Spell__Caster) + 36.00)
    • For each (Integer A) from 1 to (2 + (Spell__Level x 2)), do (Actions)
      • Loop - Actions
        • Set LanceStartingAngle[Spell__Index] = (LanceStartingAngle[Spell__Index] - (72.00 / (2.00 + (2.00 x Spell__LevelMultiplier))))
        • Unit - Create 1 Spell__DummyType for Spell__CasterOwner at Spell__CastPoint facing LanceStartingAngle[Spell__Index] degrees
        • Unit - Add a 1.00 second Generic expiration timer to (Last created unit)
        • Unit - Add Carrion Swarm (Neutral Hostile) to (Last created unit)
        • Set LanceTarget[Spell__Index] = (Spell__CastPoint offset by 800.00 towards LanceStartingAngle[Spell__Index] degrees)
        • Unit - Order (Last created unit) to Undead Dreadlord - Carrion Swarm LanceTarget[Spell__Index]
    • Custom script: call RemoveLocation(udg_LanceTarget[udg_Spell__Index])

Phase 2

• Dummy lance effect
  • Events
  • Conditions
  • Actions
    • -------- --------
    • Set Spell__Time = Spell__Interval
    • Set Spell__Duration = 1.00
    • -------- --------
    • Unit - Create 1 Spell__DummyType for Spell__CasterOwner at Spell__CastPoint facing (Facing of Spell__Caster) degrees
    • Unit - Add a (2.00 + Spell__Duration) second Generic expiration timer to (Last created unit)
    • Animation - Change (Last created unit)'s size to (200.00%, 200.00%, 200.00%) of its original size
    • Animation - Change (Last created unit) flying height to 60.00 at 0.00
    • Special Effect - Create a special effect attached to the origin of (Last created unit) using Abilities\Spells\Undead\DevourMagic\DevourMagicBirthMissile.mdl
    • Set LanceFX[Spell__Index] = (Last created special effect)
    • Special Effect - Create a special effect attached to the origin of (Last created unit) using Abilities\Weapons\WardenMissile\WardenMissile.mdl
    • Set LanceFX2[Spell__Index] = (Last created special effect)
    • Unit - Add Minus Armor Aura (Neutral Hostile) to (Last created unit)
    • Set LanceDest[Spell__Index] = (Position of (Last created unit))
    • Set LanceDummy[Spell__Index] = (Last created unit)

• Dummy lance loop
  • Events
  • Conditions
  • Actions
    • Set LanceDest[Spell__Index] = (LanceDest[Spell__Index] offset by 25.00 towards (Facing of LanceDummy[Spell__Index]) degrees)
    • Unit - Move LanceDummy[Spell__Index] instantly to LanceDest[Spell__Index], facing (Facing of LanceDummy[Spell__Index]) degrees
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Spell__Expired Equal to True
      • Then - Actions
        • Unit - Remove Minus Armor Aura (Neutral Hostile) from LanceDummy[Spell__Index]
        • Special Effect - Destroy LanceFX[Spell__Index]
        • Special Effect - Destroy LanceFX2[Spell__Index]
        • Custom script: call RemoveLocation(udg_LanceDest[udg_Spell__Index])
      • Else - Actions

Do you think there's still any more issues?

 

[Spacebuns]

edit: Which "event trigger" variable (__OnLoop, __OnEffect, __OnFinish etc.) does the Spell__Completed boolean go with?
Also, it's pretty hard to work around the Banshee Possession (Aps2) spell with the event trigger variables. __OnEffect will trigger when the targeted unit becomes invulnerable and stunned; __OnFinish will trigger when the caster completes or cancels channeling. There's no variable to trigger when the targeted unit actually gets Possessed. Have to use the condition "Owner of Spell__Target equals to Spell__CasterOwner"

 

[KILLCIDE]

Your loop leaks a location. You have to use two locations if you are going to offset it. Also, since it is in a loop, you should remove the location before the next iteration starts. As of right now, since you only remove the location inside the if block, LanceDest[] leaks a lot.

 

[Spacebuns]

I assume since LanceDest[] is set to a new offset location every periodical loop, it only needs to be cleaned up at the final loop. If I clean up LanceDest[] every loop then it will be reset to the center point of the map. But not removing it in every loop leaks too? Wow. Do I have to clean up LanceTarget[] in every For... Integer A loop as well?

 

[KILLCIDE]

Yes. LanceTarget[] will be overwritten by the new LanceTarget[], which creates a memory leak. You need to remove it at the end of the loop iteration so that it's clear for the next iteration.

 

[Spacebuns]

Revised the trigger, it looks like this now. Did I do it correctly?

• Dummy lance loop
  • Events
  • Conditions
  • Actions
    • Set LanceDest[Spell__Index] = (LanceDest[Spell__Index] offset by 25.00 towards (Facing of LanceDummy[Spell__Index]) degrees)
    • Unit - Move LanceDummy[Spell__Index] instantly to LanceDest[Spell__Index], facing (Facing of LanceDummy[Spell__Index]) degrees
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Spell__Expired Equal to True
      • Then - Actions
        • Special Effect - Destroy LanceFX[Spell__Index]
        • Special Effect - Destroy LanceFX2[Spell__Index]
        • Custom script: call RemoveLocation(udg_LanceDest[udg_Spell__Index])
      • Else - Actions
    • Custom script: call RemoveLocation(PolarProjectionBJ(udg_LanceDest[udg_Spell__Index], 25.00, GetUnitFacing(udg_LanceDummy[udg_Spell__Index])))

 

[KILLCIDE]

Yeah it doesn't work like that. You need to use two seperate location variables if you don't want it to leak. You're creating two of the same locations with offsets, but they have competely different reference ids. A TempLoc variable acting as the offset location is fine.

 

[Spacebuns]

Like this?

• Dummy lance loop
  • Events
  • Conditions
  • Actions
    • Set LanceDest_Next[Spell__Index] = (LanceDest[Spell__Index] offset by 25.00 towards (Facing of LanceDummy[Spell__Index]) degrees)
    • Unit - Move LanceDummy[Spell__Index] instantly to LanceDest_Next[Spell__Index], facing (Facing of LanceDummy[Spell__Index]) degrees
    • Set LanceDest[Spell__Index] = (Position of LanceDummy[Spell__Index])
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Spell__Expired Equal to True
      • Then - Actions
        • Special Effect - Destroy LanceFX[Spell__Index]
        • Special Effect - Destroy LanceFX2[Spell__Index]
        • Custom script: call RemoveLocation(udg_LanceDest[udg_Spell__Index])
        • Custom script: call RemoveLocation(udg_LanceDest_Next[udg_Spell__Index])
      • Else - Actions
    • Custom script: call RemoveLocation(PolarProjectionBJ(udg_LanceDest[udg_Spell__Index], 25.00, GetUnitFacing(udg_LanceDummy[udg_Spell__Index])))
    • Custom script: call RemoveLocation(GetUnitLoc(udg_LanceDummy[udg_Spell__Index]))

 

[KILLCIDE]

As I mentioned, you only have to use two locations. You're still using three or four for whatever reason. This is all you have to do:

• Dummy lance loop
  • Events
  • Conditions
  • Actions
    • Set TempLoc = (LanceDest[Spell__Index] offset by 25.00 towards (Facing of LanceDummy[Spell__Index]) degrees)
    • Unit - Move LanceDummy[Spell__Index] instantly to TempLoc, facing (Facing of LanceDummy[Spell__Index]) degrees
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Spell__Expired Equal to True
      • Then - Actions
        • Special Effect - Destroy LanceFX[Spell__Index]
        • Special Effect - Destroy LanceFX2[Spell__Index]
        • Custom script: call RemoveLocation(udg_LanceDest[udg_Spell__Index])
      • Else - Actions
    • Custom script: call RemoveLocation(udg_TempLoc)

 

[Spacebuns]

My LanceDest_Next[] variable is the TempLoc that you've said, but MUI. Also I need to set the LanceDest[] variable to the dummy's position so the dummy can have the effect of moving forward. If I make the loop trigger the way you wrote down (which I did test), the dummies only move once because LanceDest[] has only been declared once in the 'Spell Effect' trigger. Those dummies have effects on them so they need to have triggered movement

 

[KILLCIDE]

Sorry I misunderstood your trigger. You don't need the location variables to be arrays then. You just need two TempLoc variables.

• Dummy lance loop
  • Events
  • Conditions
  • Actions
    • Set TempLoc1 = (Position of LanceDummy[Spell__Index])
    • Set TempLoc2 = (LanceDest[Spell__Index] offset by 25.00 towards (Facing of LanceDummy[Spell__Index]) degrees)
    • Unit - Move LanceDummy[Spell__Index] instantly to TempLoc2, facing (Facing of LanceDummy[Spell__Index]) degrees
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Spell__Expired Equal to True
      • Then - Actions
        • Special Effect - Destroy LanceFX[Spell__Index]
        • Special Effect - Destroy LanceFX2[Spell__Index]
      • Else - Actions
    • Custom script: call RemoveLocation(udg_TempLoc1)
    • Custom script: call RemoveLocation(udg_TempLoc2)

 

[Spacebuns]

I'm wondering, does the system support detecting Toggling on/off of abilities (eg. Immolation)?

 

[IcemanBo]

Such toggling is usually orders, so casting events won't fire. For example when you wanna catch defend/undefend you make an event with "Order without target", and then filter for Order("defend") or Order("undefend"). Same for ohers like "immolation". Sorry, if it wasn't exactly what you wanna know about this system.

 

[Spacebuns]

If I make a trigger with such event, does it fire at the moment I give the unit the toggling order or at the moment the unit "toggles"? Because I can give the unit the order but the unit doesn't "toggle" immediately because it's stunned etc.

 

[IcemanBo]

At the moment the unit receives the order, all triggers with event "A unit gets order with no target" will be fired. But I'm not sure of the difference to "at the moment the unit toogles".

 

[Spacebuns]

"toggles" as in activating. For example my Demon Hunter is stunned and while he's stunned I order him to activate Immolation. It doesn't activate immediately because he's stunned (but will activate once he is no longer stunned). So, does the trigger fire at the moment I order him or the moment Immolation actually gets activated?

 

[IcemanBo]

It might come in order queue and only fire after stun ends, as I think, but you might just also test it I guess.

 

[Spacebuns]

Which Spell OnEvent trigger do I use to detect the moment the spell projectile hits its target? Because I want to make a spell that deals bonus damage (and this damage is based on the caster's attribute) once the target is hit by the projectile, however both OnEffect and OnFinish triggers cause the bonus damage to hit as soon as the projectile leaves the caster.

 

[Bribe]

Which Spell OnEvent trigger do I use to detect the moment the spell projectile hits its target? Because I want to make a spell that deals bonus damage (and this damage is based on the caster's attribute) once the target is hit by the projectile, however both OnEffect and OnFinish triggers cause the bonus damage to hit as soon as the projectile leaves the caster.

You'd use Damage Engine to catch the moment the spell deals damage, provided it's the unit's only damaging spell.

Otherwise, you have to trigger the projectile of the spell so you know yourself when it hits.

 

[Spacebuns]

Interesting tidbit:
Setting Spell__Duration == 1.00 and Spell__Time == 0.2 won't give 5 loop instances, but only 4. Setting Spell__Duration to something slightly higher ( == 1.00 + Spell__Interval for example) will give 5 loop instances properly.

 

[Bribe]

Update!

1.6.1.0 fixes an issue where the duration was decreasing on the first assignment instead of only on ticks. This now works correctly for both pre-assigned durations and newly-assigned ones.

In the test map, I've added a Devour ability to the Knight which tests the same values identified by dtnmang below:

Interesting tidbit:
Setting Spell__Duration == 1.00 and Spell__Time == 0.2 won't give 5 loop instances, but only 4. Setting Spell__Duration to something slightly higher ( == 1.00 + Spell__Interval for example) will give 5 loop instances properly.

To apply the update, only the JASS code needs to be updated.

Thanks dtnmang!