IsUnitMoving()

[Freyleyes]

This is a little code snippet I created for a map I am creating. I could not find a working one anywhere.

Description :

This little piece of code checks if a unit is moving.

Requires :

• JNGP

Show Code

Jass:

library IsUnitMoving initializer init

globals

    private group   CHECKUNITS  = CreateGroup()
    private trigger MAINTRIGGER = CreateTrigger()
    private integer counter     = 0
    MoveData array ARRMove

endglobals

struct MoveData

    unit witchunit = null
    real cX        = 0
    real cY        = 0
    real nX        = 0
    real nY        = 0
    boolean moving = false

endstruct

private function GetIndex takes unit u returns integer

    local integer i = 0
   
    loop
   
        set i = i + 1
       
            if ARRMove[i].witchunit == u then
                return i
            endif
       
        exitwhen i == counter
   
    endloop

    return 0
   
endfunction

function IsUnitMoving takes unit u returns boolean

    local integer i = GetIndex(u)

    return ARRMove[i].moving

endfunction

private function EnumUnits takes nothing returns nothing

    local integer i = GetIndex(GetEnumUnit())
   
    set ARRMove[i].cX = GetUnitX(GetEnumUnit())
    set ARRMove[i].cY = GetUnitY(GetEnumUnit())
   
    if (ARRMove[i].cX == ARRMove[i].nX) and (ARRMove[i].cY == ARRMove[i].nY) then
        set ARRMove[i].moving = false
    else
        set ARRMove[i].moving = true
    endif
   
    set ARRMove[i].nX = GetUnitX(GetEnumUnit())
    set ARRMove[i].nY = GetUnitY(GetEnumUnit())

endfunction

private function onLoop takes nothing returns nothing

    call ForGroup(CHECKUNITS, function EnumUnits)

endfunction

function AddUnit takes unit u returns nothing

    set counter = counter + 1
    set ARRMove[counter] = MoveData.create()
    set ARRMove[counter].witchunit = u
    set ARRMove[counter].cX = GetUnitX(u)
    set ARRMove[counter].cY = GetUnitY(u)
   
    call GroupAddUnit(CHECKUNITS, u)

endfunction

private function init takes nothing returns nothing

    call TriggerRegisterTimerEvent(MAINTRIGGER, 0.05, true)
    call TriggerAddAction(MAINTRIGGER, function onLoop)

endfunction

endlibrary

Use

Jass:

AddUnit(WichUnit)

to add a unit to the check list and use

Jass:

IsUnitMoving( unit WitchUnit)

to check if that unit is moving.

[Anachron]

You don't need a timer at all.
Just register order issues, and change boolean on event.

[TriggerHappy]

I'm sorry, this cannot be approved.

• You use O(n) searches which are very slow and are limited to 8190 registered units.
• Like Anachron said, you could just trigger order events.
• The fact you even need to register units is lame.
• You don't even have recycling.
• You're calling GetEnumUnit() five times when you could just store it in a local.
• "AddUnit" is a to generic name.
• What's the point of using the timer event? Why not just use a timer?
• The struct should be private.
• You could inline IsUnitMoving.

[PurgeandFire]

You could just register order events, but that wouldn't detect SetUnitX/SetUnitY.

EDIT: Although you could probably just hook SetUnitX/SetUnitY/SetUnitPosition and set the boolean to true. The rest you could probably just register the order events.
EDIT2: Then again, you also need to know when the SetUnitXY/Pos stops. =P

[Anachron]

Yes, additionally hook the SetUnitX/SetUnitY() natives and then use a timer with the delay of how long the unit is counted as being moved.

[azlier]

Please... never hook SetUnitX/Y. Those have to be, like, the most frequently called natives ever.

Hooking those makes projectile systems and the like much slower. I prefer manual registry.

Needs fixing.

[Anachron]

Oh yes, didn't thought of the high usage in such systems.

[Freyleyes]

I will update the Script asap. I am reality new at using vJass and don't really understand every thing yet. Thanks for the feedback, will try to make it right :D

[TriggerHappy]

It's been nearly two weeks so I am going to graveyard this. Send me a message when/if you're ready to revive it.