[General] Which of these two short triggers is more efficient and faster?

[Geshishouhu]

function a takes nothing returns nothing
    return 1
endfunction

function b takes nothing returns nothing
    return 2
endfunction

function c takes nothing returns nothing
    return 3
endfunction

function Actions takes nothing returns nothing
    if a then
        ....
    endif
    if b then
        ...
    endif
    if c then
        ...
    endif
endfunction

or

function Actions takes nothing returns nothing
    if 1 then
        ....
    endif
    if 2 then
        ...
    endif
    if 3 then
        ...
    endif
endfunction

They have the same outcome, I just wanna know which one is better in terms of efficiency and speed. Thanks guys.

 

[pOke]

I'm pretty sure 1 function call is the best, so the second.

You always want to reduce function calls when possible to the least necessary

 

[chobibo]

The first example is invalid, the functions don't return anything.

function a takes nothing returns integer
    return 1
endfunction

function b takes nothing returns integer
    return 2
endfunction

function c takes nothing returns integer
    return 3
endfunction

Poke is right.

 

[jonhysone]

The second...

 

[deathismyfriend]

The second is the best way. Function calls are slower than simply checking for a value in an ITE.

The first way also returns value to be checked so its creating 3 extra function calls and then after each function is called it still has to check its value.

 

[FUJI]

I prefer to second, because it is faster than writing a function in a integer.

 

[Arhowk]

neither would parse, the variables aren't evaluated to a boolean.

technically the 2nd is faster because your sparing a function call but it would be picked up by vexorian's optimizer anyway so it doesn't matter

 

[deathismyfriend]

technically the 2nd is faster because your sparing a function call but it would be picked up by vexorian's optimizer anyway so it doesn't matter

if the optimizer isn't used it is faster using the second method.

 

[Arhowk]

if the optimizer isn't used it is faster using the second method.

why are you even caring about efficiency if you dont use the optimizer

 

[Geshishouhu]

Thank you all for the answers.

 

[Nestharus]

you all forget that first way is inlined, so they are equivalent

 

[muzzel]

so they are equivalent

yes, they throw the same parse error.

Apparently Arhowk is the only one here who knows jass... +rep

 

[Arhowk]

you all forget that first way is inlined, so they are equivalent

vexorian's doesnt auto-inline last i checked. (i threw a pjass error next to a line of code that shouldve been inlined and it wasnt) (and thats what i was saying anyway)

e/ You know whats funny? It does, but it only inlines one function, not two+..

        static method addButton takes integer heroIndex, integer buttonId, integer x, integer y returns nothing
            set tree[getLocation(x,y)][getIndex(1, heroIndex)] = buttonId
        endmethod

        function s__VJassTalentTree_addButton takes integer heroIndex,integer buttonId,integer x,integer y returns nothing
            call SaveInteger(Table___ht, (((fuuulibrary___tree) + (fuuulibrary___getLocation(x , y)))), (((1 ) + ( ( heroIndex) * ( fuuulibrary___NUM_OF_DATA + 1 ) ))), ( buttonId)) // INLINED!!
        endfunction

it inlined the getIndex call (1 + heroIndex * numofData+1) but not getLocation(x,y)

    private function getIndex takes integer data, integer heroIndex returns integer
        return data + (heroIndex * (NUM_OF_DATA + 1))
    endfunction
    private function getLocation takes integer x, integer y returns integer
        return (WIDTH*(y))+x
    endfunction

yes, they throw the same parse error.

Apparently Arhowk is the only one here who knows jass... +rep

 

[muzzel]

Script optimization

Since version 0.9.A.0 script optimization is available in jasshelper, it is currently enabled by default, in order to disable optimization you can either enable debug mode or use the --nooptimize argument (jasshelper.exe), newgen should get a menu entry for toggling this option added soon.

At the moment the only available optimization is function inlining. More methods shall be added later including some improved versions of some of wc3mapoptimizer's options.

http://www.wc3c.net/vexorian/jasshelpermanual.html