[Trigger] This loops ten times when it shouldn't

[Tal'Rarity]

Could anyone help me find the problem and solution to it?

It is an item recipe system however our resource database was no help because its 3 or more items required for one recipe and one of the recipes of 3 of the same item-type and since there is basically none of said type of recipe system... yeah in a problem. Though there might be a VJASS one, I never decided to check because well I need a GUI solution.

Settin stuff up

[trigger=]
Events
Map initialization
Conditions
Actions
-------- --------
Set item1[1] = Claws of Attack +3
Set item2[1] = Claws of Attack +3
Set recipe[1] = Claws of Attack +3
Set output[1] = |cff8E388E[1337]|r |cffFF0000Blitzkrieg Blade|r
Set itemamountreq[1] = 3
-------- --------
Set item1[2] = Claws of Attack +3
Set item2[2] = Claws of Attack +3
Set recipe[2] = Mooncrystal
Set output[2] = Crown of Kings +5
Set itemamountreq[2] = 3
-------- --------
Set recipes_ammount = 2

[/trigger]

run

[trigger=]
Events
Unit - A unit Acquires an item
Conditions
Actions
Trigger - Turn off (This trigger)
For each (Integer A) from 1 to 6, do (Actions)
Loop - Actions
Set itemslot[(Integer A)] = No item
For each (Integer ItemRun) from 1 to recipes_ammount, do (Actions)
Loop - Actions
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Item-type of (Item being manipulated)) Equal to recipe[ItemRun]
Then - Actions
For each (Integer A) from 1 to 6, do (Actions)
Loop - Actions
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Item carried by (Triggering unit) in slot (Integer A)) Not equal to itemslot[(Integer A)]
Or - Any (Conditions) are true
Conditions
((Triggering unit) has an item of type item1[ItemRun]) Equal to True
((Triggering unit) has an item of type item2[ItemRun]) Equal to True
((Triggering unit) has an item of type recipe[ItemRun]) Equal to True
Then - Actions
Set itemslot[(Integer A)] = (Item carried by (Triggering unit) in slot (Integer A))
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Integer A) Equal to 3
Then - Actions
Hero - Create output[ItemRun] and give it to (Triggering unit)
Game - Display to (All players) the text: (String((Integer A)))
Game - Display to (All players) the text: (Name of (Item carried by (Triggering unit) of type item1[ItemRun]))
Game - Display to (All players) the text: (Name of (Item carried by (Triggering unit) of type item2[ItemRun]))
Game - Display to (All players) the text: (Name of (Item carried by (Triggering unit) of type recipe[ItemRun]))
Game - Display to (All players) the text: (Name of (Item carried by (Triggering unit) of type output[ItemRun]))
For each (Integer A) from 1 to 6, do (Actions)
Loop - Actions
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Item carried by (Triggering unit) in slot (Integer A)) Equal to itemslot[(Integer A)]
Then - Actions
Item - Remove itemslot[(Integer A)]
Set itemslot[(Integer A)] = No item
Else - Actions
Else - Actions
Else - Actions
Else - Actions
Trigger - Turn on (This trigger)

[/trigger]

 

[Dr Super Good]

The trigger fires itself? You give an item within a trigger responding to an item being acquired. Basically self recursion? Try disabling the trigger before giving the item and then turning it back on afterwards.

 

[edo494]

As DSG pointed out, you have potentionally infinite recursion in there because you fire this event wheb unit receives item, and at that point you potentionally give him item, causing it to fire again and again and again.

 

[Tal'Rarity]

Edit: I feel very stupid right now, thank you DSG and edo494...

One more problem has came up though, when I combine all 3 claws. It works, but when I combine the two claws with the moon key it doesn't work.

 

[Solu9]

I couldn't really figure your trigger out.
But in general using Integer A or B more than once in the same trigger is not a good idea.
Can you try to use Integer B in the second loop?

 

[Tal'Rarity]

I forgot the other item-types, that might explain it. . .

Sorry guys, will edit or reply if I can't solve it.

EDIT: Remade it yet again and can't solve it. Everything has been fixed except yet another issue has risen.

Whenever items get combined in the first 3 slots, it will mess up and only make the first recipe.