SpellMirror v1.0

[Moderator]

17:05, 6th Apr 2011
Bribe:

Such a spell is found too common, in fact there are already sooo many of this type floating around, already written as optimally as possible.

 

[Magtheridon96]

The only issues:

-Readability sux but it doesn't affect functionality
-Your functions reveal that you only converted GUI to JASS
-OrderId2StringBJ is a BJ and could be replaced with a native.
-"chance should be a global constant or just a normal global that differs with ability level.

You did ... ok?
I don't want to ruin your rating, so i'll wait until you improve.
Good luck

 

[HellCEzAR]

-Your functions reveal that you only converted GUI to JASS

ohhh really....so....u have a misstake

 

[Marcos DAB]

Poorly documentation, good spell =/

 

[Axarion]

call UnitApplyTimedLife(MirrorDummy,'BTLF',1.0)

What if the spell is channeling? Or if the casting time is greater than 1 second?

Also you leak two unit variables and the third leaks and has a typo.

And also this really looks like converted GUI with maybe some jass work. It is way to simple to be approved here. Such a spell would anyway work only good if all spells would be triggered.

 

[Adiktuz]

poor readability... and why is there an else statement at the last part of the actions when its empty?

and it only supports targeted abilities... what about custom missiles?

 

[-Berz-]

As far as i see, you need to define every single rawcode of DEFAULT abilities, to make this system/spell work. The bad thing about this is that it will take you 1 day just to define rawcodes of default abilities, but It won't work on custom abilities. And it would be better if you'd just leave in GUI (thou I see you made some editing)

 

[Adiktuz]

@Berz - you don't need to define the rawcodes of all default abilities as this one automatically obtains the rawcode, but it only works if the spell is unit-targeted...


hmmm...

local unit = MirrorDummy ????

Coding is inefficient, and really an eyesore to read...

 

[illegalpie]

You just converted this... And, as stated above, it wouldn't work for custom abilities. You could always MAKE it work, by adding in a triggers space, for example.

globals
integer STORMBOLT = 'A000'
trigger STORMTRIGGER = CastStormbolt
//Then later on...
function OnCast takes nothing returns nothing
     call ExecuteFunc(function STORMTRIGGER)

Although I'd recommend storing the abilities as an array and then looping through them to see which one. But my point is, run the triggers for the custom spells as the caster having it. Or, Better yet, get a damage detection, detect if the unit is HURT from the spell, and just add the ability (Whatever it is) to the caster, and then just order him to use it.

 

[axleion]

@illegalpie: i do believe this will work for custom abilities,
it is just limited to unit targetting ability, either custom or default ability.
but i'm haven't tested if it will work with the Channel spell.

and as Axarion said, i doubt this will work perfectly with channeling spell.
just asking, how about spell blocking ability? will it work perfectly with it?
guess not, hehe

and yes, i do think this is too simple for this kind of thing, and
i do believe i've seen this kind of ability too with the same simplicity.

and for information, you uses global vars declaration, which means your submission is now
categorized as VJass not JASS anymore.
and please admit it, your function name and empty "else" shows that it is a converted GUI,
with few edits around.

thank you