[Snippet] Catalog

[Nestharus]

This resource has moved here.

--

gone

 

[Bribe]

            set w = w + 1
            set catalog = w
            set l[w] = w
            set p[w] = w
            set i[w] = Table.create()
            set r[w] = Table.create()
            set f[w] = Table.create()

That should just be "set catalog = CatalogCreate()" - needless duplicate text

readonly module attributes can still be set by the struct, operators are needed to achieve a truly-readonly value.

The components look good, but I still have to figure out how it interfaces with the save/load portion.

 

[Nestharus]

100% fixed.

There was a bug with retrieving ids and counts of added catalogs, but it all works now ;D.

This can still get a very minor improvement (using a delegate and moving all of the functions into a struct) ;o. The improvement would change the API.

I'll probably implement it tomorrow (would lower the code generated by the module to 4 lines ^_^).

edit
nvm, I realized that the only way to do the stuff like method operator id is to write out the methods for the module

 

[Bribe]

Approved.

 

[Nestharus]

Optimized comparisons and removed extra space

 

[Nestharus]

Added destroy catalog as well as a struct API.


Maximized instance count for catalogs by using tables rather than arrays (catalogs don't need to be fast).



Destruction is 100% proper ; P. For example, if catalog B is added to catalog A and catalog B is destroyed, it is removed from catalog A. If catalog A is destroyed, A is removed from B's added to list.

 

[Magtheridon96]

Good Job Nestharus
The previous version was indeed a piece of shit xD

 

[Nestharus]

How was it bad? lol

 

[Magtheridon96]

No delete = Static catalogs xD
I needed this for dynamic stuff

 

[Nestharus]

what do you need dynamic catalogs for?


I only recently devised a use for dynamic catalogs myself (highly advanced save/load).

 

[Magtheridon96]

I was going to use them for my recipe engine just to see if I'm doing anything wrong when I create a list of struct instances attatched to an item (I had tons of bugs)

 

[Nestharus]

Upgraded CatalogAdd so that you can do crazy stuff like this

struct tester extends array
    private static method onInit takes nothing returns nothing
        local integer c1 = CatalogCreate()
        local integer c2 = CatalogCreate()
        local integer c3 = CatalogCreate()
        local integer c4 = CatalogCreate()
        
        call CatalogAddCatalog(c4,c3)
        call CatalogAddCatalog(c3,c2)
        call CatalogAddCatalog(c2,c1)
        
        call CatalogAdd(c1, 'hrif')
        call CatalogAdd(c2, 'Hpal')
        call CatalogAdd(c1, 'hpea')
        call CatalogAdd(c3, 'hfoo')
        call CatalogAdd(c4, 'hsor')
        
        //hsor: 1
        //hpea: 2
        //hfoo: 3
        //Hpal: 4
        //hrif: 5
        
        call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60,I2S(CatalogId(c4, 'hsor')))
        call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60,I2S(CatalogId(c4, 'hpea')))
        call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60,I2S(CatalogId(c4, 'hfoo')))
        call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60,I2S(CatalogId(c4, 'Hpal')))
        call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60,I2S(CatalogId(c4, 'hrif')))
    endmethod
endstruct

But be warned that if you add the same thing to multiple catalogs along a chain, you will run into problems ; )

struct tester extends array
    private static method onInit takes nothing returns nothing
        local integer c1 = CatalogCreate()
        local integer c2 = CatalogCreate()
        local integer c3 = CatalogCreate()
        local integer c4 = CatalogCreate()
        
        call CatalogAddCatalog(c4,c3)
        call CatalogAddCatalog(c3,c2)
        call CatalogAddCatalog(c2,c1)
        
        call CatalogAdd(c1, 'hrif')
        call CatalogAdd(c1, 'hpea')
        call CatalogAdd(c2, 'Hpal')
        call CatalogAdd(c2, 'hpea')
        call CatalogAdd(c3, 'hpea')
        call CatalogAdd(c3, 'hfoo')
        call CatalogAdd(c4, 'hsor')
        
        //hsor: 1
        //hpea: 2
        //hfoo: 3
        //Hpal: 4
        //hrif: 6
        
        call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60,I2S(CatalogId(c4, 'hsor')))
        call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60,I2S(CatalogId(c4, 'hpea')))
        call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60,I2S(CatalogId(c4, 'hfoo')))
        call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60,I2S(CatalogId(c4, 'Hpal')))
        call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60,I2S(CatalogId(c4, 'hrif')))
    endmethod
endstruct

I could make it so that the problems don't occur, but it's better to do good catalog design than have an insane overhead to deal with the problem ;o (and by insane, I really do mean insane o-o, I implemented it and removed it because of how insane it was o-o).

 

[Bribe]

Why do you have "set d[0]=0" from the module initializer? All the values are already set to 0 from a Table.

 

[Nestharus]

Not quite true. Hashtables auto initialize extremely slowly if the value wasn't already initialized ; P.

 

[Bribe]

Oh my god.

This is JASS what we're talking about, you probably have heard this in a classroom that teaches pro-grade programming. JASS hashtables might work quite differently when you use InitHashtable.

Hashtable just returns 0 if there was no integer, null if no handle or string, 0.00 if no real, false if no boolean.

Is this something I should add to the "Table" library, initializing 0,0 to 0? Is that all it needs to be sped up? I don't get what you're really trying to do with this.

 

[Magtheridon96]

function SpeedUpHashtable takes hashtable h returns nothing
    call SaveInteger(h, 2146689309, -34, 0)
endfunction

function SpeedUpTable takes Table tb returns nothing
    set tb[-2146689309] = 0
endfunction

Useful functions anyone? ;P

 

[Bribe]

It's pretty depressing if you ask me. To be honest the InitHashtable function does everything you need, and I've never run into a situation where hashtables were too slow for the job (provided hashtables needed to be there in the first place).

I'd rather have 1 less line of compiled code.

 

[Magtheridon96]

Well, honestly speaking, the only time I'd want to speed up a hashtable like that is when I'm doing some intense operations (Like the Path library)

 

[Bribe]

Not even that would make sense because the Path library creates the hashtable dynamically meaning that you can't initialize it during the map init phase.

Even if it is 10x slower in-game there won't be more than 256 hashtables and 256x(hashtable lookup)x10 is still not enough to cause any noticable performance difference because it only happens ONE time.

 

[Nestharus]

The thing I am initializing to 0 is the recycler for the specific catalog -.-.


If you notice, I initialize other values to 0 as well >.>.


Guys, that code was in it originally as well. I only modified CatalogAddCatalog


Furthermore, I was talking specifically about JASS hashtables when I mentioned reading an un-initialized value =P.

 

[Bribe]

Benchmarks or it's just a waste of space.

And the reason no one has noticed until now is because your code is utterly unreadable. Utterly.

 

[Nestharus]

Eh, they're the same speed, initialized and un-initialized.

Forgive me, I had heard that from someone else ; P.


Also, you can't have 2 returns.


Finally, LoadInteger doesn't initialize the value : )

struct testers extends array
    private static hashtable table = InitHashtable()
    
    private static method onInit takes nothing returns nothing
        call LoadInteger(table, 0, 0)
        
        if (HaveSavedInteger(table, 0, 0)) then
            call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60,"Saved")
        else
            call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60,"Not Saved")
        endif
    endmethod
endstruct

edit
Made it so that catalogs are properly nested ; )

struct testers extends array
    private static method onInit takes nothing returns nothing
        local integer c1 = CatalogCreate()
        local integer c2 = CatalogCreate()
        local integer c3 = CatalogCreate()
        local integer c4 = CatalogCreate()
        
        call CatalogAddCatalog(c4,c3)
        call CatalogAddCatalog(c3,c2)
        call CatalogAddCatalog(c2,c1)
        
        call CatalogAdd(c1, 'hrif')
        call CatalogAdd(c2, 'Hpal')
        call CatalogAdd(c3, 'hpea')
        call CatalogAdd(c3, 'hfoo')
        call CatalogAdd(c4, 'hsor')
        
        //hsor: 1
        //hpea: 2
        //hfoo: 3
        //Hpal: 4
        //hrif: 5
        
        call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60,I2S(CatalogRaw(c4, 1))+"=="+I2S('hsor'))
        call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60,I2S(CatalogRaw(c4, 2))+"=="+I2S( 'hpea'))
        call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60,I2S(CatalogRaw(c4, 3))+"=="+I2S( 'hfoo'))
        call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60,I2S(CatalogRaw(c4, 4))+"=="+I2S( 'Hpal'))
        call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60,I2S(CatalogRaw(c4, 5))+"=="+I2S( 'hrif'))
        
        /*call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60,I2S(CatalogId(c4, 'hsor')))
        call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60,I2S(CatalogId(c4, 'hpea')))
        call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60,I2S(CatalogId(c4, 'hfoo')))
        call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60,I2S(CatalogId(c4, 'Hpal')))
        call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60,I2S(CatalogId(c4, 'hrif')))*/
        
        call CatalogDestroy(c2)
        call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60,I2S(CatalogCount(c4)))
    endmethod
endstruct

 

[Nestharus]

Fixed 3 bugs that were introduced to the last version and improved the speed of Count, Id, and Raw functions =).


The bug had to do with multiple catalogs added to a single catalog, like adding 4 and 5 to 6. I had only tested 1 catalog added to each catalog, hahahahaha... did I ever encounter the bug? No... I just saw in the code what would happen while improving the speed ; P.

struct testers extends array
    private static method Count takes integer n returns integer
        return n*(n+1)/2
    endmethod
    private static method init takes nothing returns nothing
        local Catalog c1 = Catalog.create()
        local Catalog c2 = Catalog.create()
        local Catalog c3 = Catalog.create()
        local Catalog c4 = Catalog.create()
        local Catalog c5 = Catalog.create()
        local Catalog c6 = Catalog.create()
        local Catalog c7 = Catalog.create()
        local Catalog c8 = Catalog.create()
        
        call c8.addCatalog(c7)
        call c8.addCatalog(c6)
        call c7.addCatalog(c6)
        call c7.addCatalog(c6)
        call c6.addCatalog(c5)
        call c6.addCatalog(c4)
        call c5.addCatalog(c4)
        call c5.addCatalog(c3)
        call c4.addCatalog(c3)
        call c4.addCatalog(c2)
        call c2.addCatalog(c1)
        call c1.addCatalog(c8)
        
        call c1.add(-1)
        
        call c2.add(-2)
        call c2.add(-3)
        
        call c3.add(-4)
        call c3.add(-5)
        call c3.add(-6)
        
        call c4.add(-7)
        call c4.add(-8)
        call c4.add(-9)
        call c4.add(-10)
        
        call c5.add(-11)
        call c5.add(-12)
        call c5.add(-13)
        call c5.add(-14)
        call c5.add(-15)
        
        call c6.add(-16)
        call c6.add(-17)
        call c6.add(-18)
        call c6.add(-19)
        call c6.add(-20)
        call c6.add(-21)
        
        call c7.add(-22)
        call c7.add(-23)
        call c7.add(-24)
        call c7.add(-25)
        call c7.add(-26)
        call c7.add(-27)
        call c7.add(-28)
        
        call c8.add(-29)
        call c8.add(-30)
        call c8.add(-31)
        call c8.add(-32)
        call c8.add(-33)
        call c8.add(-34)
        call c8.add(-35)
        call c8.add(-36)
        
        /*
        call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,6000,I2S(c8.raw(36))+"=="+I2S(-1))
        
        call c7.destroy()
        call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,6000,I2S(c8.raw(36-7))+"=="+I2S(-1))
        */
        
        /*
        call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,6000,I2S(c8.id(-1))+"=="+I2S(36-7))
        
        call c7.destroy()
        call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,6000,I2S(c8.id(-1))+"=="+I2S(36-7))
        */
        
        /*
        call c4.destroy()
        call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,6000,I2S(c8.count)+"=="+I2S(Count(8)-4-2-1))
        
        call c5.destroy()
        call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,6000,I2S(c8.count)+"=="+I2S(Count(8)-5-4-3-2-1))
        */
        
        call DestroyTimer(GetExpiredTimer())
    endmethod
    
    private static method onInit takes nothing returns nothing
        call TimerStart(CreateTimer(),0,false,function thistype.init)
    endmethod
endstruct

 

[Nestharus]

Added the all new Catalog Loop struct ;D

struct Tester extends array
    private static method onInit takes nothing returns nothing
        local Catalog c = Catalog.create()
        local Catalog c2 = Catalog.create()
        local Catalog c3 = Catalog.create()
        local Catalog c4 = Catalog.create()
        local Catalog c5 = Catalog.create()
        
        local CatalogLoop catalogLoop
        local integer value
        
        call c.addCatalog(c2)
        call c.addCatalog(c3)
        call c3.addCatalog(c4)
        call c4.addCatalog(c5)
        
        call c.add(1)
        call c.add(2)
        call c2.add(3)
        call c2.add(4)
        call c5.add(7)
        
        set catalogLoop = CatalogLoop.create(c, 1)
        
        loop
            set value = catalogLoop.next
            exitwhen 0 == value
            call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60,"Found "+I2S(value))
        endloop
    endmethod
endstruct

Brilliant? Yes : P.

 

[Bribe]

value == 0 and 0 == value were benchmarked the exact same. Silly ugly comparisons. Could be processor-specific. I'll run my own tests.

So CatalogLoop helps to find repeat-values in catalogs? What does it do if they are found? Sorry can't read the source code

 

[Nestharus]

So CatalogLoop helps to find repeat-values in catalogs?

no

What does it do if they are found?

Nothing at all?


It is just for looping through all values in a catalog.

 

[Bribe]

Gotcha, well a loop method should be present in any data structure imo.