[Trigger] Request about leaks

[Cryze666]

Hi, my request is not that easy: im working on an rpg map the last 4 years, but i did never understand how to recognize leaks, now i was testing the map and after 5-6h playing wc3 crashes cuz of mem-leaks

so what i want is someone who can look trough the map and fix the most and greatest leaks, if he/she want he will become credits in the map for the work if someone wan't to do this i will post my the map here

btw.: the map is in german if needed i will add some subscriptions to the triggers to explain what they do

 

[Xthreo]

I'll have a look if you want.

 

[Cryze666]

if you need some subsciptions to the triggers i will upload a version with them, i hope you caan do this for me cuz i spend a lot of work into this map and now it is not playable cuz of leaks... you can contact me with pm for other questions

 

[Xthreo]

Since the amount of leaks is to important, I won't fix them but here the leaks I found:
In the "tunnel etc." folder, all your triggers are leaking, don't do :

• Unit - Move (Entering unit) instantly to (Center of Gebiet 292 <gen>), facing (Position of Knight 1419 <gen>)

set points and remove them afterwards:

• Set Point = (Center of Gebiet 292 <gen>)
• Set Point2 = (Position of Knight 1419 <gen>)
• Unit - Move (Entering unit) instantly to (Point), facing (Point2)
• Custom script: call RemoveLocation (udg_Point)
• Custom script: call RemoveLocation (udg_Point2)

Do the same for ALL the triggers you have, I checked them and 80% contains a similar leak where you order units to move to a point, where you move instantly units to a point facing another point, where you create an item/unit on a point, where your respawn heroes at a point, so on so forth...

In the "Compass" and "lager tele" folders, the triggers containing the action :"Center region on point" are leaking. Unfortunately you cannot move a region like this. You must create a region with variable and move it like this:

Trigger Fixed

• red region move
  • Events
    • Time - Every 1.00 seconds of game time
  • Conditions
  • Actions
    • Custom Script: call RemoveRect (udg_RedRegionMoveUp)
    • Custom Script: call RemoveRect (udg_RedRegionMoveUp2)
    • Set Point = (Position of Kampfmagier 0009 <gen>)
    • Set Point_Copy = ((Point) offset by (-15.00, 45.00))
    • Set RedRegionMoveUp = (Region centered at (Point_Copy) with size (200.00, 200.00))
    • Custom Script: call RemoveLocation (udg_Point_Copy)
    • Set Point_Copy = ((Point) offset by (-40.00, 45.00))
    • Set RedRegionMoveUp2 = (Region centered at (Point_Copy) with size (200.00, 200.00))
    • Unit - Move Attribute 1585 <gen> instantly to (Point)
    • Custom Script: call RemoveLocation (udg_Point)
    • Custom Script: call RemoveLocation (udg_Point_Copy)

In the "schilder" folder and the similar ones, you don't have to do :

Trigger

• schild 1
  • Events
    • Unit - A unit enters Gebiet 040 <gen>
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Owner of (Entering unit)) Equal to Player 1 (Red)
      • Then - Actions
        • Cinematic - Clear the screen of text messages for (All players)
        • Game - Display to Player Group - Player 1 (Red) the text: Traceys Waffen und ...
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Owner of (Entering unit)) Equal to Player 2 (Blue)
          • Then - Actions
            • Cinematic - Clear the screen of text messages for (All players)
            • Game - Display to Player Group - Player 2 (Blue) the text: Traceys Waffen und ...
          • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Owner of (Entering unit)) Equal to Player 3 (Teal)
              • Then - Actions
                • Cinematic - Clear the screen of text messages for (All players)
                • Game - Display to Player Group - Player 3 (Teal) the text: Traceys Waffen und ...
              • Else - Actions
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • (Owner of (Entering unit)) Equal to Player 4 (Purple)
                  • Then - Actions
                    • Cinematic - Clear the screen of text messages for (All players)
                    • Game - Display to Player Group - Player 4 (Purple) the text: Traceys Waffen und ...
                  • Else - Actions
                    • Do nothing

Simply edit it to:

Trigger Fixed

• schild 1
  • Events
    • Unit - A unit enters Gebiet 040 <gen>
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Owner of (Entering unit)) Equal to Player 1 (Red)
      • Then - Actions
        • Cinematic - Clear the screen of text messages for (All players)
        • Game - Display to Player Group - Player 1 (Red) the text: Traceys Waffen und ...
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Owner of (Entering unit)) Equal to Player 2 (Blue)
          • Then - Actions
            • Cinematic - Clear the screen of text messages for (All players)
            • Game - Display to Player Group - Player 2 (Blue) the text: Traceys Waffen und ...
          • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Owner of (Entering unit)) Equal to Player 3 (Teal)
          • Then - Actions
            • Cinematic - Clear the screen of text messages for (All players)
            • Game - Display to Player Group - Player 3 (Teal) the text: Traceys Waffen und ...
          • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Owner of (Entering unit)) Equal to Player 4 (Purple)
          • Then - Actions
            • Cinematic - Clear the screen of text messages for (All players)
            • Game - Display to Player Group - Player 4 (Purple) the text: Traceys Waffen und ...
          • Else - Actions

Do the same for the "Schatzkarte"'s triggers, "Atrribut System"'s triggers

I think this will take some considerable time.... this is obviously the boring part of map creation, so GOOD LUCK

 

[Cryze666]

well thx, i try to fix that but i don't think that this is all

 

[BloodDrunk]

that's what happens when you got some serious work with map without first knowing what are leaks and some other things. try to understand them first, and then go make some awesome maps )

I'll have a look at it now and try to fix most of leaks

Man, you have huge huge amount of leaks ), this will take some time haha
and you definitely must reduce the number of objects on map because I can't save it now after what I did...

 

[Cryze666]

im using JassNewGen WE there you can disable the limit of units and doodads, maybe just export the trigger skript-file

y i startetd this map since i was 14 y.o. sso didnt care about leaks xD
i often tried to read the post "things that leak" but i did not understand this, maybe cuz of my english skills....