[JASS] Old Ability work before patch now it just keeps repeating itself

[RedFlash]

function Trig_KunaiDropHiraishin_Conditions takes nothing returns boolean
return GetSpellAbilityId() == 'A003'
endfunction


function Trig_KunaiDropHiraishin_Actions takes nothing returns nothing
local location a = GetUnitLoc(GetTriggerUnit())
    call CreateItemLoc( 'I001', a )
    set udg_HeroYondaimeHiraishinKunaiItem = GetLastCreatedItem()
    call SetItemInvulnerableBJ( udg_HeroYondaimeHiraishinKunaiItem, true )
    call RemoveLocation( a )
    set a = null
        call UnitRemoveAbilityBJ( 'A003', GetTriggerUnit() )
    call UnitAddAbilityBJ( 'A00G', GetTriggerUnit() )
        set udg_HeroYondaimeHiraishinKunaiInt = 0
endfunction

//===========================================================================
function InitTrig_KunaiDropHiraishin takes nothing returns nothing
    local trigger KunaiDropHiraishin = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( KunaiDropHiraishin, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( KunaiDropHiraishin, Condition( function Trig_KunaiDropHiraishin_Conditions ) )
    call TriggerAddAction( KunaiDropHiraishin, function Trig_KunaiDropHiraishin_Actions )
    set KunaiDropHiraishin = null
endfunction

I am still a noob at JASS. This worked fine before the patch ruin it somehow.

 

[Saia_Djinn]

function Trig_KunaiDropHiraishin_Conditions takes nothing returns boolean
return GetSpellAbilityId() == 'A003'
endfunction


function Trig_KunaiDropHiraishin_Actions takes nothing returns nothing
    local unit u = GetTriggerUnit()
    local location a = GetUnitLoc(u)

    set udg_HeroYondaimeHiraishinKunaiItem = CreateItemLoc( 'I001', a )
    call SetItemInvulnerableBJ( udg_HeroYondaimeHiraishinKunaiItem, true )
    
    call UnitRemoveAbility(u ,'A003')
    call UnitAddAbility(u ,'A00G' )
    set udg_HeroYondaimeHiraishinKunaiInt = 0
    call RemoveLocation( a )
    set a = null
endfunction

//===========================================================================
function InitTrig_KunaiDropHiraishin takes nothing returns nothing
    local trigger t = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( t, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( t, Condition( function Trig_KunaiDropHiraishin_Conditions ) )
    call TriggerAddAction( t, function Trig_KunaiDropHiraishin_Actions )

endfunction

the ItemInvunerableBJ is stil there coz i dont know the native now without looking it up but the trigger should work as it is(if you use coordinates and JNGP u can get tis faster but it will work now for what you want to do it)

 

[RedFlash]

Well it works xD, but like the main problem is still there. The spell keeps repeating itself for no reason.

 

[Saia_Djinn]

describe it please what you mean with repeats? it's running without a end? then it must be called from somewhere else

 

[RedFlash]

From what I can tell as soon as the other ability is added after the 1st one is remove it is used. The same thing with the other ability. That's all I can tell

 

[Saia_Djinn]

huh? upload map i take a look

 

[RedFlash]

Umm I don't feel comfortable to put my map on the web yet. So here's a bit more detail explanation as soon as the ability is added it is used. I think it might be the ability I base the spell on ( its a self cast ability it was base on)

 

[Saia_Djinn]

just use channel as base if still no work upload the map here in THIS thread as an attachment nobody will have any problems with that