[JASS] O.o Errors

[Razoron]

function SE takes string SpecialEffect location Loc real Duration returns nothing
 local effect Effect
 
 call AddSpecialEffectLocBJ(Loc,SpecialEffect)
 set Effect=GetLastCreatedEffectBJ()
 PolledWait(Duration)
 call DestroyEffect(effect)
 call RemoveLocation(Loc)
endfunction

I got in JC 29 errors....
Can u tell me correct function, please?

 

[Xarwin]

1) Use the WE Newgen and you will find your mistakes.
2) BJ is mostly converted from GUI to JASS.
3) erhm? Why not 'function SE takes nothing returns nothing' ?

Oh and by the way, you didn't defined your 'Duration' and 'Loc'.
And you 'SpecialEffect' needs to be a "string".

 

[Shadow Daemon]

@Razoron
Function is totally incorrect

// Where are commas between function arguments?
function SE takes string SpecialEffect, location Loc, real Duration returns nothing

  // that is just bad coding style, because:
  // 1. It uses BJ functions
  // 2. It does not set local variable at init
  //    (your variant would also work, but it's lame, seriously)
  
  //local effect Effect
  //call AddSpecialEffectLocBJ(Loc,SpecialEffect)
  //set Effect=GetLastCreatedEffectBJ()

  // the right way to go is:
  local effect Effect = AddSpecialEffectLoc(SpecialEffect, Loc)
 
  // function call needs "call" keyword before function name
  // also, I don't recommend to use PolledWait and TriggerSleepAction,
  // since they are can cause bugs and are not precise (at least).
  // Use timers instead.
  call PolledWait(Duration)
  call DestroyEffect(Effect)
  call RemoveLocation(Loc)
 
  // nullifying Effect variable to prevent "leaks"
  set Effect = null
endfunction

I would recommend to take a look at this: Moyack's TimedEffects Library

 

[Razoron]

Thanks it works.
I also know now how to remove some leaks, now.

 

[Razoron]

But can you tell me how to use timers there?

 

[Deaod]

You dont use timers there. Let other systems do that for you. TimedHandles should be enough for your needs.

function SE takes string path, location loc, real duration returns nothing
    call DestroyEffectDelayed(AddSpecialEffectLoc(path, loc), duration)
endfunction

Note that TimedHandles requires JassHelper to parse your code. You should use JassNewGenPack to use this code.

 

[Razoron]

I use it since i use Jass.

 

[Razoron]

I copied all the code and TimerUtils to the header and i got 331 errors!
Why?

 

[Shadow Daemon]

Ensure you have latest JassNewGenPack (5b) and JassHelper (0.9.G.1). Also "Enable JassHelper" should be checked, "DIsable vJass syntax" should be unchecked (in the menu "JassHelper")

And please do not create another topic with almost the same question.

 

[Razoron]

Works