Map Fatal Error

[Ironside]

Hello, I have a big problem; my map seems to have a fatal error. It happens pretty much every game at a time. Everytime i go play this map with just me and my brother and the rest computers, it always happens short before the 1st hero enters the map. It also happens in different times, it's pretty much random.

Please some one download my map bellow and help me find what is causing the fatal error. As some user posted in the comment, this is the 1st version in which this is happening.

http://www.hiveworkshop.com/forums/maps-564/great-battles-middle-ages-v-8-3-a-162975/

 

[Kala]

No fatal errors on me. Maybe your computer runs out of memory or something?

 

[Ironside]

As said, I'm not the only one getting the fatal error, my brother does and someone posted in comments in the map that he does to.

Also, it doesn't always happen, it just does most of the time.

 

[Kala]

What ever causes it, i think you cant fix it. It may be Warcraft 3 engine error or something. I get these fatal errors too sometimes in various games, even on Ladder games.

 

[N1ghthawk]

I'll take a look at your triggering, but honestly man I had the same problem after implementing some major changes to my AoS map and it took me over a week to narrow down the problem.

The only thing I can tell you is to make damn sure that in the future you test after EVERY change you make, otherwise this unfortunate circumstance will inevitably occur again.


EDIT - i'll take a look at the map tommorow when i'm not as tired (if you haven't figured it out by then)

 

[Ironside]

Yeah as It's only this version of the map, so I must have done something that causes a fatal error, also I did make a very big change in the map, so it might be it.

 

[Ironside]

bump

 

[Ironside]

bump

 

[VoidLordXtreme]

since you got alot of init triggers, you might use the custom script: call DestroyTrigger(GetTriggeringTrigger()) on triggers you only use once...

i also had such a problem.. however i could never really solve it... but the custom script should help..

what i did to my map: i copied the unit data and made a completely new map... made everything, besides of object data, new

 

[Ironside]

That's too much to do, but I'll do the destroy trigger

 

[VoidLordXtreme]

i mean... its only how i solved it..
the question is: what kind of error appears exactly?

 

[Ironside]

i mean... its only how i solved it..
the question is: what kind of error appears exactly?

It's not the same, sometimes just a box with msg: war3.exe has encountered an error and needs to close.

The other times: that big box, I don't know exactly what text it has...

 

[Dr Super Good]

Try reducing group usage. There is also a number of group letks you should try and fix.

 

[Ironside]

Leaks, I don't have any...Atleast I don't find any.
Groups? I don't think I have that many, and I destroy them anyway.

 

[Dr Super Good]

I spotted atleast 1 group leak, and maybe many more.

Try using integers to count the change, not recounting the groups every few seconds.

 

[Ironside]

If you found groups leaks, I'm all open.

 

[Dr Super Good]

There was one in the initialization trigger, you have a double group generation yet only 1 destoy.

Still is not an excuse for creating and destroying so many groups. I advise implimenting group recycling and trying to use integers to keep track of unit numbers instead of constant unefficent recounting of units in groups.

As for the crash, this might only imrpove stability but probably will not fix it. Try disabling the custom spells as they are normally a major cause. Try disabling the AI, as a bug in that can also crash. If all fails try and see if turning all triggers off prevents the crash. If the crash still persists its non trigger related so try messing with object editor spells and stuff.

I seriously believe the crash might be AI related, as that is the sort of thing the AI can do due to its randomness.

 

[Ironside]

It's possible, however I do believe the AI has nothing to do with it, as this fatal error wasn't always in the map, it appeared when I made a giant new version.

So I'll check the triggers


EDIT: It really is the AI, I checked, and everytime there are AIs inside it gives the error. Any ideas?

 

[Ironside]

bump

 

[Tamisrah]

No crash for me =/
Could you give an explanation what to do to make it crash?

 

[Ultimazed]

Try Disabling the sound & music when playing and see if it still crashes.

 

[Ironside]

Play with all 12 with full house, all AIs. And you'll get a fatal error sometime in the game.

How will disabling sound & music here T_T

 

[Axarion]

Maybe recycle timers and groups etc? dunno what else or do units leave the map bounds?

 

[Dr Super Good]

I definatly say your use of groups might have something to do with the crash.

Unlike the upcomming SC2, the trigger engine is not very robust, and prone to faults. These faults vary from internal leaks (you can not fix these as they are inside the engine) to crashes.

Groups are one of the most advanced object types you can create, as they include some form of hash ontop of a list. Especially when units are removed, they still remain in the group and will still be picked for enums. All it needs is a removed unit to be picked from a group and inserted into some unrobust natives and you can quite possible get a crash. The same goes for inserting any nonsense value as an object.

These crashes are almost impossible to spot. The only way to avoid them is to code properly from the start. Thus I still advise reducing the usage of groups in your map to a few static or recycled groups and then keeping track of unit numbers via a counter system rather than recounting the units in a group perodically.

It is best to disable every part of your map until the crashes stop, then you know which parts were not causing the crash and have a small scope to work on finding the crash in. It could be something as stupid as an invalid object field or rounding error.

 

[Ironside]

I have already posted that the AI is doing the crash. It has nothing to do with my triggers.

 

[Dr Super Good]

Oh sorry.

Check for leaks in the AI script. Also it might be caused by the AI doing something invalid like ordering a building outside the map boundries.

 

[Ironside]

I don't think that would be the case, as I really don't seem to have added anything special to the AI after version 8.1
And before 8.1 it was working perfectly...

 

[Dr Super Good]

Yes, but what you changed in 8.1 might have unintentionally affected the AI. Before the AI interaction was safe and never crashed, now the same AI script is entering an invalid state which results in a crash.

The crashes could be caused by a whole number of things. Changed object data where the AI now is trying to make or use stuff it can not. Changed terrain where before a procedure for placement worked perfetly, but now its entering an invalid state. It could just be something as stupid as you changed something yet did not update the AI to mirror that change.

This is one of the most common forms of bug in programming. Where updating something for somereason causes another part to break.

 

[Ironside]

Terrain = same
I think it could be that he tries to build something he cannot. I'll look it.