[Trigger] Help with fixing a leak

[joel79]

Spell link: Naruto Rendan/ Rasengan - The Hive Workshop - A Warcraft III Modding Site

UMMMMM Dr. Super Good put this comment for my spell:

"-Fix event leak, currently it leaks 1 trigger event every cast for the rest of the game."

Can someone show me what i have to change in order to fix that??

 

[Mooglefrooglian]

Edit: Nope XD.

If I msay suggest to save yourself a little bit of length of code.. in the Rendan trigger, you have two ifs that could easily be combined into one If/Then/Else. You check if the unit has the buff Rasengan, if it doesnt, then you do something. Then you check if it DOESNT have something. Just put the code from one into the Else part of the other.

At least, looking at your trigger, Im assuming that you could do that. It seems like you check if the unit has the buff Rasengan = true, and in another if = false, but whatever.

Nice spell by the way. Even if I hate Naruto, it does look neat.

 

[TheBlooddancer]

You do know, that it crashes the game?

 

[joel79]

You do know, that it crashes the game?

Rarely and thats cause of this leak i can't seem to identify and i need help finding/ fixing

 

[darkrider]

• Rasengan Effect Start
  • Events
    • Unit - A unit Is attacked
  • Conditions
    • And - All (Conditions) are true
      • Conditions
        • ((Attacking unit) has buff Rasengan ) Equal to True
        • (Attacking unit) Equal to RasenganCaster
  • Actions
    • Set RasenganTarget = (Attacked unit)
    • Trigger - Add to Rasengan Effect Finish <gen> the event (Unit - (Attacked unit) Takes damage)

here is the leak... DSG means that everytime a unit is attacked you add that unit to the trigger event... no matter if the unit is already in that event, you are adding the same unit again and again... you can use a unit group, check if the attacked unit is in the group... if it is NOT in the group, add it to the event and add it to the group... else do nothing

EDIT: btw... if you have removed the naruto model then add some model into the rendan spell coz those are only shadows (or is it supposed to be like that?)

EDIT2: and the crash is not made by the leak... your crash is an infinite loop somewhere in the code... i think that it is caused because you are using a 1 second cooldown in the spell and a 3 seconds wait in the trigger

EDIT3: btw... plz remove caster's shadows ... it is not nice to see those things

 

[joel79]

• Rasengan Effect Start
  • Events
    • Unit - A unit Is attacked
  • Conditions
    • And - All (Conditions) are true
      • Conditions
        • ((Attacking unit) has buff Rasengan ) Equal to True
        • (Attacking unit) Equal to RasenganCaster
  • Actions
    • Set RasenganTarget = (Attacked unit)
    • Trigger - Add to Rasengan Effect Finish <gen> the event (Unit - (Attacked unit) Takes damage)

here is the leak... DSG means that everytime a unit is attacked you add that unit to the trigger event... no matter if the unit is already in that event, you are adding the same unit again and again... you can use a unit group, check if the attacked unit is in the group... if it is NOT in the group, add it to the event and add it to the group... else do nothing

EDIT: btw... if you have removed the naruto model then add some model into the rendan spell coz those are only shadows (or is it supposed to be like that?)

EDIT2: and the crash is not made by the leak... your crash is an infinite loop somewhere in the code... i think that it is caused because you are using a 1 second cooldown in the spell and a 3 seconds wait in the trigger

EDIT3: btw... plz remove caster's shadows ... it is not nice to see those things

hahaha damn thanks for the help!!!!

 

[darkrider]

np man ^^