[Trigger] help gold gain and alive

[xXHiroshiXx]

guys help me!

A player gain gold every 2 seconds when he is alive. Then stop gaining gold when he is dead.

help please

sorry, I do not know how to write English I'm using google translator.

sonofjay(thanks for understanding)

 

[trolly056]

Can't understand, what exacly do you want ?

 

[overcold_ice]

please elaborate . . . . ur problem

 

[sonofjay]

I think this is what he is trying to say...

A player gain gold every 2 seconds when he is alive. Then stop gaining gold when he is dead.

I think he mean every 2 seconds and so on on the word "more"


Well still can't help if you don't clear it yourself.

 

[xXHiroshiXx]

Now you can understand?

 

[Magtheridon96]

You need a boolean array first.
Whenever the hero dies, just set Boolean[(Player number of (Triggering player))] = true
This boolean tracks whether the hero is dead or not.

When the hero is revived, set this boolean to false.

Then, every 2 seconds, add the gold like this:

• Trigger
  • Events
    • Game - Every 2.00 seconds of game-time
  • Conditions
  • Actions
    • For each (Integer A) from 1 to NUMBER_OF_PLAYERS_IN_YOUR_MAP, do (Actions)
      • Loop - Actions
        • If (Conditions) then do (Then - Actions) else do (Else - Actions)
          • If - Conditions
            • DeadHero[Player((Integer A))] Equal to True
          • Then - Actions
            • Player - Add 2 to Player((Integer A))'s gold
          • Else - Actions

DeadHero is the name of the boolean array I used here.

 

[defskull]

You don't have to loop through all players (less efficient)

When you can just add the money to a Player Group variable ?

• Player Group - Pick every player in PlayerGroupUnitAlive and do (Actions)
  • Loop - Actions
    • Player - Add 1000 to (Picked player) Current gold

Of course, when the unit dies, remove the Player owning the Unit from the Player Group, if the unit is revived back, add the Owning Player of the Unit to the Player Group.

It works more efficient I think since it doesn't need loop, which you will have a maximum loop of 12 (for 12 players).

Looping 12 actions is less efficient than just a single-time action. Not to mention you are doing this periodically for 2 seconds per event.

 

[Bribe]

@ defskull - Picking all players is way less efficient, like 30*(number of players) times less efficient, actually.

The more you know.

 

[defskull]

So looping is more efficient, cool...

But, if you loop, you will loop to every player (no matter his gold needs to be added or not)

If you have a Player Group, it will only pick the Player that needs to be added gold only, sounds more reasonable ?

Instead of picking all 12 players, the system just pick a selected player from the group (let's say just 4 of them, instead of 12 (Looping))

 

[Bribe]

If you pick even one player in a player group, it is slower than looping through all 16 players.

 

[defskull]

So basically, Hashtable is slower than Index ?
Because Hashtable works by saving unit in a unit group that will be later picked, and refer its ID of the unit.

Is Player Group = Unit Group ? (in term of usage efficiency)

 

[xXHiroshiXx]

thanks for the help of all, PROBLEM SOLVED!

• Protetor
  • Events
    • Map initialization
  • Conditions
  • Actions
    • For each (Integer A) from 1 to 10, do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Player((Integer A))) slot status) Equal to Is playing
            • ((Player((Integer A))) controller) Equal to User
          • Then - Actions
            • Unit - Create 1 Protetor for (Player((Integer A))) at (Center of Players Start <gen>) facing Default building facing degrees
          • Else - Actions

 

[Bribe]

@defskull, yes, which is why I always recommend people to use Hanky's Dynamic Indexing. Of course you can use hashtables or Unit Indexer instead, and I'm not gonna fault it because I think the code is pretty intuitive and readable, and the efficiency doesn't suck so hard. Creating a unit is like 100x more overhead.