[vJASS] Double Free Errors.

[khamarr3524]

[Solved] Double Free Errors.

I'm experiencing some double free errors and I'm not certain where from. It's most certainly from how I clean up after the buff wears off, of when the buff overshoots the mana. Ideas?

library ArcDrain initializer init uses RegisterPlayerUnitEvent, TimerUtils
    globals
        private constant integer SPELL_ID  = 'ArcD'
        private constant integer BUFF_ID   = 'Arcs'
        private constant real MSPEED       = .35
        private constant real TIMERTIME    = 4.
        private constant real TURNOVER     = .25 
    endglobals
    
  struct ArcDrain
        private real TIMEOUT
        private boolean DEALLOCATEME
        private timer TIMER
        private unit CASTER 
        private unit TARGET
        private real DRAIN
        
        private method destroy takes nothing returns nothing
            set this.CASTER = null
            set this.TARGET = null
            set this.TIMER = null
            call this.deallocate()
        endmethod
        
        private static method periodic takes nothing returns nothing
            local thistype this = GetTimerData(GetExpiredTimer())
            local real targetMana = GetUnitState(this.TARGET, UNIT_STATE_MANA)
            local real casterMana = GetUnitState(this.CASTER, UNIT_STATE_MANA)
            local boolean giveMana = true
            if this.TIMEOUT <= 0 then
                call ReleaseTimer(this.TIMER)
                set this.DEALLOCATEME = true
            elseif targetMana < this.DRAIN then
                set this.DRAIN = (targetMana / 4)
                set this.DEALLOCATEME = true
                call ReleaseTimer(this.TIMER)
            elseif casterMana == GetUnitState(this.CASTER, UNIT_STATE_MAX_MANA) then
                set giveMana = false
            endif
            call SetUnitState(this.TARGET, UNIT_STATE_MANA, (GetUnitState(this.TARGET, UNIT_STATE_MANA) - this.DRAIN))
            if giveMana then
                call SetUnitState(this.CASTER, UNIT_STATE_MANA, (GetUnitState(this.CASTER, UNIT_STATE_MANA) + R2I(this.DRAIN * TURNOVER)))
            endif
            set this.TIMEOUT = this.TIMEOUT - 1
            if this.DEALLOCATEME then
                call this.deallocate()
            endif            
        endmethod
        
        private static method spell takes nothing returns nothing
            local unit u = GetSpellAbilityUnit()
            local unit uu = GetSpellTargetUnit()
            local thistype this
            if not IsUnitType(uu, UNIT_TYPE_DEAD) and not IsUnitAlly(uu, Player(GetPlayerId(GetOwningPlayer(u)))) then
                set this = thistype.create()
                set this.CASTER = u
                set this.TARGET = uu
                set this.DRAIN = ((GetUnitAbilityLevel(u, SPELL_ID)*20)+50)
                set this.TIMER = NewTimer()
                set this.TIMEOUT = TIMERTIME
                call SetTimerData(this.TIMER, this)
                call TimerStart(this.TIMER, 1., true, function thistype.periodic)
            endif
        endmethod
        
       static method cast takes nothing returns nothing
            if GetSpellAbilityId() == SPELL_ID then
                call thistype.spell()
                return
            endif
        endmethod
    endstruct
    
    private function init takes nothing returns nothing
        local trigger t = CreateTrigger()
        call RegisterPlayerUnitEvent(EVENT_PLAYER_UNIT_SPELL_CAST, function ArcDrain.cast)
        set t = null
    endfunction
endlibrary

 

[mckill2009]

1) remove this call .destroy() and this block if this.DEALLOCATEME then should be call .destroy()
2) also you need to thistype.create() only if you meet the conditions...

EDIT:
what I mean of #1 is you dont need the DEALLOCATEME, and the "if's" needs more improvement...

 

[khamarr3524]

- remove this call .destroy() and this block if this.DEALLOCATEME then should be call .destroy()
- also you need to thistype.create() only if you meet the conditions...

1. Done.
2-3. But how else would I do this? If the timeout is 0, it needs to run through another tick. Or should I expand the time one second to compensate?

 

[mckill2009]

private static method spell takes nothing returns nothing
   local unit u = GetSpellTargetUnit()
   local unit uu = GetTriggerUnit()
   local thistype this
   if not CONDITIONS HERE then
      set this = thistype.create()
         ///codes here 
   endif
   set u = null
   set uu = null 
endmethod

 

[khamarr3524]

What could I use instead of DEALLOCATEME. And if I can get rid of that, it will make cleaning up this if's easier.

 

[khamarr3524]

Solved. Thanks. You always have good assistance Mckill xD