• Listen to a special audio message from Bill Roper to the Hive Workshop community (Bill is a former Vice President of Blizzard Entertainment, Producer, Designer, Musician, Voice Actor) 🔗Click here to hear his message!
  • Read Evilhog's interview with Gregory Alper, the original composer of the music for WarCraft: Orcs & Humans 🔗Click here to read the full interview.

Custom Spells changing darkness/light

Status
Not open for further replies.
Level 7
Joined
Aug 15, 2012
Messages
318
I have a few custom spells that are in my rpg that seem to cause a problem that when they are cast any objects that I changed the r,b,g setting for get reverted back to default and the map changes from day or night upon cast I have looked at the triggers and not seen anything that could have caused this there could be many different triggers that could be causing this so hard to upload them all but if you want I can send you the map and see if you could maybe find out the problem or tell me if you have had the same
 
u really need to look for a leak removing tutorial as u have a ton of leaks.

also since u already use some vJass u should look for some better systems to the ones that r in jass and gui
you should also consider changing all ur gui triggers over to jass / vJass as the added efficiency in a rpg is well needed

i think ur problem is w the animation of set flying height
 

Dr Super Good

Spell Reviewer
Level 65
Joined
Jan 18, 2005
Messages
27,290
For systems that access global properties like unit colour and time of day, a separate system should be used to manage concurrent access.

For example, lets say a hero has 3 abilities.
Ability 1 locally changes the colour of the caster to green and the target to red for the caster owner for 10 seconds.
Ability 2 globally changes the colour of all targets to yellow for 7 seconds.
Ability 3 gradually changes the colour of the target from blue to yellow over 3 seconds.

If all 3 abilities were cast at the same time on a single target, what colour should he be for what player at any given time? This is why a separate system is needed to manage this property, as otherwise you could get any number of strange bugs occurring including loss of colour when inappropriate or low priority abilities overwriting higher priority abilities with their colours.

Time of day is even worse as that can directly impact game mechanics such as life regeneration, mana regeneration and even the usability of some abilities.
If a hero casts an ability that changes the time of day to night for 30 seconds at the same time another hero casts an ability that changes the time of day to day for 30 seconds, what should the time of day be? For balance you might want both abilities to cancel each other out where their durations overlap and restore time to normal.
 
Status
Not open for further replies.
Top