[System] MissileRecycler

[Flux]

It would be great if this had some benchmarks.
GetRecycleUnit vs CreateUnit

 

[Bribe]

http://www.wc3c.net/showpost.php?p=1132430&postcount=12

 

[Flux]

http://www.wc3c.net/showpost.php?p=1132430&postcount=12

Useful, by the way what is the unit (measurement) of the Cost which is FC? And what does the Count mean?

 

[Bribe]

FC == Function Call. I think the "count" was how many he used per .025 seconds so that their FPS was the same. Keep in mind that his recycling method is largely unoptimized, so MissileRecycler is probably 8-10 times faster than creating and removing.

 

[Flux]

^ Ahh ok. Thanks Bribe

EDIT: It turns out, it was in the first post.

 

[Almia]

I think you should fix the part when users try to change the dummy ownership. When recycled, the dummy does not return to Neutral Passive :/

 

[Bribe]

Updated with that change, and set the dummy owner to Player 13 instead of 15. If I am not mistaken, Player 13 is Neutral Extra. That player can cast both positive and negative buffs on the same target.

 

[Almia]

Updated with that change, and set the dummy owner to Player 13 instead of 15. If I am not mistaken, Player 13 is Neutral Extra. That player can cast both positive and negative buffs on the same target.

Thank you

I can now update DummyCaster

 

[Almia]

Sorry for double-posting

I found out that dummies still cost 1 food

also somehow it shows the idle worker icon

 

[Almia]

Bribe :V

Please fix this :V

 

[Bribe]

Thank you for the reminder, I missed your first post somehow. Fixed.

 

[Almia]

May I ask a question?

I thought you will use Neutral Extra(which is 14), but why did you use Neutral Victim instead?

 

[Bribe]

I couldn't figure out if it was player 13 or player 14 and there was no information about which one was which online. Well, thanks for the correction, I've updated it again.

 

[BPower]

It's documented in the blizzard.j

// Game constants
...
constant integer bj_MAX_PLAYERS = 12
constant integer bj_PLAYER_NEUTRAL_VICTIM = 13
constant integer bj_PLAYER_NEUTRAL_EXTRA = 14
...

 

[Bribe]

Aha, I was searching for it without the bj_ prefix. Thanks!

 

[Nestharus]

When'll you implement this?

http://www.hiveworkshop.com/forums/2809461-post7.html

 

[Bribe]

That looks different from the last diagram you made. Did you change something or did you illustrate it with more detail?

 

[Nestharus]

More detail probably : )

Didn't answer my question though : o

 

[Bribe]

"when" is tough to say. I don't have much motivation to do that right now.

 

[Kazeon]

function GetRecycledMissile takes real x, real y, @real z@, real facing returns unit

I think dummy's fly height won't work if we don't have AutoFly. So is it a must to use AutoFly?

Also, are we supposed to chose from one of those unit indexers or we are allowed not to have any unit indexer?

 

[Bribe]

No indexer needed. The dummy is supposed to have a raven form ability in Object Editor. The Object Merger statement will set all that up automatically.

 

[Almia]

The unit indexer is just for catching one of those to be disabled when creating the dummy units.

 

[Kazeon]

I thought the ability should be removed before we can modify the fly height.
Btw, what do you think about adding delay parameter to RecycleMissile function? So that we can choose to remove the dummy immediately or not.

 

[Almia]

I thought the ability should be removed before we can modify the fly height.
Btw, what do you think about adding delay parameter to RecycleMissile function? So that we can choose to remove the dummy immediately or not.

then why not use Flux' DummyRecycler

or why not turn the Vertex ARGB of the dummy to 0, 0, 0, 0, since the appearance only resets when getting the recycled dummy

 

[Bribe]

Removing the ability is only done for units who you can click on so their command card isn't weird. The only reason to remove it from a dummy is if the dummy has another ability sharing that order string. Likely never happened in all WC3 history.

The DEATH_TIME is a constant. It allows all standard missile death animations to pass in that span.

 

[Kazeon]

I'm having fps drop problem since the dummy units never reset to their original position (map edge). Guess I will have to do it manually.

 

[Bribe]

How many dummy units?

 

[Kazeon]

This is the spell. It fires a lot of missiles. So I'm sure there are a lot of dummy units as well. I tried to replace the dummy's model with abomination and yes, there were indeed a lot of dummy units. But it's anticipated now.

 

[Bribe]

I've updated the constant for the Dummy owner to be identical between 1.29 and legacy versions, though this is kind of pointless in 1.29 with the ability to modify a special effect without needing to attach it.

 

[Almia]

This is still not obsolete since DummyCasters need insta-facing.

 

[Bribe]

Not rly. If you remove the 'Amov' ability from them they don't have to turn to cast. I've used this technique in some of the spells I fixed up for some members, though credit goes to either Maker or PurgeAndFire.

 

[Almia]

I was about to drop a reply in regards with Dummy Caster system using MissileRecycler, but then I saw Bribe's last reply. Gonna try that weird stuff.