Simple "yes or no" question about leaks

[darwin]

• Unit Group - Pick every unit in (Units owned by Player 7 (Green) of type Boulder) and do (Actions)
  • Loop - Actions

Does this action leak a unit group?

 

[ukn0wnD3str0y3r]

I believe that every unit group need to clear it so, yes maybe @@
use bj_wantDestroyGroup = true before the group picking

 

[chobibo]

Yes.

 

[JustNrik]

• Unit Group - Pick every unit in (Units owned by Player 7 (Green) of type Boulder) and do (Actions)
  • Loop - Actions

Does this action leak a unit group?

• Unit Group - Pick every unit in (Units owned by Player 7 (Green) of type Boulder) and do (Actions)
  • Loop - Actions

Yes

• Custom script: set bj_wantDestroyGroup = true
• Unit Group - Pick every unit in (Units owned by Player 7 (Green) of type Boulder) and do (Actions)
  • Loop - Actions

No

 

[darwin]

Thanks for the help everyone, +rep all around.

I thought there was some exception to the unit group leak if you picked all units of a particular type... I don't know where I got that from, but it's a simple fix.

Thanks again!

 

[IcemanBo]

PickEveryUnitByPlayerOfType:

function GetUnitsOfPlayerAndTypeId takes player whichPlayer, integer unitid returns group
    local group g = CreateGroup()
    set bj_groupEnumTypeId = unitid
    call GroupEnumUnitsOfPlayer(g, whichPlayer, filterGetUnitsOfPlayerAndTypeId)
    return g
endfunction

^Does not recycle the HandleId of "g".

PickEveryUnitOfType:

function GetUnitsOfTypeIdAll takes integer unitid returns group
    local group   result = CreateGroup()
    local group   g      = CreateGroup()
    local integer index

    set index = 0
    loop
        set bj_groupEnumTypeId = unitid
        call GroupClear(g)
        call GroupEnumUnitsOfPlayer(g, Player(index), filterGetUnitsOfTypeIdAll)
        call GroupAddGroup(g, result)

        set index = index + 1
        exitwhen index == bj_MAX_PLAYER_SLOTS
    endloop
    call DestroyGroup(g)

    return result
endfunction

^Does not recycle the HandleId of "g" and "result". -> leaks 2 references -> worse.

You probably have seen one of Maker's posts, iirc he was one guy who recommended not to use it.

 

[NightStalker]

I know it leaks for unit group but what about destructible group? Does that leak too if I dont put this: Custom script: set bj_wantDestroyGroup = true, before

 

[IcemanBo]

You should open a thread if you have your own question about leaks.

But the answer: There does not exist something as "destructible group" that could leak. "bj_wantDestroyGroup" is only for unit groups.

 

[NightStalker]

I've been waiting for a thread to ask

Thanks for the answer