[JASS] Random Unit Of Group

[Anachron]

Hey guys,

a few ago when I did some mapping and used FirstOfGroup() it was always random.

Now when I use it it ALWAYS is the first unit when I test the same group.
I also changed my editor settings to NOT have fixed random values in the settings dialog.

Is there anything else I have to take care of?! Or did they change how FirstOfGroup() works?

 

[claptomanic]

im not totally sure but i think FirstOfGroup() takes the unit matching the conditions and is the nearest (strange word^^) to the point they are set from (units in range for example)....if theres no point its the nearest of one of the corners (dont remember which one)....


could be totally wrong but i think it was something like that...

jassers help me

 

[Troll-Brain]

If you really want a random unit, use the BJ function (or an other custom one), or an other unit data structure.
Nobody knows how exactly a group is filled when a GroupEnum is called.
Now maybe when you add manually an unit with GroupAddUnit, the relative order is kept, but i'm not sure at all.

And yes FirstOfGroup should return always the same unit if you don't add/remove units between calls of this functions.

 

[Anachron]

Troll-Brain thanks for your answer.
I was talking about multiple test games of the same map and it kept selecting the same units as FirstOfGroup when I enum them on map.

Surprisingly the unit is NOT the closest to the location, but bottom right to the desired location.

 

[Troll-Brain]

Troll-Brain thanks for your answer.
I was talking about multiple test games of the same map and it kept selecting the same units as FirstOfGroup when I enum them on map.

Surprisingly the unit is NOT the closest to the location, but bottom right to the desired location.

Now try with different units rawcodes, or even different unit positions, i guess that the result shouldn't be always the same.
IIRC everybody failed to find something reliable, we just don't know how units are sorted in the group through a GroupEnum call.

 

[Adiktuz]

Surprisingly the unit is NOT the closest to the location, but bottom right to the desired location.

--> Of course its not the nearest one... Else there wouldn't be any need for the GetClosestUnit something snippet...

Maybe they are stored in the same priority as when you select a unit group manually?

 

[mckill2009]

if you really want random units in group, make a global integer, group them first
then take the MAX_INDEX unit count...
then use the normal FirstOfGroup itenerations and GetRandonInt(1,MAX_INDEX),
make a local integer index = index + 1
in the loop if the index matches the randomint exitwhen==true...

 

[Troll-Brain]

It would be much better to use an unit array instead of a second group.
Now, frankly the BJ count function or a custom one should be good enough in almost cases.
Even if yeah ForGroup is much more inefficient because it opens a new thread for each unit in the group.

But this solution is less verbose, especially if you need to keep the group.