[Solved] Help with Dirac's Damage Struct

[Mr_Bean]

Hi,

Status: SOLVED!

Can someone please help me to create and event for this system (http://www.thehelper.net/forums/showthread.php/168144-Damage-Struct). I would like to make a spell that deals AoE critical strike damage. All that I need to know is how to make an event that detects when a unit attacks normally.

Thanks!

 

[cohadar]

Advice: Don't make spells that need damage detection systems.
You can make cool stuff with simple triggers.

 

[dudeim]

Advice: Don't make spells that need damage detection systems.
You can make cool stuff with simple triggers.

Lol dude really you just want a high post count or what? He wants this so he's asking how it works.
Ontopic:
You might wanna send dirac a pm he might respond.

 

[cohadar]

I am not a dude, dude.

And I am serious about this.
Using complicated stuff in your map does not make your map any better.
I have seen countless maps that failed because they used complicated game mechanics that new players could not understand.

You are better off thinking about a good content for your map, than using a overly complicated triggering just so you can make 2 custom spells.

 

[dudeim]

This is not really complicated for people to understand and it might be fun, it's better to encourage people to do their own thing then just saying they should create super simple stuff.

 

[Laiev]

@Cohadar

Damage Detect System is not complicated things. Is something necessary for a map, like Index system.

@Mr_Bean987

Global damage detect (detect any damage dealt/take and execute the function 'func'):
- function RegisterGlobalDamage takes code func returns triggercondition

Using DamageId:
- function RegisterDamageById takes code func, integer damageId returns triggercondition

Uses:

call RegisterDamageById(function Callback, DAMAGE_ID_MELEE)
call RegisterDamageById(function Callback, DAMAGE_ID_RANGED)

 

[cohadar]

@Cohadar

Damage Detect System is not complicated things. Is something necessary for a map, like Index system.

I created damage detection system (ORBEngine)
And unit indexing system (PUI)
They are both used in ElementalTD for example.

So I know what I am talking about.

 

[Meticulous]

Using complicated stuff in your map does not make your map any better.
I have seen countless maps that failed because they used complicated game mechanics that new players could not understand.

AoE critical strike is complicated and hard for new players to understand...?

 

[Laiev]

@Cohadar

Detect damage and Index is not complicated things...

No matter what you did, they are necessary things for any map that use unit and damages (spells or attack, no matter).

Players will not know the existance of the Index, it really don't matter.

Also, detect when a damage happen is complicated why? It's so simple, unit deals damage -> run event. Done.

Nothing else needed.

Oh, and Elemental TD don't exist anymore on Warcraft (at least not updated), they moved to SC2 and PUI is hyper outdated >.>

 

[cohadar]

AoE critical strike is complicated and hard for new players to understand...?

No, but when new mappers get their hands on damage detection engine, they start imagining all kind of weird stuff.

Now lets take a moment from this off-topic discussion and return to the first post to see what this mapper really wants.

A spell that does something in AOE when a unit attacks?
Why you can do that by registering unit attack trigger, no need for damage detection at all.

Now you can say that it is not precise and whatnot but the truth is that in game no player will notice or care about the difference if this is done with simple attack event or with complicated damage detection system.

Hence my advice: Do not complicate it unless you have to.
It is really a good general purpose advice, I don't understand why you have a problem with it.

 

[Laiev]

On Attack will bug if spamming S, you should know that Cohadar.

 

[cohadar]

On Attack will bug if spamming S, you should know that Cohadar.

And you should know how to avoid that.

 

[Dirac]

And you should know how to avoid that.

With a damage engine right?
Plus with "attack detection" how would you know how much damage the unit deals with a basic attack? There are many factors that have a say on this such as

• Base damage
• Attributes
• Item/Abilties Bonuses
• Buffs
• Armor Reduction

Thinking that "not learning because it's too complicate" it's the dogma of the philosophy of ignorance.

 

[cohadar]

With a damage engine right?
...blah blah blah...
Thinking that "not learning because it's too complicate" it's the dogma of the philosophy of ignorance.

No, the old school way: with an orb ability and buff detection.
Which would be a real learning experience.

Just using some other peoples functions hardly qualifies as learning.
It is more in the RTFM category.

 

[dudeim]

No, the old school way: with an orb ability and buff detection.
Which would be a real learning experience.

Just using some other peoples functions hardly qualifies as learning.
It is more in the RTFM category.

That you use other people functions does not automaticly mean you're not learning, you're creating your own stuff with those function so you're still learning if you create new things (new for you).
Also I started with using other systems and when I got at a level capable of coding those things I coded my own system that does the same as the others, but now I wrote it myself so I learned something new.
Also why overcomplicate stuff with orbs when a damage detection system is 100000x easier.

 

[cohadar]

Bah, we can do this for days. I am off.

 

[Laiev]

On Attack is bad, this is fact.


Using the thing which you said, buff, will not work right, when you attack, the trigger fire, but the buff is applied before damage dealt.

On Attack - Apply Buff - On Damage.

Your 'method' will fail and just will work if unit attack again the target with buff and it can be bugged too by using the stop order.

There's nothing to discuss here, a Damage Detect System is always better then On Attack native event. This is a fact.

 

[PurgeandFire]

The easiest method to detect if it is not a spell is just to trigger everything. By that, I don't mean that you necessarily have to go and modify every bit, you just need to make it so that the damage event knows when a spell is cast.

Here is the setup:

globals
    boolean isMagic = false
endglobals

Then, on the triggers for registering spell damage, just use set isMagic = true before dealing damage. (or just place it in your trigger if you have the damage set in the object editor, but that may lead to some problems of instanceability)

Then, edit the damage detection system you use. After it has fired the triggers, just set isMagic = false. Then you are done. If you need to detect if some damage was not from a spell, then you just use if (not isMagic) and GetEventDamage() > 0 then and follow it up with your actions. It is not a generalized solution, but for most people's needs it will work perfectly fine with the least amount of annoying work. (unless you have like 500 spells)

Buffs work but Nestharus has already stated the problems with it in Advanced Damage System. For something like this, it is truly much easier just to trigger it yourself in accordance to your map. =)

EDIT: Also add what Dirac said in post #19. I forgot about recursion.

 

[Dirac]

What purge says is true.
Also, to make the magic detection even more accurate do this

local boolean prevType = isMagic
set isMagic=true
//do some damage
set isMagic = prevType

Reason: if damage is done when a damage event fires the isMagic boolean would remain true/false when not supposed to, that would prevent collision.

 

[cohadar]

@Laiev
Game known as :spit: dota :spit: uses onAttack + buff.
That is why orb attacks do not stack, check open-dota map if you don't believe me.
(You made me use proof-by-dota, I will hate you for ever)

The easiest method to detect if it is not a spell is just to trigger everything.

Yeah, just what a new mapper needs, advice how to spend 6 months on a map instead of 6 weeks.

I can't help but notice that thread creator has no entries in this discussion and that you are all doing thread hijacking just because you don't agree with my views.

My advice still stands MrBean: Keep it simple.
The only thing your map needs is to be fun, everything else is optional.

 

[Mr_Bean]

I can't help but notice that thread creator has no entries in this discussion

This is because I am don't know much about what you are talking about
I think I will "keep it simple" as you say, so thanks for the help anyway guys!

 

[Bribe]

The problem with an orb effect is that you can't use it with artillery, barrage or bouncing missiles. Nestharus developed Advanced Damage Event which uses Damage-detect + orb to detect physical, but all three of those bugs will occur which is why his is not as popular as other damage-modifier systems. Plus because it is a frost-orb buff that he uses (so it can stack with other orbs) it occasionally slows the unit for a moment.

 

[Mr_Bean]

Update:
I know it's been a long time, but I have decided to try to make another spell using the same system. I managed to get RegisterGlobalDamage and it works. However, RegisterDamageById does not. It saves, but when I test the map, no debug message shows like it did for RegisterGlobalDamage.

scope Test initializer InitTrigger

    private function Actions takes nothing returns nothing
        call BJDebugMsg("Damaged!")
    endfunction

    private function InitTrigger takes nothing returns nothing
        local trigger t = CreateTrigger()
        call RegisterDamageById(function Actions, DAMAGE_ID_MELEE)
        set t = null
    endfunction

endscope

 

[Dirac]

Make sure you properly installed all the DamageId components (the abilities it needs)
Make sure the damage is being done by the auto attack of a melee unit.
You don't have to create that trigger.

 

[Mr_Bean]

I didn't read the part that says you have to close and re-open the map and THEN delete the "!". Haha, thanks for your help man!

 

[Mr_Bean]

Update:
How do I detect the attacker?

 

[Dirac]

If you mean how do you know which is the unit dealing the damage there are many ways...
If you read the API you would find the "Damage.source" readonly unit variable, it keeps the value of the unit dealing the damage.
If you wish to register the damage dealt by one single unit then you can type RegisterUnitDamageDealtEvent(unit, code)
That way the code would ONLY fire for the registered unit.

 

[Mr_Bean]

Awesome, thanks dude!

 

[Berb]

@Laiev
Game known as :spit: dota :spit: uses onAttack + buff.
That is why orb attacks do not stack, check open-dota map if you don't believe me.
(You made me use proof-by-dota, I will hate you for ever)

Quote:
Originally Posted by PurgeandFire111 View Post
The easiest method to detect if it is not a spell is just to trigger everything.
Yeah, just what a new mapper needs, advice how to spend 6 months on a map instead of 6 weeks.

I can't help but notice that thread creator has no entries in this discussion and that you are all doing thread hijacking just because you don't agree with my views.

My advice still stands MrBean: Keep it simple.
The only thing your map needs is to be fun, everything else is optional.

If you need to bring DotA into the conversation that only means you are being stubborn. Instead of having a 50-post thread this could have been reduced into a 5-post thread.

I'm sure if Mr Bean987 wanted your personal advice he would ask for it, but he's here asking a specific question. The least you could do is give a specific answer.

Either that or you could go back to wc3c.net and preach there. Strange how that community died because of answers like yours, and now you're here using the same strategies. Good luck with that.

 

[Mr_Bean]

Anyway, back on topic: this thread is now

SOLVED!