[JASS] can anyone tell me y this doesnt work ?

[deathismyfriend]

hello im trying to get an items lumber cost and put it into an array it works w this code

function Trig_Untitled_Trigger_003_Actions takes nothing returns nothing
    call AddItemToStock( gg_unit_n01L_0127, itemIDS[33],1,1)
    call IssueNeutralImmediateOrderById( Player(0), gg_unit_n01L_0127, itemIDS[33])
    call RemoveItemFromStock( gg_unit_n01L_0127, itemIDS[33])
    call BJDebugMsg( "builds item")
endfunction

//===========================================================================
function InitTrig_Untitled_Trigger_003 takes nothing returns nothing
    set gg_trg_Untitled_Trigger_003 = CreateTrigger(  )
    call TriggerRegisterPlayerChatEvent( gg_trg_Untitled_Trigger_003, Player(0), "-builditem", false)
    call TriggerAddAction( gg_trg_Untitled_Trigger_003, function Trig_Untitled_Trigger_003_Actions )
endfunction

//works as expected just place in a loop

but when i call it in a trigger it doesnt work for player 11 ?

private function settingLumberCosts takes nothing returns nothing
    local integer Loop = 33
    local unit u = gg_unit_n01L_0127
    local integer maxLumber = 1000000 // 1 mil
    local integer itemLumber
    local unit Hero = gg_unit_Nalc_0128
    call SetUnitOwner( Hero, Player(11), true)
    loop
        exitwhen Loop > 39
        call SetPlayerState( Player(11), PLAYER_STATE_RESOURCE_LUMBER, maxLumber)
        call AddItemToStock( u, itemIDS[Loop], 1, 1)
        call IssueNeutralImmediateOrderById( Player(11), u, itemIDS[Loop])
        call RemoveItemFromStock( u, itemIDS[Loop])
        set itemLumber = GetPlayerState( Player(11), PLAYER_STATE_RESOURCE_LUMBER)
        set lumberCost[Loop] = maxLumber - itemLumber
        call RemoveItem( UnitItemInSlot( Hero, 0))
        call DisplayTextToForce( GetPlayersAll(), I2S(Loop) + " " + I2S(lumberCost[Loop]))
        set Loop = Loop + 1
    endloop
    call ShowUnit( u, false )
    call ShowUnit( Hero, false )
    set u = null
    set Hero = null
endfunction

 

[Maker]

You do know that Player(11) is Player 12, don't you?

 

[deathismyfriend]

yup i refer to all players as they r in jass player red is player 0 so on and so on

edit: found a solution if i put a wait in it it triggers and stores the lumber prices perfectly

 

[WaterKnight]

Make sure your shop has the ability Sell Items (Asid) but not Select Hero (Aneu) or similar. Else your buying unit will need to be selected first. However, you do not need a purchaser. This purchasing method will place the item next to the shop.

The stock modying natives are fairly bugged. This might not work for a large amount of item types because RemoveItemFromStock will leak slots now and then. I do not know the details at the moment. Of course you can recreate the shop.

 

[deathismyfriend]

found a solution if i put a wait in it it triggers and stores the lumber prices perfectly. it needs to be at least a 2 second wait which is odd lol. im guessing its the time for the shop to become available like when u move a hero near the unit u click the shop and it takes a second till it allows u to buy items

 

[WaterKnight]

Yes, because it will select the hero in the meantime. This is not needed though.

 

[deathismyfriend]

ooo is there a way to make the shop select the unit ?

 

[WaterKnight]

IssueNeutralTargetOrder(<ownerOfBuyer>, <shop>, "neutralinteract", <buyer>)

But this might not work as the ability is disabled while no unit is selected. As I have said, you do not need your hero at all. Get rid of the shop's Select ability, so it can sell items without a customer.

 

[deathismyfriend]

ill try the thing u posted then ill try the other option if tht doesnt work thx

edit: first option doesnt work

edit 2: second option worked thx now i just need to find a way to select the items to remove them. any ideas

 

[WaterKnight]

Such preloading is normally done before the game begins. Just pick your items via rect. If you need to be sensitive, you can also compare the items picked before and after the loop runs.

 

[deathismyfriend]

ya u mean create rect then use enumitemsinrect cand delete items in there right ?

 

[WaterKnight]

Yes. If you have other items that may be in the same rect at that moment, pick all items once before the sale, increase their custom value by 1, then after the sale pick the items again and look whether they have a custom value greater than 0, if yes, decrease it again, else destroy the item because it was new.

 

[deathismyfriend]

i think i got it working.

edit: works perfect thanks a lot