Moderator
M
Moderator
12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.
22:49, 12th Jan 2014
BPower:
Normally I don't intervene so quickly, but rather give the thread time to progess.
First and foremost use a different way of indexing, look into this thread it is very easy to understand Dynamic Indexing
Heay Slash
The spell concepts are very simple, hence I expect the code to be very good and clear, otherwise I won't approve it.
IcemanBo: Too long as NeedsFix. Rejected.
22:49, 12th Jan 2014
BPower:
Normally I don't intervene so quickly, but rather give the thread time to progess.
First and foremost use a different way of indexing, look into this thread it is very easy to understand Dynamic Indexing
Heay Slash
- Store picked unit into a variable
- The same unit can be hit multiple times, hence the damage is often a multiple of the original damage.
- The animation speed should be configurable
- The variable names should be HS_ and not S_
- Use TriggeringUnit and not CastingUnit
- You have a location leak
- Don't use an array for caster and damage if you don't need it inside the loop
The spell concepts are very simple, hence I expect the code to be very good and clear, otherwise I won't approve it.