about the index 8191 of an array and saved game

[Troll-Brain]

I'm just wondering if this also crash a saved game.

Just save your map with this script, start the map, save the game (the local variable will already be dead) and then try to load the saved game.

scope Test initializer init

    private function init takes nothing returns nothing
        local integer array tab
        set tab[8191] = 1
    endfunction

endscope

Anyone would like to test it ?

 

[chobibo]

Didn't crash.

EDIT: attached map+savefile (unzip)

 

[Troll-Brain]

Ok that makes sense.

And what about that one ?

scope Test initializer init

    private function init takes nothing returns nothing
        local unit array tab
        set tab[8191] = CreateUnit(Player(0),'hpea',0,0,0)
        // call RemoveUnit(tab[8191])
        // there will be a "leak", so maybe it could still crash
    endfunction

endscope

 

[chobibo]

Didn't crash;
Test A - create unit
Test B - create unit - remove unit

attached map + savedata (zipped again)

 

[Troll-Brain]

Thx for the tests.

Now, to keep on subject, let's create a vJass resource.

library SaveHandler initializer init

    globals
        private integer I = 0
    endglobals

    function HandleSaveForPlayer takes player which_player, boolean enable returns nothing
        if GetLocalPlayer() == whichPlayer then
            if enable then
                set I = 0
            else
                set I = 8191
            endif
        endif
    endfunction

    function HandleSave takes boolean enable returns nothing
        if enable then
            set I = 0
        else
            set I = 8191
        endif
    endfunction

    private function init takes nothing returns nothing
        local boolean array tab
        set tab[I] = true
        call TriggerSleepAction(0)
        call TriggerExecute(GetTriggeringTrigger()) // not sure about that one, don't remember how the init is generated in jass, maybe ExecuteFunc instead ?
    endfunction

endlibrary

Ofc, you can also create a trigger/trigger action inside the vJass initializer and then you will be able to use TriggerExecute, regardless how vJass initializers are created in jass.

 

[chobibo]

I don't know how to test that one? Do I run it on initialization? The trigger execute shouldn't be needed, I'm also rusty at vjass so I'm not really sure.

 

[Nestharus]

It'll run automatically, just cnp to a map

 

[chobibo]

I meant how to test the two functions above the init.

 

[Nestharus]

Oh, not sure what TriggerHappy is wanting there

change trigger execute to execute func

 

[chobibo]

Troll-Brain wants to test the 8191th index of a local array, he must be looking for a bug. I don't know how to test for the bug though.

 

[Nestharus]

I mean the two functions, but w/e..

 

[chobibo]

I know, I just told you what he's trying to do, you might know how lol.

 

[Malhorne]

What the goal of this x) ?

 

[chobibo]

Ask Troll-Brain. I just know he's looking for the 8191th index failure on local arrays.

 

[WaterKnight]

Try to save during a TriggerSleepAction, so the local variable won't be released yet.

 

[chobibo]

Oh I see...

EDIT: the map + screenshot

Image

Nothing new, since this was found out long ago. I wonder why he needed to test it though.

 

[Troll-Brain]

Nothing new indeed, i was not sure about the locals variables when they are "deleted", that's all.
I thought the point of the library was obvious, allow a player to save when you (the map maker) want it, you know checkpoints, that sort of stuff.

Example, you want to not allow the save for all players :

call HandleSave(false)

Now, you want them to allow save :

call HandleSave(true).

Ofc it will not be instant because of the TriggerSleepAction, but it's needed, because we need to use a local and not a global variable, else the save disabling would be permanent.

Or maybe if you give the "null" type of the index 8191 of a global array variable it won't crash on loading of a saved game ?

Now it's not something really useful, i just have fun

Also instead of HandleSave, EnableSave is probably a better name.

I know TriggerHappy's solution, and yes it's much more neat.
But i don't think it will work if you have already a dialog displayed, if it also work then yes this resource is 100 % useless.
Anyway as said i'm just playing there, nothing serious. I like to do stuff with jass bugs and understand how they work, as simple as that.
Especially now, as they are not going to be fixed, ever.

 

[TriggerHappy]

I know TriggerHappy's solution, and yes it's much more neat.
But i don't think it will work if you have already a dialog displayed, if it also work then yes this resource is 100 % useless.
Anyway as said i'm just playing there, nothing serious. I like to do stuff with jass bugs and understand how they work, as simple as that.
Especially now, as they are not going to be fixed, ever.

You can't use the in-game menu when a dialog is being displayed.

EDIT: Oh, if another player saves when you have a dialog open. Let me test.
EDIT 2: The script still works even if another player has a dialog already open.

 

[Troll-Brain]

Ok ok, then forget my library.
Back to your thread now

 

[chobibo]

Eh, never said it was useless, it could be an alternative, a very harsh one at that. TriggerHappy's solution works by not allowing you to save, your version allows one to save, but doesn't allow you to load the game you saved.

 

[Nestharus]

Eh, never said it was useless, it could be an alternative, a very harsh one at that. TriggerHappy's solution works by not allowing you to save, your version allows one to save, but doesn't allow you to load the game you saved.

haha, I'd totally do it this way ^)^

 

[Troll-Brain]

Well, i prefer a transparent way, like TriggerHappy's solution.
Plus, in a multiplayer game, saving can cause some lag.

But if it's somewhat useful, maybe TriggerHappy could include this in his library, vJass is enough powerfull to support both ways within the same library, and then let the map maker choice what he prefers.
Thx to "static if" and constant boolean/integer.

I don't think it worths a library alone, your thoughts about that guys ?