[JASS] Struct-related location question

[FlaminG-HunteR]

Say I have a struct similar to the following with some location members:

struct somestruct
    location l1
    location l2
    location l3
endstruct

...would destroying the struct and not using "call RemoveLocation(...)" clean the locations after being used?

Or would they still cause leaks and require the remove function?

 

[Earth-Fury]

destroying a struct destroys the struct, not any of its member variables.

structs can have an onDestroy method which will be called when a structs .destroy() method is called, but before the struct is actually destroyed.

eg:

struct somestruct
    location l1
    location l2
    location l3
    
    method onDestroy takes nothing returns nothing
        call RemoveLocation(this.l1)
        call RemoveLocation(this.l2)
        call RemoveLocation(this.l3)
    endmethod
endstruct

Also, don't use locations. For every function which uses a location, there is an equivalent (or pair of equivalent) functions which use real x / y coordinates. You don't have to create or destroy or null real-type values, so using coordinates is preferred for everything. (There are two functions that do not have x / y counterparts: GetSpellTargetLoc() and GetLocationZ(someLoc))

Use the function finder in NewGen's trigger editor. It can greatly help in quickly finding the functions you need. (Hold down CTRL and click a function name to bring up the function finder showing that functions definition.)

Edit: Forgot this.

 

[FlaminG-HunteR]

Thanks for the quick reply, I'm glad that's cleared-up.

 

[Captain Griffen]

GetLocationZ(someLoc) can be replaced with this:

function GetPointZ takes real x, real y returns real
    call MoveLocation(PermaLocation, x, y)
    return GetLocationZ(PermaLocation)
endfunction

And that is faster than creating and destroy a location each time.

 

[GhostWolf]

GetLocationZ(someLoc) can be replaced with this:

function GetPointZ takes real x, real y returns real
    call MoveLocation(PermaLocation, x, y)
    return GetLocationZ(PermaLocation)
endfunction

And that is faster than creating and destroy a location each time.

Hey that's nice. I never thought about it. lol.