Newbton Sorcerer Spells 1.0

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

Required changes

• Add importing instructions
• Abilities must support levels
• Null local unit variables in Wither Cast, now they leak

Suggested changes

• Make clear which triggers belong to the spellpack
• Instance counter integers can't be 0 if they are not subtracted from.
  Do "if integer == 0, turn off trigger" check only after you subtract from the integer,
  not during every loop
• No need to remove units from a group if you're going to destroy
  the group right away
• Don't load light and buff0 in Wither Effects during every loop, only
  when you need them
• Thunderbolt Cast, SaveRealBJ -> SaveReal(hash, parentKey, childKey, value)
• You could use GetSpellTargetX and ...Y instead of location in Thunderbolt Cast

 

[SpectreD]

Could u please post some triggers inside tags and ill test now

 

[Adiktuz]

actually I believe there are frozen orbs here which doesn't use shockwave... and the same request as above

 

[Tank-Commander]

It's actually fully possible to compact this entire pack into 3 triggers and use a single hashtable

There doesn't seem to be anything too special, every spell is pretty simple, but then again I guess that's something which packs tend to be like.

Oh you also have overlapping hotkeys.

I'd suggest making the tooltips more like the blizzard ones, look at how they're done and apply it to yours.

You need to create a configuration for all your spells.
You could store effect paths as variables as well and add them to the configuration

Also store everything required for your pack in the /same place/ so that you don't have to go importing from multiple folders to import, and remove anything not relevent to this particular pack.

I don't particularly like that every spell is ran from this "GUI spell event" trigger considering only those with JASS knowledge will really be able to follow it

Your variables should not have preset values in the variable editor, as when somebody imports the spells they will be reset to 0 and thus do absolutely nothing, this is why we have a configuration as well as for you know, configuring.