MUI Advanced Equipment System (+Save/Load +Event)

[The_Witcher]

Gah! Still having trouble! The love between me and technology is so one-sided.

So yeah the issue I'm having still is reloading the equipment code from the last map. I'm thinking it may have something to do with how I saved the game cache, here's what it looks like:

Saving Space

function SaveEquipment takes player p returns string
        local integer i = 0
        local string s = ""
        loop
            set i = i + 1
            if Equipment.Item[i].id != MAX_ITEMS then
                set s = s + I2S(Equipment.Item[i].id - 'I000')
            endif
            set s = s + "x"
            exitwhen i >= classes
        endloop
        return s
        call StoreString  (udg_RPGTest, "Stuff", "Gear", s)
        return s
    endfunction

Unless I'm mistaken, I believe the value "s" it's saving in the game cache is the same s value that is established just earlier in the code (the equipment loadcode). I only came up with the Stuff and Gear handles in order to save the string into the cache as I didn't know what else to use.

It seems to compile fine in JNGP and the map runs fine in game, the problem arises when I try to reload it in the next map.

And here's the trigger (custom script in GUI) I used in the next map to restore the equipment:

• Custom script: call LoadEquipment(player p, GetStoredString(udg_RPGTest, Stuff, Gear))

When I try to save this in JNGP I get syntax errors, and when I try to edit it I get more syntax and/or struct errors. I'm thinking the problem has something to do with the fact that the game when it reloads the map and runs this trigger it isn't sure what the "Stuff" and "Gear" values are and hence it will crash. Am I going about this the right way? The only thing I'm sure about is that I am doing something wrong lol.

Also@ Adkituz,

I remember you mentioned you were using this system for your own map. I was wondering if I could see what you used to get the save/load codes into a game cache and have it work between maps (I'm assuming that's what you meant earlier).

Thanks all.

Okay here is how to solve this
after a function returns a value it doesn't execute the rest of its code!
just before you store the string there is a return which has to be removed so the function looks like this:

function SaveEquipment takes player p returns string
        local integer i = 0
        local string s = ""
        loop
            set i = i + 1
            if Equipment.Item[i].id != MAX_ITEMS then
                set s = s + I2S(Equipment.Item[i].id - 'I000')
            endif
            set s = s + "x"
            exitwhen i >= classes
        endloop
        call StoreString  (udg_RPGTest, "Stuff", "Gear", s)
        return s
    endfunction

a far easier way, using the function i implemented and not your edited version, would be:

call StoreString (udg_RPGTest, "Stuff", "Gear", SaveEquipment( <yourplayerhere> ) )

call this in the trigger where you want to save the code and its done

the mistake when loading is that jass strings have to be in "
you used

• Custom script: call LoadEquipment(player p, GetStoredString(udg_RPGTest, Stuff, Gear))

but it has to be

• Custom script: call LoadEquipment(player p, GetStoredString(udg_RPGTest, "Stuff", "Gear"))

after you initialized your gamecache

I hope this helps

The_Witcher

 

[Magtheridon96]

        static method operator [] takes player p returns Equipment
            local integer id = GetPlayerId(p)
            if p==null or id > 11 then
                return 0
            endif
            return .all[id]
        endmethod

>

static method operator [] takes player p returns Equipment
    debug if p==null or GetPlayerId(p) > 11 then
        debug return -1
    debug endif
    return GetPlayerId(p) // why not set 'this' to the player id?
    // you can make your struct extend an array too (you don't need
    // allocate and deallocate methods since you can easily have 
    // each struct index set to the player id (We have one struct per 
    // player))
endmethod

There are lots of things that could be optimized.
The system is still pretty cool though.

 

[Sir_Render]

So I tried both of your suggestions, the load script still does not compile. I tried all sorts of variations on the load script, and it doesn't want to compile. Is it possible we are using different versions of JNGP? I'm using the 5d edition.

 

[Adiktuz]

So I tried both of your suggestions, the load script still does not compile. I tried all sorts of variations on the load script, and it doesn't want to compile. Is it possible we are using different versions of JNGP? I'm using the 5d edition.

Post your new load code? And update ur jass helper

 

[Sir_Render]

Tried looking for an updated Jasshelper. 0.9.1.2. is the most recent version correct? I got it from http://www.hiveworkshop.com/forums/warcraft-editing-tools-277/jasshelper-jass-newgen-pack-151844/

As for the load code:

• Actions
  • Set p = Player 1 (Red)
  • Custom script: call LoadEquipment(player p, GetStoredString(udg_RPGTest, "Stuff", "Gear"))

This trigger is enabled by a series of triggers preceding it which also load up other game cache data such as the hero and the inventory dummy and resource count. If you want I'll also post those.

Do I need to establish the "Stuff" and "Gear" handles of the string prior to my loading the loadcode? I only chose those two since those names didn't appear anywhere else in all the code so I could avoid any sort of confusion of the other functions.

 

[Adiktuz]

remove the word player... also since its a global variable, it should be udg_p when you use it in jass... but you can just use Player(0) which is player1 red

if you downloaded from there then your Jass helper should be 0.A.2.B which is the latest one...

 

[Sir_Render]

Yep, that was what was causing it to hang up. Works perfectly now. I feel like such a tool lol. Thanks so much for the help Adiktuz and Witcher!

 

[Nestharus]

Witcher, you do know that the save/load in this resource is garbage right? You should either remove the save/load or update it. Don't mislead people into using it ;o.

 

[The_Witcher]

Witcher, you do know that the save/load in this resource is garbage right? You should either remove the save/load or update it. Don't mislead people into using it ;o.

What makes a post a good post?
giving some helping advises and not only saying that somethings bad!

so tell me what you think is garbage? i agree that the code is easily modifyable but any advanced user could easily crypt the code.

 

[Nestharus]

I am saying that you're save/load is 100% bad. I'd have to list everything it does. You can not fix it, you have to completely delete it and start over. There is no one problem, the entire thing is quite literally garbage.


For one, using BigInt will cut code size by half. Encryption is weak, player unique codes? versioned codes??

Even your catalog is poor : |

>.>

I am also not going to go over how to completely write a good save/load system from scratch... there is a tutorial for that


Here is the #1 save/load so you can compare
http://www.hiveworkshop.com/forums/spells-569/save-load-snippets-v1-2-1-2-a-202714/?prev=u=Nestharus


Your code uses a very obsolete method for save/load, which is what makes it so bad.

It is outdated ; P


edit
A tutorial that works to good save/load

http://www.hiveworkshop.com/forums/jass-ai-scripts-tutorials-280/saving-loading-192851/#post1884704

I am also writing an interactive tutorial that goes over everything in the above tutorial, but in a way so that it is understandable by anyone ; P. Someone who is very poor with math etc has been testing that interactive tutorial as I've been writing it and he has so far understood every chapter =). The interactive tutorial is still not done though ; P.

The tutorial is mainly up there if peope are curious about how save/load works or perhaps want to work on new encryption schemes =).


I apologize if I am being a bit rough ; P

edit
What you can do is write a SaveInventory and LoadInventory function for your inventory system that works with the save/load system I linked to =). I wrote one for default inventories, so why not write one for yours ; P.

The one I wrote is the absolute best one out there, so you might as well use it for your 2 functions =). You can put a static if in there to see if w/e lib exists (NumberStack or Buffer, don't remember which one you need to check). If it exists, then you include the save and load functions : ).

 

[The_Witcher]

I am saying that you're save/load is 100% bad. I'd have to list everything it does. You can not fix it, you have to completely delete it and start over. There is no one problem, the entire thing is quite literally garbage.

Grab a coke and read the rest if you want

For one, using BigInt will cut code size by half. Encryption is weak, player unique codes? versioned codes??

Even your catalog is poor : |

>.>

I am also not going to go over how to completely write a good save/load system from scratch... there is a tutorial for that


Here is the #1 save/load so you can compare
http://www.hiveworkshop.com/forums/spells-569/save-load-snippets-v1-2-1-2-a-202714/?prev=u=Nestharus


Your code uses a very obsolete method for save/load, which is what makes it so bad.

It is outdated ; P


edit
A tutorial that works to good save/load

http://www.hiveworkshop.com/forums/jass-ai-scripts-tutorials-280/saving-loading-192851/#post1884704

I am also writing an interactive tutorial that goes over everything in the above tutorial, but in a way so that it is understandable by anyone ; P. Someone who is very poor with math etc has been testing that interactive tutorial as I've been writing it and he has so far understood every chapter =). The interactive tutorial is still not done though ; P.

The tutorial is mainly up there if peope are curious about how save/load works or perhaps want to work on new encryption schemes =).


I apologize if I am being a bit rough ; P

edit
What you can do is write a SaveInventory and LoadInventory function for your inventory system that works with the save/load system I linked to =). I wrote one for default inventories, so why not write one for yours ; P.

The one I wrote is the absolute best one out there, so you might as well use it for your 2 functions =). You can put a static if in there to see if w/e lib exists (NumberStack or Buffer, don't remember which one you need to check). If it exists, then you include the save and load functions : ).

Some people simply don't get it-.- gratulations for your save sys but thats simply not what i aimed at.
and something that works well and was requested by many many users simply can't be garbage
the implementation won't give users perfect load codes for a
multiplayer map! it is just one easy way to do so, for example to
store the systems data in a gamecache! if you are a map maker you
could take the code and split it up, mix it into other systems or even
write your own function...
thanks for your comment, i always appreciate helpful critism but this was just in the wrong direction...
and please stop advertising your system!

 

[Nestharus]

edit
Ok, rather than fight about this, run this map and do lessons 23-30 and 34-40 (34-40 cover conditional save/load, which can be used to save partial inventories). For partial inventories on your inventory system, you will need some advanced catalog design. The only tuts on that are in my save/load with snippets map right now ; |.
Interactive Save/Load Tutorial


That will fully tell you what I am talking about.


After you have done those lessons, then tell me what you are going to do. There is a resource out there called http://www.hiveworkshop.com/forums/jass-functions-413/system-bigint-188973/. My save/load stuff completely runs off of BigInt. BigInt just allows for really really big integers. I suggest you take a BigInt and put your data into that. Any good save/load resource should run off of BigInt ; |.


The NumberStack resource I wrote is just a wrapper for BigInt that stores values into single digits like the tutorial talks about.


The next thing you can do to improve your resource is very advanced catalog stuff, but that would require a lot of effort ; P.


If you insist on sticking with the strings even after seeing how terrible they are, then please delete the 2 functions as it would be better not to have them at all.

 

[Bribe]

Your "itemData" should instead just be one hashtable, and instead of parent key "1" use "this" as the parent key.

This should use a module initializer, as if you are doing things from structs or classes the library init will fail to initialize first.

Nestharus, if someone has a problem with his save/load system they can request to Witcher to make it better. I don't think it necessary that he needs to delete everything and start over when you are the only one making the request, you being someone who isn't coming here with interests to use his system but just to comment on it.

I do not like the idea of Witcher coupling bad save/load codes with his own inventory, however it is an advantage for users that he has it instead of not having it, and users can decide for themselves how sucky it is.

If this was *only* a save/load system then there would be lots of room for breaking down every little fault it has, but since it is more of an afterthought than a core system component I just don't see the point in attacking it.

 

[Adiktuz]

Off-Topic?

I agree with Bribe since its up to the users whether they use the SL code here or not since it is just a bonus optional stuff...

and for example on Sir_Render's case, it doesn't matter how long the code is I think since he saves it in a game cache rather than print it out... so in the end, it has no effect on the player since the player won't even see the code...

and if users want to have a good SL system, they can just get Nestharus' system... or they probably already have it so there's no point in The_Witcher duplicating a part of that into his system...

one thing I really like in this system (aside from the fact that its really easy to use), is that its also easy to modify.

 

[Magtheridon96]

I'd recommend making the save/load in a seperate trigger inside a module and implement the module optionally into your main struct.
This way, anyone who has problems with the save/load feature can modify it easily.

module SaveLoadPlugin
    function SaveInventory takes unit u returns BigInt

    endfunction

    function LoadInventory takes unit u, BigInt k returns nothing

    endfunction
endmodule

implement optional SaveLoadPlugin

What I would do as a user:
call SaveInventory to get a BigInt and push it to the NumberStack.
When loading, I'd pop the BigInt and call LoadInventory.
Pretty easy ;P

 

[Nestharus]

both functions should take a BigInt =P

 

[Anchorist]

Why the item functions have ID as integer? how do I get "I00E" item ID into this?..

How I can restrict something ?

 

[Adiktuz]

enclose it on ''

'I00E'

 

[Anchorist]

How i can create per item restriction? (at least level restriction)

 

[Viks Thuzard]

I'll give a 5/5 for this system. But I have 1 problem.

When I copy the triggers in my map, it shows many errors. I don't know VJass. It shows more than 6000 errors. I just copied the last 2 triggers.

 

[Adiktuz]

Are you sure ur using JNGP with the latest jass helper? and you only need the main trigger...

 

[gorillabull]

very creative inventory you are good at this

 

[CBX Entertainment]

I dont know if you still work on this, but I found a few bugs

Disabling items does not work in any way, All items i register with the system are automatically disabled

The Ability loop when adding and removing items stops at 19 abilities instead of 20, because you use >=

The documentation uses deprecated and removed function calls as examples and has some statements wrong like 50 abilities per item etc.

You should mention what kind of abilities do not need an icon so that you can add them to heroes without problems (e.g. you cant add trueshot auras, because they have an icon) in the documentation.

Oh and I couldn't find a quick way to remove the offhand and mainhand class without destroying the whole code. Some users don't need those classes and you should think about an alternative for those. And also some users might want to have 3 ring slots instead of only 1, so maybe improve this aswell

 

[Adiktuz]

For the last one, its pretty easy easy to do those if you know how the system works... I think the item classes here as the basic of what one would use, and its just up to the user if he wants to modify them...

for the trueshot, I think all auras behave like that so you can't really add auras without having to use the disabled spellbook method... maybe he can add a how to do that on the documentation...

 

[AntyVirus]

why it says in game that i can't equip that item????

 

[Adiktuz]

becoz you have set some kinda limit to the units that can equip the item? like level or whatever...

 

[AntyVirus]

becoz you have set some kinda limit to the units that can equip the item? like level or whatever...

so where do i know where to look at?

 

[Adiktuz]

the part where you initialize the items to use this system...

that is the trigger/code where you call these lines: RegisterItem or EquipmentItem.create

 

[AntyVirus]

the part where you initialize the items to use this system...

that is the trigger/code where you call these lines: RegisterItem or EquipmentItem.create

well i did that and still can't equip pretty weird...

 

[CBX Entertainment]

well i did that and still can't equip pretty weird...

Disabling items does not work in any way, All items registered with the system are automatically disabled.

Maybe that is your problem?

 

[AntyVirus]

Edit: i finally found what the problem is you can't use this system in a map if u have lot of items because there is a limitation of it so it sux , sry the system is very good and a very good ideea but only if you use it on a map with few items

 

[bigboss]

Hey guys Hey Witcher love ur system man 5/5
but i hav a little problem with the so called equipment transfer function where as the others said will transfer the current equipment of "u"(variable) to another version of the unit lets say a range version SO.....

My question is can anyone provide with an EXAMPLE not some explaination of this function where my hero will change to a range version of itself WHEN equiping lets say... a range weapon and if i unequip it my hero will revert to its melee form while retaining its equipments

TY in advance

 

[The_Witcher]

Huge update!
I recreated nearly the whole code

nothing was removed but a lot improved:
- fixed a bug at transfering equipments between units
- made the save/load codes optional plugins
- improved the event handling
- uses linkedList and RegisterPlayerUnitEvent now
- many more fixes

please keep up your helpful critism!
and thanks for making this system #1 in top 20

The_Witcher

 

[bigboss]

Nice useful updates keep it up man
and now its MUI!!!! could be useful for some peeps hir

 

[RiotApe]

thanks, exactly what i need.

 

[Nestharus]

Big question... how do you run activated item abilities? It doesn't seem possible when using this since clicking on the item unequips it ; ).

You could add activated abilities to the unit, so you'd get an ability if you equip an item ;o.

 

[Adiktuz]

If this works like how it does before, that is what would happen...

 

[The_Witcher]

Big question... how do you run activated item abilities? It doesn't seem possible when using this since clicking on the item unequips it ; ).

You could add activated abilities to the unit, so you'd get an ability if you equip an item ;o.

what do you mean with "activated item abilities"?

in general all you do is register the abilities to an item type and everytime you equip the item, the system runs through the list of abilities and adds them or removes them on unequip to/from the equipment's owner...

if it has no icon it simply doesn't show up (mostly item abilities) and if it has one (active/aura) you have to cast it or maybe add it via a disabled spellbook.

 

[Nestharus]

Yea, that's what I figured.

 

[BPower]

Using a heal potion, health stone, etc will unequip your weapon

 

[The_Witcher]

Using a heal potion, health stone, etc will unequip your weapon

Fixed, thanks for finding!

 

[blink]

Very cooooooooooooooooooooool!!!!!!!!!!!!!!!!!!!!!...........

 

[Teldrassil]

MUI now? friggin awesome, here I was just getting back into war3, might just break out my old Gladiators map again, thanks Witcher bro

 

[purparisien]

This system is awesome. However, I think I've found a limit on it. Actually, you can't further than IO1x in the rawcodes. In other worlds, you can use "only" 72 items. Maybe, I am wrong, but I think it's the limit.

 

[Adiktuz]

what happens? the system stops working for items that has rawcode of IO2x and above?

 

[CBX Entertainment]

This system is awesome. However, I think I've found a limit on it. Actually, you can't further than IO1x in the rawcodes. In other worlds, you can use "only" 72 items. Maybe, I am wrong, but I think it's the limit.

You must be mistaken. I am successfully using I05X rawcodes.

Which version (editor, game, etc) are you using?

 

[purparisien]

I'm using the lattest version of Wacraft III and the JNPG editor. I don't think I've made a mistake. However, it could be a problem with the version of the system.
I can show you the map :
http://www.hiveworkshop.com/forums/pastebin.php?id=06mlaa
Anyway, this system is still great

 

[ShroudX]

How can I fix this error?

Line 156 (found in Linked List): The only static operators supported so far are [] and [] = wait for another version.

 

[The_Witcher]

How can I fix this error?

Line 156 (found in Linked List): The only static operators supported so far are [] and [] = wait for another version.

The LinkedList Module works flawless! besides it's not even coded by me.
Please update your jasshelper to the newest version or even better, install cohadars mod!

 

[baassee]

shouldnt use cohadar jasshelper, breaks some stuff like timertools - ask nest for more info