how to make Unit doing nothing do something?

[Blackrockorc]

OK this the idea for the trigger i want

every 5 seconds
make units who arnt doing anything attack random unit from my temp group.

any1 know how to bring that trigger ti life Trigger wrap it plz

 

[Pharaoh_]

• Trigger
• Events
  • Time - Every 5.00 seconds of game-time
• Conditions
• Actions
  • Unit Group - Pick every unit in (Group) and do (Actions)
    • Loop - Actions
      • If (All conditions are true) then do (Actions) else do (Actions)
        • If - Conditions
          • (Current order of (Picked unit)) Equal to (order(<Empty String>))
        • Then - Actions
          • Unit - Order (Picked unit) to Attack (Random unit from (Temp_Group))
        • Else - Actions

The <Empty String>: When you have to type an order, delete the default "stop" order and press Enter; simply don't type anything.

 

[Kanadaj]

• If - Conditions
• (Current order of (Picked unit)) Equal to (order(<Empty String>))
• (Current order of (Picked unit)) Equal to (order(Stop))

I'd rather use this If code-cos' if the unit finishes the attack, it'll get the order stop I think

 

[Blackrockorc]

• Orc Attack
  • Events
    • Time - Every 5.00 seconds of game time
  • Conditions
  • Actions
    • Set DoingNothingGroup = (Units in (Playable map area) matching (((Owner of (Matching unit)) Equal to Player 11 (Dark Green)) or ((Owner of (Matching unit)) Equal to Player 12 (Brown))))
    • Set TempGroup2 = (Units in (Playable map area) matching (((Matching unit) belongs to an enemy of Player 12 (Brown)) Equal to True))
    • Set Unitposition = (Position of (Random unit from TempGroup2))
    • Unit Group - Pick every unit in DoingNothingGroup and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Current order of (Picked unit)) Equal to (Order(<Empty String>))
          • Then - Actions
            • Unit - Order (Picked unit) to Attack-Move To Unitposition
          • Else - Actions
    • Custom script: call DestroyGroup(udg_DoingNothingGroup)
    • Custom script: call DestroyGroup(udg_TempGroup2)
    • Custom script: call RemoveLocation(udg_Unitposition)

is it leak free now?

 

[Pharaoh_]

Yes, it is.

 

[Kanadaj]

I don't know, maybe you should use "bj_..." (as I know, but I'm not so good with Jass) but it's OK for now. If you want all the units attack the same target, it's OK, but if not, put Set Unitposition after the Then command. And put the condition I wrote above to the If Part

 

[tml616]

I don't think it's leak free; you should set tempunit = random unit from group and then clear it. Random unit from group leaks.

 

[PurgeandFire]

I don't know, maybe you should use "bj_..." (as I know, but I'm not so good with Jass) but it's OK for now. If you want all the units attack the same target, it's OK, but if not, put Set Unitposition after the Then command. And put the condition I wrote above to the If Part

People say to use set bj_wantDestroyGroup = true but it actually makes no difference. You can either use a global group and use the "call DestroyGroup(udg_MyGroupVariable)" or you can use the bj_wantDestroy. Most people in GUI use bj_wantDestroy though because it saves you from creating one extra global variable, but speed-wise they are the same. =D

I don't think it's leak free; you should set tempunit = random unit from group and then clear it. Random unit from group leaks.

Random unit from group doesn't leak, no need to worry about it. =) It uses the group you currently input, and aside from that it doesn't use any handles except for the unit it returns (which doesn't necessarily leak).