[JASS] Custom Stun: what did I do wrong?

[LexX]

I've read that custom stun (stunning any unit by triggers anywhere for any duration) can be made by adding remade "Aerial Shackles" ability (removed animations,added animation of stun,infinite duration) to a dummy and adding expiration timer to it,then ordering to use it to unit which should be stunned.
I tried to do such system,but it doesn't work,I think because I missed something in the system,but cannot find what...

System

function StunUnit takes unit target, real duration returns nothing
local unit T = target
local unit D
local location L = GetUnitLoc(T)
local real R = duration
  if ( IsUnitIdType(GetUnitTypeId(T), UNIT_TYPE_MAGIC_IMMUNE) == false ) then
     set D = CreateUnitAtLoc(Player(PLAYER_NEUTRAL_AGGRESSIVE), 'e00A' , L, bj_UNIT_FACING )
     call UnitAddAbility(D,'A019')
     call IssueTargetOrder(D, "magicleash",T)
     call UnitApplyTimedLife(D,'BTLF',R)
  else
  endif
set D = null
set T = null
call RemoveLocation(L)
set L = null
endfunction

"e00A" is dummy id, 'A019' is id of ability, "magicleash" - order

 

[TriggerHappy]

Try making the dummy ability firebolt. Just remove the damage and such.

 

[LexX]

Try making the dummy ability firebolt. Just remove the damage and such.

Well,it will have FIXED duration,as you know,and I need a system with ANY duration which will be set different for each ability.

 

[TriggerHappy]

You can remove the duration, I believe.

Anyways, here is one premade.

 

[LexX]

You can remove the duration, I believe.

Anyways, here is one premade.

Thanks,but need smth. another=)

 

[axleion]

about your script,
it might be because the dummy is owned by Neutral Hostile...
maybe you should add a player parameter?
and i think you don't need to declare "target" with new variable...

 

[Mooglefrooglian]

Neutrals dont respond to orders very well at all. Use NEUTRAL_PASSIVE, as agressive tends to do its own thing. I've had the problem enough.

Otherwise, looks fairly good. Remove the location though. X and Y are much better.

 

[LexX]

about your script,
it might be because the dummy is owned by Neutral Hostile...
maybe you should add a player parameter?
and i think you don't need to declare "target" with new variable...

It's local,not variable.Made it for better look of the system.

Neutrals dont respond to orders very well at all. Use NEUTRAL_PASSIVE, as agressive tends to do its own thing. I've had the problem enough.

Otherwise, looks fairly good. Remove the location though. X and Y are much better.

I'll check it now and see if this helps.

{EDIT}
It didn't fix the problem...

 

[TriggerHappy]

It's local,not variable.Made it for better look of the system.

Locals are variables.

Here is a better version of you script.. (still not efficient).

function StunUnit takes unit target, real duration returns nothing
local unit D
  if ( IsUnitIdType(GetUnitTypeId(target), UNIT_TYPE_MAGIC_IMMUNE) == false ) then
     set D = CreateUnit(Player(PLAYER_NEUTRAL_AGGRESSIVE), 'e00A' , GetUnitX(target), GetUnitY(target) bj_UNIT_FACING )
     call UnitAddAbility(D,'A019')
     call IssueTargetOrder(D, "magicleash", target)
     call UnitApplyTimedLife(D,'BTLF',duration)
  endif
set D = null
endfunction

 

[LexX]

Quote

Locals are variables.

Here is a better version of you script.. (still not efficient).

function StunUnit takes unit target, real duration returns nothing
local unit D
  if ( IsUnitIdType(GetUnitTypeId(target), UNIT_TYPE_MAGIC_IMMUNE) == false ) then
     set D = CreateUnit(Player(PLAYER_NEUTRAL_AGGRESSIVE), 'e00A' , GetUnitX(target), GetUnitY(target) bj_UNIT_FACING )
     call UnitAddAbility(D,'A019')
     call IssueTargetOrder(D, "magicleash", target)
     call UnitApplyTimedLife(D,'BTLF',duration)
  endif
set D = null
endfunction

Strings are too long to read,that's why I made local unit

{EDIT}
Dummies don't even appear....

{EDIT 2}
Everything worked when I used Player(0) as owner of the dummy=)Anyway it's dummy and it doesn't damage,so I think Player(0) can be used=)
Final version of the system:

function StunUnit takes unit target, real duration returns nothing
local unit T = target
local unit D = CreateUnit(Player(0), 'e00A' , GetUnitX(T), GetUnitY(T), bj_UNIT_FACING )
local real R = duration
  call UnitApplyTimedLife(D,'BTLF',R)
    if ( IsUnitIdType(GetUnitTypeId(T), UNIT_TYPE_MAGIC_IMMUNE) == false ) then
       call UnitAddAbility(D,'A019')
       call IssueTargetOrder(D, "magicleash", T)
    endif
set D = null
set T = null
endfunction

 

[Adiktuz]

Strings are too long to read,that's why I made local unit

{EDIT}
Dummies don't even appear....

{EDIT 2}
Everything worked when I used Player(0) as owner of the dummy=)Anyway it's dummy and it doesn't damage,so I think Player(0) can be used=)
Final version of the system:

function StunUnit takes unit target, real duration returns nothing
local unit T = target
local unit D = CreateUnit(Player(0), 'e00A' , GetUnitX(T), GetUnitY(T), bj_UNIT_FACING )
local real R = duration
  call UnitApplyTimedLife(D,'BTLF',R)
    if ( IsUnitIdType(GetUnitTypeId(T), UNIT_TYPE_MAGIC_IMMUNE) == false ) then
       call UnitAddAbility(D,'A019')
       call IssueTargetOrder(D, "magicleash", T)
    endif
set D = null
set T = null
endfunction

Player 0 is the default red player... btw.. cant you just use IsUnitType instead of IsUnitIDType?

and on your first trigger ins't the x in Player(x) needs to be an integer and you used
Player(PLAYER_NEUTRAL_AGGRESSIVE) maybe that's what caused the error...

 

[LexX]

Player 0 is the default red player... btw.. cant you just use IsUnitType instead of IsUnitIDType?

and on your first trigger ins't the x in Player(x) needs to be an integer and you used
Player(PLAYER_NEUTRAL_AGGRESSIVE) maybe that's what caused the error...

I know that Player 0 is red player,I even explained why I used this player=)
Will see about IsUnitType.
And PLAYER_NEUTRAL_AGGRESSIVE is an integer=)

 

[Adiktuz]

I know that Player 0 is red player,I even explained why I used this player=)
Will see about IsUnitType.
And PLAYER_NEUTRAL_AGGRESSIVE is an integer=)

yeah, TriggerHappy187 already told me...

 

[Ciebron]

function StunUnit takes unit target, real duration returns nothing
local unit T = target //This made me LOL!
//Why create the unit before the 'IF'?
local unit D = CreateUnit(Player(0), 'e00A' , GetUnitX(T), GetUnitY(T), bj_UNIT_FACING ) 
local real R = duration //this  also made me lol
  call UnitApplyTimedLife(D,'BTLF',R)
    if ( IsUnitIdType(GetUnitTypeId(T), UNIT_TYPE_MAGIC_IMMUNE) == false ) then
       call UnitAddAbility(D,'A019')
       call IssueTargetOrder(D, "magicleash", T)
    endif
set D = null
set T = null
endfunction

You know 'takes' is local's. so triggerhappys code are more effecient then yours

You know 'takes' is local's. so triggerhappys code are more effecient then yours

 

[LexX]

You know 'takes' is local's. so triggerhappys code are more effecient then yours

You know 'takes' is local's. so triggerhappys code are more effecient then yours

You may lol as much as you want.
I made the system much easier to read,so it's my business if I want it or not.



Thread is closed,problem is solved.

 

[Vulcano]

function StunUnit takes unit T, real R returns nothing
    local unit D
    if IsUnitIdType(GetUnitTypeId(T), UNIT_TYPE_MAGIC_IMMUNE) == false then
        set D = CreateUnit(Player(0), 'e00A' , GetUnitX(T), GetUnitY(T), bj_UNIT_FACING )
        call UnitApplyTimedLife(D,'BTLF',R)
        call UnitAddAbility(D,'A019')
        call IssueTargetOrder(D, "magicleash", T)
    endif
    set D = null
endfunction

why should you define more variables than necessary? I think passed variables are as fast as locals or faster.

 

[LexX]

function StunUnit takes unit T, real R returns nothing
    local unit D
    if IsUnitIdType(GetUnitTypeId(T), UNIT_TYPE_MAGIC_IMMUNE) == false then
        set D = CreateUnit(Player(0), 'e00A' , GetUnitX(T), GetUnitY(T), bj_UNIT_FACING )
        call UnitApplyTimedLife(D,'BTLF',R)
        call UnitAddAbility(D,'A019')
        call IssueTargetOrder(D, "magicleash", T)
    endif
    set D = null
endfunction

why should you define more variables than necessary? I think passed variables are as fast as locals or faster.

Well,you are right)