[Solved] How to Group unit without uses boolenexplr

[ALTELMA]

Example for me plz

 

[Starquizer]

Use FirstOfGroup.

<<< EDIT >>>
here is an example

globals
    group g = CreateGroup()
endglobals

// ===========================================================

function MatchingUnit takes unit u returns boolean
    return u == UNIT_TYPE_HERO // this is just an example you will have to set your own filter
endfunction

function example takes real x, real y, real radius returns nothing
    local unit u
    call GroupEnumUnitsInRange(g,x,y,radius,null)
    loop
        set u = FirstOfGroup(g)
        exitwhen u == null
        if MatchingUnit(u) then @/*EDIT:you could also apply the filter here and no need for another function call*/@
            // Do stuff here
        endif
        call GroupRemoveUnit(g,u)
    endloop
endfunction

 

[ALTELMA]

OK Thanks you a lot. I'll try it.

 

[Starquizer]

No problem, if you have any question just ask.

 

[ALTELMA]

OK thanks you, I have question about Event Every times X second. Can I use other function instead. Because I use this event for many trigger. I worry its slow my map and causes many leak. How can I fix that problem?

Sorry for my language.

 

[mckill2009]

if the loop is instant, bj_lastCreatedGroup is fine than creating a group...

about X seconds, you could use timers instead then pause the timer if you dont use the function...

 

[Starquizer]

if the loop is instant, bj_lastCreatedGroup is fine than creating a group....

I know about bj_lastCreatedGroup but I assumed the loop is not instant when I wrote this example.

 

[ALTELMA]

I have a question. If I use many if/else (About 20 - 30) on one function. It's cause my map is slow down.

 

[Spartipilo]

Mmmm depends. There are ways to avoid having to create long if/else chains, but it's "doable" if isn't a very used action.

 

[ALTELMA]

Should I use many trigger instead? It's best way to create recipe item. If It's true,I will came back to use old trigger item.

 

[Spartipilo]

No. There are systems here in hive for recipe Items. The way it works is with loops and pre-saved data. It's something like having a list of 100 values, and you tell the system "Find value 5 in the list of 100 values"... sort of.

 

[ALTELMA]

I ever seen it, but It's loop over 100 time to find any target item, but Why do I think that don't work?
That system you mention is Recipe Systems

 

[PurplePoot]

if the loop is instant, bj_lastCreatedGroup is fine than creating a group...

about X seconds, you could use timers instead then pause the timer if you dont use the function...

Optimization is great and all, but sometimes just write clean code...

Also he'd presumably not be using a global at all if it were anything but instant.

(Oh, and to the OP, the method a few posts up is really bad [not that I can blame him, he gave you what you asked for]... just use a boolexpr, there's really no reason not to)

 

[ALTELMA]

Thanks All guys, Now I understand about topic "how to create group without boolexpr".

 

[Troll-Brain]

... just use a boolexpr, there's really no reason not to)

I disagree, there are reasons to avoid it.
First, it's much faster because each time the boolexpr is evaluated a new thread is created, while it's not with a null filter, but yeah 99 % of times it doesn't matter at all.

It doesn't split the code, then you can use your locals without temp globals.
I agree that the loop is verbose, but still less than writing a boolexpr, and with Cohadar's jasshelper this loop is just like that :

for <unit> in <group>
// filter and do stuff with <unit>
endfor

 

[Spartipilo]

You also have

http://www.hiveworkshop.com/forums/...a-210505/?prev=search=Recipe&d=list&r=20&t=65

http://www.hiveworkshop.com/forums/...s-103353/?prev=search=Recipe&d=list&r=20&t=65

And, of course, you also have the way of learning and building your own

 

[ALTELMA]

Troll-Brain example for me plz.

 

[Spartipilo]

I think that, what Troll-Brain means is that the "Matching" part isn't really needed outside the GroupEnum to work with the units. You can filter the units inside the group as someone said before in this same thread.

    call GroupEnumUnitsInRange(g,x,y,radius,null)
    loop
        set u = FirstOfGroup(g)
        exitwhen u == null
        if (First comparison) and (Second comparison) and (Third comparison), etc. then
            // Do stuff here
        endif
        call GroupRemoveUnit(g,u)
    endloop
endfunction

 

[ALTELMA]

OK thanks a lot

 

[ALTELMA]

Err I wonder Value X and Y on function GroupEnumUnitsInRange Tell me more about agrument of that function.

function Trig_CountUnitGroup_Actions takes nothing returns nothing
    
    local unit u
    local group g =CreateGroup()
    local integer unitCount
    
    call GroupEnumUnitsInRange(g, 0, 0, 1000000000, null)
    
    loop
        set u = FirstOfGroup(g)
        exitwhen u == null
            if(GetUnitTypeId(u) == 'hf00')then
                set unitCount =unitCount + 1
                call BJDebugMsg(I2S(unitCount))
            endif
            call GroupRemoveUnit(g,u)
    endloop
endfunction

//===========================================================================
function InitTrig_CountUnitGroup takes nothing returns nothing
    set gg_trg_CountUnitGroup = CreateTrigger()
    call TriggerRegisterPlayerChatEvent(gg_trg_CountUnitGroup, Player(0), "-uc", true)
    call TriggerAddAction( gg_trg_CountUnitGroup, function Trig_CountUnitGroup_Actions )
endfunction

 

[Starquizer]

GroupEnumUnitsInRange(g,x,y,r,filter)

g: group, it is the group that the picked unit will be added to.
x: real, the X coordinate of the centre point of the picking circle.
y: real, the Y coordinate of the centre point of the picking circle.
r: real, is the radius the circle that the function will pick units from.
filter: boolexpr, if you want the unit to has special condition, but we regularly avoid this to prevent creation of another thread so we use FirstOfGroup and match the unit one by one.

 

[Troll-Brain]

With Cohadar's jasshelper :

Instead of :

    call GroupEnumUnitsInRange(g, 0, 0, 1000000000, null)
    
    loop
        set u = FirstOfGroup(g)
        exitwhen u == null
            if(GetUnitTypeId(u) == 'hf00')then
                set unitCount =unitCount + 1
                call BJDebugMsg(I2S(unitCount))
            endif
            call GroupRemoveUnit(g,u)
    endloop

->

    call GroupEnumUnitsInRange(g, 0, 0, 1000000000, null)
    
    for u in g

        if(GetUnitTypeId(u) == 'hf00')then
            set unitCount =unitCount + 1
            call BJDebugMsg(I2S(unitCount))
        endif

    endfor

When the vJass code will be converted to jass code the result will be exactly the same, but it is simply less verbose and error prone.

 

[ALTELMA]

If I don't want use vJass, but I want use basic jass my Code is OK?

 

[Spartipilo]

Yes it's

 

[ALTELMA]

Yes it's

Ahh I'try use that code to count unit on group, but It's doesn't work, why and How I can do fixed it.

function Trig_CountUnitGroup_Actions takes nothing returns nothing
    
    local unit u
    local group g =CreateGroup()
    local integer unitCount
    local integer i
    
    call GroupEnumUnitsInRange(g, 0, 0, 1000000000, null)
    
    loop
        set u = FirstOfGroup(g)
        exitwhen u == null
        set i = i + 1
            if(GetUnitTypeId(u) == 'hf00')then
                set unitCount =unitCount + 1
                call BJDebugMsg("COUNT IS : "+I2S(unitCount))
            else
                call BJDebugMsg("LOOP :"+I2S(i))
            endif
            call GroupRemoveUnit(g,u)
    endloop
endfunction

//===========================================================================
function InitTrig_CountUnitGroup takes nothing returns nothing
    set gg_trg_CountUnitGroup = CreateTrigger()
    call TriggerRegisterPlayerChatEvent(gg_trg_CountUnitGroup, Player(0), "-uc", true)
    call TriggerAddAction( gg_trg_CountUnitGroup, function Trig_CountUnitGroup_Actions )
endfunction

Tell me plz!!

 

[Spartipilo]

Are the 'hf00' units in the map? else it wont do anything.

Also, you have to destroy g and null u.

 

[ALTELMA]

function Trig_CountUnitGroup_Actions takes nothing returns nothing
    
    local unit u
    local group g =CreateGroup()
    local integer unitCount
    local integer i
    
    call GroupEnumUnitsInRange(g, 0, 0, 1000000000, null)
    
    loop
        set u = FirstOfGroup(g)
        exitwhen u == null
        set i = i + 1
            if(GetUnitTypeId(u) == 'hf00')then
                set unitCount =unitCount + 1
                call BJDebugMsg("COUNT IS : "+I2S(unitCount))
            endif
            call GroupRemoveUnit(g,u)
    endloop
    
    call DestroyGroup(g)
    set g -= null
endfunction

//===========================================================================
function InitTrig_CountUnitGroup takes nothing returns nothing
    set gg_trg_CountUnitGroup = CreateTrigger()
    call TriggerRegisterPlayerChatEvent(gg_trg_CountUnitGroup, Player(0), "-uc", true)
    call TriggerAddAction( gg_trg_CountUnitGroup, function Trig_CountUnitGroup_Actions )
endfunction

I don't know why don't display text in loop or loop is infinite?

Are the 'hf00' units in the map?

'hfoo' is footman they have really.

 

[Spartipilo]

'hf00' is nothing.
'hfoo' is footman.

Also (I just noticed this) If the local integer variable has no value it will mess the whole thing. It's probably doing the Enum but not displaying any message, since the message to display contains "null", which I tough should be naturally 0 but now noticed that isnt.

    local unit u
    local group g =CreateGroup()
    local integer i = 0
    
    call GroupEnumUnitsInRange(g, 0, 0, 1000000000, null)
    
    loop
        set u = FirstOfGroup(g)
        exitwhen u == null
            set i = i + 1
            if(GetUnitTypeId(u) == 'hfoo')then
                set i = i + 1
                call BJDebugMsg("COUNT IS : " + I2S(i))
            endif
        call GroupRemoveUnit(g,u)
    endloop
    
    call DestroyGroup(g)

 

[ALTELMA]

OK I get it all,Thanks a lot...