[JASS] learning vjass problem...

[SlayerII]

i begunn learning vjass some time ago and i just dont get this running proerply...

struct UnitExplode
real d
real r
real x
real y
unit u
unit u2 //killing unit
method UnitDead takes nothing returns nothing
    local group g
    set .x=GetUnitX(.u)
    set .y=GetUnitY(.u)
    call GroupEnumUnitsInRange(g,.x,.y,.r,null)
    loop 
    set .u = FirstOfGroup(g)
        exitwhen .u == null
        call UnitDamageTarget(.u2,.u,.d,true,false,ATTACK_TYPE_NORMAL, DAMAGE_TYPE_NORMAL, WEAPON_TYPE_WHOKNOWS)
    endloop
    call DestroyGroup(g)
endmethod
endstruct

function Explode takes nothing returns nothing
    local unit u= GetTriggerUnit()
    local unit u2= GetKillingUnit()
    local UnitExplode ue = UnitExplode.create() 
    set ue.u=u
    set ue.u2=u2
    set ue.r=300
    set ue.d=500
    call ue.UnitDead()
    call ue.destroy()
endfunction

//===========================================================================
function InitTrig_Explodespell takes nothing returns nothing
    local integer index
    set gg_trg_Explodespell = CreateTrigger(  )
    set index = 0
    loop
        call TriggerRegisterPlayerUnitEvent(gg_trg_Explodespell, Player(index),  EVENT_PLAYER_UNIT_DEATH, null)
        set index = index + 1
        exitwhen index == bj_MAX_PLAYER_SLOTS
    endloop
    call TriggerAddAction( gg_trg_Explodespell, function Explode)
endfunction

This i made just learning and it should damage all nearby unit nearby a diyng unit...

 

[Marcelo Hossomi]

You forget to remove the unit 'u' from the group 'g' (causing an inifite loop), in the loop inside your struct.

 

[YourNameHere]

You forget to remove the unit 'u' from the group 'g' (causing an inifite loop), in the loop inside your struct.

Beside that, you should start using better variable names. Your code is hard to understand with 1-letter things. (Alough it's not that hard with this short code, but the longer it gets the more unreadable it will get)

 

[M0RT]

Is there a reason to use struct? It seems to me that you create struct, call it's function and then destroy it instantly, you could just put that loop into the explode function...

 

[SlayerII]

... i should stop mapping so late at night
Thanks guys
The code is such small that there wasnt a need of better names.. and im not very creative in finding names

The reason wy i made this struct is to learn the OOP Syntax and to have something where i can give the game a radius and a damage to damage units in an area-thats all

edit:still not working....

 

[Marcelo Hossomi]

You forgot to initialize the group with g = CreateGroup() (do it along with its declaration)

 

[SlayerII]

NOW ot works ,thanks