Leaks

[chanan12]

I want a quick fix to some things that leak, i was wondering if i change everything to have variables, will it make it leak less? i wish i could post my trigger but i dont know how so i will describe it.

E:A unit is selected
?Unit equal to (unit))
Alay sound (sound) from (unit) for triggering player

if i use variables dose it make it not leak?

 

[Etzer]

Just use "destroy last created sound" or remove or something.

 

[chanan12]

Ty, and what about regions? do you know of any leaks with those?

 

[Etzer]

Regions does not leak.

 

[PurgeandFire]

Regions/rects are only considered "leaks" when you don't use them anymore. (just like most other handles) Example:

If you were to make a region each time you cast a spell, without removing it, it will leak.

But if you were to make a region for spawning and use it several times in your map, it isn't really considered a leak.

When you create one, it takes up memory. However, if you still need it, it is fine to keep it in memory, because you still need to reference/have access to it. If you don't need it, you should remove it to make sure it doesn't keep its place in memory.

EDIT: For the first post, you don't need to destroy the sound if that trigger is going to be run several times throughout the game. Destroying the sound will make it so that it won't be able to be played again, unless you recreate it. Thus, you can pretty much leave it as it is. =)

 

[chanan12]

So i use most of my regions for Quests, should i delete them?

 

[Bribe]

Consider this to your trigger if you only use a "region" once:

• Region Test
  • Events
    • Unit - Unit Enters (this is my region)
  • Conditions
  • Actions
    • Custom script: call RemoveRect ( gg_rct_this_is_my_region )
    • Custom script: call RemoveRegion ( GetTriggeringRegion() )
    • -------- Do your normal actions --------

 

[PurgeandFire]

So i use most of my regions for Quests, should i delete them?

Once everyone finishes the quest (as long as you don't need the region for later), then you can remove it.

 

[chanan12]

What about the action Wait, because i would like a couple seconds of wait time between the quest announcements.

 

[Bribe]

GetTriggering$Anything$() calls will not usually work after a wait, so forget that idea.

 

[chanan12]

Is there another way to make it wait some time?

 

[Bribe]

local unit u = GetTriggerUnit()
local player p = GetOwningPlayer(u)

call RemoveRect(gg_rct_this_is_my_region)
call RemoveRegion(GetTriggeringRegion())

call TriggerSleepAction( 3.00 )

call DisplayTextToPlayer( p , 0.00 , 0.00 , GetUnitName( u ))

set u = null

TriggerSleepAction has a crappy "kind of" alternative: PolledWait. Polled wait will not be called until after the TriggerSleepAction time has expired, but you are still at the mercy of whatever random-ass time the wait gives you after that mark.

 

[chanan12]

Hm, many thanks, i dont think i will make it wait.

 

[Bribe]

If you want to wait for just an approximate period of time, TriggerSleepAction is fine. Since you said "2 or 3 seconds" for the wait, you seem have no use for exact time.

 

[PurgeandFire]

GetTriggering$Anything$() calls will not usually work after a wait, so forget that idea.

How so?

 

[Bribe]

When I was guiding some guy named "muffinpancakes" pointers on an MUI trigger system, his "GetTriggerUnit()" calls were not working after a certain wait period. When I had him use "local unit u = GetTriggerUnit()" that fixed the problem. Though I haven't tested this myself, but I imagine with the failure that is GUI anything is possible.