Kill random peon when start constructing buildings

Diegoit · Apr 12, 2018

Current trigger, its bugged and i dont know why

Kill slave
- Events
  - Units - A unit Starts a building
- Conditions
- Actions
  - Set xFastG = (Units of type Soul slave)
  - Unit group - Pick every unit in xFastG and do (Actions)
    - Bucle: Acciones
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If: Conditions
        
        (Owner of (Triggering unit)) No equal to (Owner of (Picked unit))
        
        Then: Actions
        
        Unit group - Remove (Picked unit) from xFastG
        
        Others: Actions
  - Unit group - Pick every unit in (Random 1 units from xFastG) and do (Actions)
    - Bucle: Actions
      - Unit - Create 1 Dummy Killslave for Neutral passive at (Position of (Triggering unit)) facing Standard
      - Unit - Add a 5.00 second Generic expiration timer to (Last created unit)
      - Unit - Add Kill slave to (Last created unit)
      - Unit - Order (Last created unit) to Orc - Lightning chain (Picked unit)
  - Custom script: call DestroyGroup(udg_xFastG)

I did translate this

This is what i want: Start a building -> Kill random peon -> With X spell

Please n Thanks

Dr Super Good · Apr 12, 2018

Diegoit said:
Current trigger, its bugged and i dont know why

Bugged in what way?

Possibly caused by the dummy unit not being able to cast the ability.

Also leaks quite a bit.

Diegoit · Apr 12, 2018

Dr Super Good said:
Bugged in what way?

Possibly caused by the dummy unit not being able to cast the ability.

Also leaks quite a bit.

Yes i know i must deleted that location leak.
It want not to work, first test look weird and other tests it takes more than one unit...

Dr Super Good · Apr 13, 2018

Diegoit said:
Yes i know i must deleted that location leak.

And the group leak...
(Random 1 units from xFastG)
This makes another group object that has to be destroyed.

Diegoit said:
It want not to work, first test look weird and other tests it takes more than one unit...

Might need a demo map where this problem can be recreated.

I do know that "(Random 1 units from xFastG)" is bugged in that it is not truly random. To force it to fire only once you could use the single random unit from group unit function. This way the kill actions are not looped and so will only fire once per execution.

Diegoit · Apr 13, 2018

Dr Super Good said:
To force it to fire only once you could use the single random unit from group unit function. This way the kill actions are not looped and so will only fire once per execution.

Show me pls.

Dr Super Good · Apr 13, 2018

You have not posted a map demonstrating the broken system so how can I show you it fixed?

Diegoit · Apr 13, 2018

Here are, it is good at first uses but it stop working after some uses.

Dr Super Good · Apr 16, 2018

Units cannot cast target abilities on units they cannot see.

In this case Neutral Passive might not have vision of the peasants so is unable to cast lightning on them even if the lightning ability has 0 cooldown, costs 0 mana and has as good as infinite cast range.

Diegoit · Apr 16, 2018

Dr Super Good said:
Units cannot cast target abilities on units they cannot see.

In this case Neutral Passive might not have vision of the peasants so is unable to cast lightning on them even if the lightning ability has 0 cooldown, costs 0 mana and has as good as infinite cast range.

Still not working correctly :C

Dr Super Good · Apr 16, 2018

Diegoit said:
Still not working correctly :C

Worked perfectly for me when I added 40 peasants and disabled fog and black mask. Every building placed caused a random peasant to die.

Until I disabled fog and black mask a random peasant would die only if the chosen random peasant was nearby, close enough for the neutral passive footman that spawned to see them.

One could create a visibility modifier for neutral passive above the victim peasant so it can be targeted. One could also disable fog of war and black mask for neutral passive so they can always see all peasants. One could also force all players to have shared vision with neutral passive so that neutral passive can see their units and even invisible units.

Diegoit · Apr 16, 2018

Dr Super Good said:
Worked perfectly for me when I added 40 peasants and disabled fog and black mask. Every building placed caused a random peasant to die.

Until I disabled fog and black mask a random peasant would die only if the chosen random peasant was nearby, close enough for the neutral passive footman that spawned to see them.

One could create a visibility modifier for neutral passive above the victim peasant so it can be targeted. One could also disable fog of war and black mask for neutral passive so they can always see all peasants. One could also force all players to have shared vision with neutral passive so that neutral passive can see their units and even invisible units.

Can you attach me that map pls?

Dr Super Good · Apr 16, 2018

Diegoit said:
Can you attach me that map pls?

Sure, here you go.

EDIT: Deleted attachment due to leaks and bug in it.

Diegoit · Apr 17, 2018

It still having problem

, can you create a different trigger that makes same function? pls

Dr Super Good · Apr 17, 2018

Diegoit said:
It still having problem

What problem? Can you upload a video showing the problem? When I tested it, each building killed 1 peasant. I built like 10-20 buildings.

Diegoit · Apr 20, 2018

Yes but sometimes it just dont do anything

Diegoit said:
It still having problem , can you create a different trigger that makes same function? pls

Dr Super Good · Apr 20, 2018

Here you go...

EDIT: Deleted attachment due to bug in it.

Diegoit · Apr 20, 2018

Dr Super Good said:
Here you go...

It still having troubles BUT it has a 90% of efficiency so im happy with that

Thanks

Dr Super Good · Apr 21, 2018

Bloodsoul pointed out that the reason why it is not working is that the footman is trying to cast chain lightning on a dead peasant. The solution is to filter the group and remove all dead units.

Here is the final trigger, available for test in the attached map:

Kill Slave
- Events
  - Unit - A unit Begins construction
- Conditions
- Actions
  - Set SwapUnitType = Peasant
  - Set SwapPlayer = (Owner of (Triggering unit))
  - Unit Group - Remove all units from KillSlaveGroup
  - Custom script: set bj_groupEnumTypeId = udg_SwapUnitType
  - Custom script: call GroupEnumUnitsOfPlayer(udg_KillSlaveGroup, udg_SwapPlayer, filterGetUnitsOfTypeIdAll)
  - Unit Group - Pick every unit in KillSlaveGroup and do (Actions)
    - Loop - Actions
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        ((Picked unit) is dead) Equal to True
        
        Then - Actions
        
        Unit Group - Remove (Picked unit) from KillSlaveGroup
        
        Else - Actions
  - Set KillSlaveTempLoc = (Position of (Triggering unit))
  - Unit - Create 1 Footman for Neutral Passive at (Position of (Triggering unit)) facing Default building facing degrees
  - Custom script: call RemoveLocation(udg_KillSlaveTempLoc)
  - Unit - Add a 5.00 second Generic expiration timer to (Last created unit)
  - Unit - Add Chain Lightning (Neutral Hostile) to (Last created unit)
  - Set KillSlaveTempUnit = (Random unit from KillSlaveGroup)
  - Unit - Grant shared vision of KillSlaveTempUnit to Neutral Passive
  - Unit - Order (Last created unit) to Orc Far Seer - Chain Lightning KillSlaveTempUnit

It may still bug if the peasant corpses get modified in some way so as to not count as dead. But for the most part it will work reliably.

Diegoit · Apr 21, 2018

Dr Super Good said:
Bloodsoul pointed out that the reason why it is not working is that the footman is trying to cast chain lightning on a dead peasant. The solution is to filter the group and remove all dead units.

Here is the final trigger, available for test in the attached map:

Kill Slave

Events

Unit - A unit Begins construction

Conditions

Actions

Set SwapUnitType = Peasant

Set SwapPlayer = (Owner of (Triggering unit))

Unit Group - Remove all units from KillSlaveGroup

Custom script: set bj_groupEnumTypeId = udg_SwapUnitType

Custom script: call GroupEnumUnitsOfPlayer(udg_KillSlaveGroup, udg_SwapPlayer, filterGetUnitsOfTypeIdAll)

Unit Group - Pick every unit in KillSlaveGroup and do (Actions)

Loop - Actions

If (All Conditions are True) then do (Then Actions) else do (Else Actions)

If - Conditions

((Picked unit) is dead) Equal to True

Then - Actions

Unit Group - Remove (Picked unit) from KillSlaveGroup

Else - Actions

Set KillSlaveTempLoc = (Position of (Triggering unit))

Unit - Create 1 Footman for Neutral Passive at (Position of (Triggering unit)) facing Default building facing degrees

Custom script: call RemoveLocation(udg_KillSlaveTempLoc)

Unit - Add a 5.00 second Generic expiration timer to (Last created unit)

Unit - Add Chain Lightning (Neutral Hostile) to (Last created unit)

Set KillSlaveTempUnit = (Random unit from KillSlaveGroup)

Unit - Grant shared vision of KillSlaveTempUnit to Neutral Passive

Unit - Order (Last created unit) to Orc Far Seer - Chain Lightning KillSlaveTempUnit

It may still bug if the peasant corpses get modified in some way so as to not count as dead. But for the most part it will work reliably.

Wow, that was a good point, +4 rep

Kill random peon when start constructing buildings

Attachments

Attachments

Similar threads