[JASS] Detecting a dead unit

[Garfield1337]

I wondered what's the best way of detecting if a unit is dead.
I know 3 ways,but for each of them,someone says it isn't a valid way of doing it

1) IsUnitType(unit,UNIT_TYPE_DEAD) == true
2) GetUnitState(unit,UNIT_STATE_LIFE) <= 0
3) GetWidgetLife(unit) < 0.405

Can someone tell me which way should be used? Arguments are welcome.

 

[Pharaoh_]

I always use the third option, but there are libraries, which can detect a dead unit for sure.

 

[Sevion]

All methods have bugs, but I'd rather use the UnitAlive native.

 

[Dr Super Good]

The problem is apparently it is possible to "heal a dead unit" which means it is still dead but no longer has no life. It will act exactly like a dead unit should (decay, resurrectable/usable corpse) but no longer has 0 life so methods 2 and 3 above will fail.

This however is extreemly rare. Only native spells in certain situations (tranquility I heard is the most common trouble causer) can can cause this. Custom spells can be be made to not cause this by checking if the unit is actually alive before healing it.

 

[Garfield1337]

The problem is apparently it is possible to "heal a dead unit" which means it is still dead but no longer has no life. It will act exactly like a dead unit should (decay, resurrectable/usable corpse) but no longer has 0 life so methods 2 and 3 above will fail.

This however is extreemly rare. Only native spells in certain situations (tranquility I heard is the most common trouble causer) can can cause this. Custom spells can be be made to not cause this by checking if the unit is actually alive before healing it.

So...i should use IsUnitType(unit,UNIT_TYPE_DEAD) == true?

And what about AI native UnitAlive as Sevion said?

 

[Dr Super Good]

That apparently has its own problems, but I do not know of them specifically.

 

[Pharaoh_]

They both work the same way. In fact unit-type == dead is a really rare method. The problem with them is that they consider a dead unit with a delay, after its death, while Life detection is instant.

 

[Garfield1337]

Sigh...i guess i'll use GetWidgetLife.

Thanks for help,repped you all.

 

[WaterKnight]

They both work the same way. In fact unit-type == dead is a really rare method. The problem with them is that they consider a dead unit with a delay, after its death, while Life detection is instant.

That's odd. In which case? UNIT_TYPE_DEAD for me is even true on a Unit's life becomes Equal To 0 that runs before the death event.

You could also indicate dead units on death like putting them into a group but would then have to trigger/detect resurrections and to clear it up when the unit decays.

 

[Bribe]

IsUnitType(u, UNIT_TYPE_DEAD) and GetUnitTypeId(u) != 0

That never fails in any circumstance.

UnitAlive can be used in most cases, but if you are afraid its life may have been changed in the same thread just use getwidgetlife.

 

[Garfield1337]

Thanks for the tips,guys.
I'll use IsUnitType(u, UNIT_TYPE_DEAD) and GetUnitTypeId(u) != 0 then.

 

[Troll-Brain]

Does GetUnitTypeId(u) != 0 returns true on a ghost unit (removed but associated handle not flushed) ?

I don't think that is better to consider an invalid unit as not dead, i means this part of check should be done before that.

Also what if you play with UnitAdd/RemoveType ? (just curious)

 

[Pharaoh_]

A ghost unit doesn't nullify it, so GetUnitTypeId() would return its normal Id. Returns true on a function that already returns integer is impossible

Additionally, that kind of UnitAddType() has almost nothing to do with the comparison the function above handles.

 

[Troll-Brain]

A ghost unit doesn't nullify it, so GetUnitTypeId() would return its normal Id. Returns true on a function that already returns integer is impossible

Read again I mean GetUnitTypeId(<unit>) != 0 which is a valid boolean expression ...
Plus i wouldn't make a such statement without testing it, it would returns its normal id but that doesn't mean it will.

Additionally, that kind of UnitAddType() has almost nothing to do with the comparison the function above handles.

UnitAdd/RemoveType(<unit>,UNIT_TYPE_DEAD)

I don't mean it should be used, i said i'm just curious about it.

 

[Bribe]

GetUnitTypeId(u) == 0 returns true if the unit has been removed (in the case where u is still pointing to its handle), but UNIT_TYPE_DEAD returns false because a removed unit doesn't have any unit-types associated with it any longer.

 

[Garfield1337]

GetUnitTypeId(u) == 0 returns true if the unit has been removed (in the case where u is still pointing to its handle), but UNIT_TYPE_DEAD returns false because a removed unit doesn't have any unit-types associated with it any longer.

When filtering out dead units in damage filter,it's best to use IsUnitType(u, UNIT_TYPE_DEAD) or GetUnitTypeId(u) == 0 then?

 

[Bribe]

If u was already stored, then yes. Enumerating a group (GroupEnumUnitsInRange, for example) can't enumerate removed units.