Moderator
M
Moderator
12.12
IcemanBo: For long time as NeedsFix. Rejected.
Bribe:
- This needs to run for players 1-12, not 1-10.
- It doesn't adjust if a player leaves mid-game. Possible suggestion.
- Use (Triggering unit) not (Dying unit)
- You don't need to add an "And" block for conditions - it automatically checks if all are true. Also, it's useless to re-check the minimum when previous if's already ruled-out the minimum, you should just be checking the maximum.
- Point arrays are slow, just make 2-3 normal point variables and use those instead.
- Take advantage of the bj_wantDestroyGroup custom script instead of group set/pick/destroy as it's faster.
- (Level of TempUnit) you reference a lot, you should store this into an integer variable to speed things up.
- Same with (Level of (Picked unit))
- The floating text should be configurable from the initialization block.
IcemanBo: For long time as NeedsFix. Rejected.
Bribe:
- This needs to run for players 1-12, not 1-10.
- It doesn't adjust if a player leaves mid-game. Possible suggestion.
- Use (Triggering unit) not (Dying unit)
- You don't need to add an "And" block for conditions - it automatically checks if all are true. Also, it's useless to re-check the minimum when previous if's already ruled-out the minimum, you should just be checking the maximum.
- Point arrays are slow, just make 2-3 normal point variables and use those instead.
- Take advantage of the bj_wantDestroyGroup custom script instead of group set/pick/destroy as it's faster.
- (Level of TempUnit) you reference a lot, you should store this into an integer variable to speed things up.
- Same with (Level of (Picked unit))
- The floating text should be configurable from the initialization block.