String functions

[maskedpoptart]

Could one of the JASS moderators please give me some feedback on the new version and tell me if there is anything I can do to get this approved? I have time to fix things today and tomorrow, but I will be gone on a trip starting Thursday. I would like to be done with this library by then.

Thank you for your patience and understanding.

[aznricepuff]

function SBase2I takes string oldBaseString, integer oldBase returns integer
          local integer base10Num = 0
          local integer placeNum //number at current place
          local integer placeIndex = 0 //index of current place. 0 = one's place, etc.
          local integer i = StringLength(oldBaseString)-1
          loop
              exitwhen i < 0
              set placeNum = FindLastIndexFrom(HEX_CHARS, SubString(oldBaseString, i, i+1), oldBase-1)
              set base10Num = base10Num + placeNum*R2I(Pow(I2R(oldBase), I2R(placeIndex)))
              set placeIndex = placeIndex + 1
              set i = i - 1
          endloop
          return base10Num
     endfunction

You dont need those I2R() casts inside Pow().

And if you're not going to support negative numbers, make a note of it in the documentation.

And I don't like the function names S2Id and Id2S. Id seems too vague, could refer to a lot of things. Maybe S2RawCode/RawCode2S.

[maskedpoptart]

Fixed all of the above. I seem to have trouble coming up with good function names... :/

I have some questions about raw codes that I am wondering if anyone can answer. I have found out that they are four-digit, base 256 integers. However, I can only find 62 possible characters to put in each digit (namely 0-9, A-Z, a-z). Did I miss any? What about the other 194 numbers that could be represented in each digit? Why didn't blizzard make them base 64 integers?

[aznricepuff]

The raw codes are just integers. The single quotations ' ' are standard CS notation for a cast from characters to integer. In the case of JASS, the cast follows ascii standards. BUT, blizz for some reason decided to only allow these casts for sequences of a single character or four characters. Any other number, and every compiler I've ever used gives you a syntax error (though I'm curious to see if a map would still work if the compiler ignores this limitation and compiles the code anyway).

You can use any of the ascii characters when doing these casts in JASS, as long as you only use one or four characters:

call BJDebugMsg(I2S(')')) // displays 41
call BJDebugMsg(I2S('))))')) // displays 690563369
call BJDebugMsg(I2S('ff')) // syntax error!

You can also use non-alphanumeric characters in object raw codes, so you can have an ability with raw code '))))'.

[maskedpoptart]

Thanks for the explanation. The S2RawCode and RawCode2S functions now work with any sequence of standard ASCII chars from 32 to 126. While the functions should work for a sequence of any length, world editor will only let you input sequences of one or four characters.
Let me know if there's anything else I can do to get this approved.

Off Topic...

For some reason, TESH screws up with \" as an escape combination. It looks at the quote as a regular quote. Who do I contact about this?

[Eleandor]

You can use any of the ascii characters when doing these casts in JASS, as long as you only use one or four characters:

Haven't tested it but are you sure it's limitted to 1 or four? I'd say 1 to 4...

[hvo-busterkomo]

It's 1 or 4. Both 2 and 3 will produce compile errors.

[maskedpoptart]

Hey guys, I am back from my trip. aznricepuff, I have done everything you asked since initial release. At the moment, I am not aware of any reason this resource should not be approved. It is quite useful and has no bugs that I am aware of. I would appreciate it if you could either approve it, tell me what I can do to get it approved, or tell me why it should not be approved. Thanks again.

[aznricepuff]

Yea, sorry about the delay. I've been busy with other things (non-wc or HW related) lately.

Approved.

[maskedpoptart]

Thank you mr. rice puff . I want to eat you up (jk).

P.S. I completely understand. Don't worry about the delay.

[Element of Water]

Please submit this on Wc3c so I can use it in my submissions there :D