Problem

[DinoNegative]

Stopped save map. Pls guys help me. Before everything was fine.
This is spell

 

[Plynch]

You are using $ in your variable names, this isnt a valid variable name and therefore wont compile. Remove the $ signs and it should work/find your next error

Edit: Dont know anything about macros so i might be wrong..

 

[Dr Super Good]

The macro is not compiling properly. It is meant to not compile macro declarations (they are kept in comments or not included in the map script) and instead compile them with substitutions for every time you reference the macro.

 

[jonhysone]

Lol you can't use '$' symbol in JASS , nor in GUI , y'know...

 

[DinoNegative]

PLs guys. Who can help correct this spell.? pls

 

[jonhysone]

Give me spell's map file I will correct it

 

[Dr Super Good]

Lol you can't use '$' symbol in JASS , nor in GUI , y'know...

If I recall from vJASS macros, they are used to define a variable that will be substituted when the macro is run. I did use them >4 years ago so I could be wrong...

 

[DinoNegative]

Give me spell's map file I will correct it

This is map

 

[Dr Super Good]

The macro was incorrectly declared and used (syntax error).

It was given as...

//!textmacro ALLOCATE takes NAME 
globals
    integer $NAME$I  = 0
    private integer $NAME$FreeAm = 0
    private integer $NAME$MaxId  = 0  
    private integer array $NAME$FreeAr
    private boolean array $NAME$IsUsed
endglobals

function $NAME$alloc takes nothing returns nothing
    if $NAME$FreeAm == 0 then
        set $NAME$MaxId = $NAME$MaxId + 1
        set $NAME$I = $NAME$MaxId
    else
        set $NAME$I = $NAME$FreeAr[$NAME$FreeAm]
        set $NAME$FreeAm = $NAME$FreeAm - 1  
    endif
    set $NAME$IsUsed[$NAME$I] = true
endfunction

function $NAME$clean takes integer index returns nothing
    set $NAME$IsUsed[index] = false
    set $NAME$FreeAm = $NAME$FreeAm + 1
    set $NAME$FreeAr[$NAME$FreeAm] = index
endfunction
//!endtextmacro
//!runtextmacro ALLOCATE ("te_")
//!runtextmacro ALLOCATE ("sh_")

But should have been...

//! textmacro ALLOCATE takes NAME 
globals
    integer $NAME$I  = 0
    private integer $NAME$FreeAm = 0
    private integer $NAME$MaxId  = 0  
    private integer array $NAME$FreeAr
    private boolean array $NAME$IsUsed
endglobals

function $NAME$alloc takes nothing returns nothing
    if $NAME$FreeAm == 0 then
        set $NAME$MaxId = $NAME$MaxId + 1
        set $NAME$I = $NAME$MaxId
    else
        set $NAME$I = $NAME$FreeAr[$NAME$FreeAm]
        set $NAME$FreeAm = $NAME$FreeAm - 1  
    endif
    set $NAME$IsUsed[$NAME$I] = true
endfunction

function $NAME$clean takes integer index returns nothing
    set $NAME$IsUsed[index] = false
    set $NAME$FreeAm = $NAME$FreeAm + 1
    set $NAME$FreeAr[$NAME$FreeAm] = index
endfunction
//! endtextmacro
//! runtextmacro ALLOCATE ("te_")
//! runtextmacro ALLOCATE ("sh_")

Basically...

//!textmacro ALLOCATE takes NAME 
//!endtextmacro
//!runtextmacro ALLOCATE ("te_")
//!runtextmacro ALLOCATE ("sh_")

Are all interpreted as comments unless there is a space after the '!'. It is possible that a custom vjass compiler was used or an old/alternative version which had less strict syntax. It clearly is explained in the vjass manual that there must be a space for it to register as a macro correctly.

Give me spell's map file I will correct it

You could have just told him it instead of trying to act all smart and all knowing. Which reminds me...

Lol you can't use '$' symbol in JASS , nor in GUI , y'know...

That was not helpful at all.

 

[DinoNegative]

The macro was incorrectly declared and used (syntax error).

It was given as...

//!textmacro ALLOCATE takes NAME 
globals
    integer $NAME$I  = 0
    private integer $NAME$FreeAm = 0
    private integer $NAME$MaxId  = 0  
    private integer array $NAME$FreeAr
    private boolean array $NAME$IsUsed
endglobals

function $NAME$alloc takes nothing returns nothing
    if $NAME$FreeAm == 0 then
        set $NAME$MaxId = $NAME$MaxId + 1
        set $NAME$I = $NAME$MaxId
    else
        set $NAME$I = $NAME$FreeAr[$NAME$FreeAm]
        set $NAME$FreeAm = $NAME$FreeAm - 1  
    endif
    set $NAME$IsUsed[$NAME$I] = true
endfunction

function $NAME$clean takes integer index returns nothing
    set $NAME$IsUsed[index] = false
    set $NAME$FreeAm = $NAME$FreeAm + 1
    set $NAME$FreeAr[$NAME$FreeAm] = index
endfunction
//!endtextmacro
//!runtextmacro ALLOCATE ("te_")
//!runtextmacro ALLOCATE ("sh_")

But should have been...

//! textmacro ALLOCATE takes NAME 
globals
    integer $NAME$I  = 0
    private integer $NAME$FreeAm = 0
    private integer $NAME$MaxId  = 0  
    private integer array $NAME$FreeAr
    private boolean array $NAME$IsUsed
endglobals

function $NAME$alloc takes nothing returns nothing
    if $NAME$FreeAm == 0 then
        set $NAME$MaxId = $NAME$MaxId + 1
        set $NAME$I = $NAME$MaxId
    else
        set $NAME$I = $NAME$FreeAr[$NAME$FreeAm]
        set $NAME$FreeAm = $NAME$FreeAm - 1  
    endif
    set $NAME$IsUsed[$NAME$I] = true
endfunction

function $NAME$clean takes integer index returns nothing
    set $NAME$IsUsed[index] = false
    set $NAME$FreeAm = $NAME$FreeAm + 1
    set $NAME$FreeAr[$NAME$FreeAm] = index
endfunction
//! endtextmacro
//! runtextmacro ALLOCATE ("te_")
//! runtextmacro ALLOCATE ("sh_")

Basically...

//!textmacro ALLOCATE takes NAME 
//!endtextmacro
//!runtextmacro ALLOCATE ("te_")
//!runtextmacro ALLOCATE ("sh_")

Are all interpreted as comments unless there is a space after the '!'. It is possible that a custom vjass compiler was used or an old/alternative version which had less strict syntax. It clearly is explained in the vjass manual that there must be a space for it to register as a macro correctly.


You could have just told him it instead of trying to act all smart and all knowing. Which reminds me...

That was not helpful at all.

Thank You