[JASS] What the hell is wrong here

[Need_O2]

//TESH.scrollpos=3
//TESH.alwaysfold=0
 function Trig_Fury_of_the_Sapphiron_Actions takes nothing returns nothing
    local group g
    local unit cu
if ( GetSpellAbilityId() == 'A00P' )  then
    set bj_forLoopAIndex = 1
    set bj_forLoopAIndexEnd = 5
    loop
        exitwhen bj_forLoopAIndex > bj_forLoopAIndexEnd
        call CreateNUnitsAtLoc( 1, 'h009', GetOwningPlayer(GetTriggerUnit()), GetRandomLocInRect(RectFromCenterSizeBJ(GetUnitLoc(GetTriggerUnit()), 100.00, 100.00)), bj_UNIT_FACING )
        call UnitApplyTimedLifeBJ( 0.01, 'BTLF', GetLastCreatedUnit() )
        set bj_forLoopAIndex = bj_forLoopAIndex + 1
    endloop
    set g = GetUnitsInRectAll(GetUnitsInRangeOfLocAll(800.00, GetUnitLoc(GetTriggerUnit())))
        loop
            set cu = FirstOfGroup(g)
            exitwhen cu = null
            if ((IsUnitType(GetEnumUnit(), UNIT_TYPE_MAGIC_IMMUNE) == false ) and ( IsUnitType(cu, UNIT_TYPE_STRUCTURE) == false ) and ( IsPlayerEnemy(GetOwningPlayer(GetTriggerUnit()),GetOwningPlayer(cu)) = true ) and (GetOwningPlayer(cu)) == true )) then
            call UnitDamageTargetBJ( GetTriggerUnit(), cu, 3000.00, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_MAGIC )
            call CreateNUnitsAtLoc( 1, 'h005', GetOwningPlayer(GetTriggerUnit()), GetUnitLoc(cu), bj_UNIT_FACING )
            call UnitApplyTimedLifeBJ( 1.00, 'BTLF', GetLastCreatedUnit() )
            call IssueTargetOrderBJ( GetLastCreatedUnit(), "entanglingroots", cu)
            call GroupRemoveUnit(g,cu)
            endif
        endloop
    call DestroyGroup(g)
    endif
endfunction

//===========================================================================
function InitTrig_Fury_of_the_Sapphiron takes nothing returns nothing
    set gg_trg_Fury_of_the_Sapphiron = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Fury_of_the_Sapphiron, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddAction( gg_trg_Fury_of_the_Sapphiron, function Trig_Fury_of_the_Sapphiron_Actions )
endfunction

    set g = GetUnitsInRectAll(GetUnitsInRangeOfLocAll(800.00, GetUnitLoc(GetTriggerUnit()))

TESH says error is here btw
This is my Fury of the Sapphiron spell which damages and casts entaglin rots spell(with crystal buff efect) on enemies nearby and I use units for some effects to make them bigger
Well It was okan in GUI but when I converted in jass and make some modifications on it, it got broken
NewGen WE gives error, normal WE doesnt give error but closes application with error the error drwatson gives This app applied invaild action blabla blabla

 

[Arkan.]

You have a loop without a "endloop".

Also I don't see the purpose of your condition, why not remove it if it only returns true?

 

[Need_O2]

Ive exitwhen :/ doesnt it end the loop
Edit
ok its fixed but It still gives error
I edited the tread check the trigger again
and where is purple btw Heey someone here need a hand
I'll make a spotlight with PurplePoot like in batman

 

[Arkan.]

You made some small mistakes such as = instead of == on some lines, also yoru group was invalid, try this:

function Trig_Fury_of_the_Sapphiron_Actions takes nothing returns nothing
    local group g
    local unit cu
if ( GetSpellAbilityId() == 'A00P' )  then
    set bj_forLoopAIndex = 1
    set bj_forLoopAIndexEnd = 5
    loop
        exitwhen bj_forLoopAIndex > bj_forLoopAIndexEnd
        call CreateNUnitsAtLoc( 1, 'h009', GetOwningPlayer(GetTriggerUnit()), GetRandomLocInRect(RectFromCenterSizeBJ(GetUnitLoc(GetTriggerUnit()), 100.00, 100.00)), bj_UNIT_FACING )
        call UnitApplyTimedLifeBJ( 0.01, 'BTLF', GetLastCreatedUnit() )
        set bj_forLoopAIndex = bj_forLoopAIndex + 1
    endloop
    set g = GetUnitsInRangeOfLocAll(800.00, GetUnitLoc(GetTriggerUnit()))
        loop
            set cu = FirstOfGroup(g)
            exitwhen cu == null
            if ((IsUnitType(cu, UNIT_TYPE_MAGIC_IMMUNE) == false ) and ( IsUnitType(cu, UNIT_TYPE_STRUCTURE) == false ) and ( IsPlayerEnemy(GetOwningPlayer(GetTriggerUnit()),GetOwningPlayer(cu)) == true  )) then
            call UnitDamageTargetBJ( GetTriggerUnit(), cu, 3000.00, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_MAGIC )
            call CreateNUnitsAtLoc( 1, 'h005', GetOwningPlayer(GetTriggerUnit()), GetUnitLoc(cu), bj_UNIT_FACING )
            call UnitApplyTimedLifeBJ( 1.00, 'BTLF', GetLastCreatedUnit() )
            call IssueTargetOrderBJ( GetLastCreatedUnit(), "entanglingroots", cu)
            call GroupRemoveUnit(g,cu)
            endif
        endloop
    call DestroyGroup(g)
    endif
endfunction
//===========================================================================
function InitTrig_Fury_of_the_Sapphiron takes nothing returns nothing
    set gg_trg_Fury_of_the_Sapphiron = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Fury_of_the_Sapphiron, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddAction( gg_trg_Fury_of_the_Sapphiron, function Trig_Fury_of_the_Sapphiron_Actions )
endfunction

It still leaks locations though, you need to take care of that.

 

[Need_O2]

yea Im quite new in jass yo very new actually tnx for help buddy
EDIT: Need help again it doesnt do 3000 damage it doesnt do damage anyway
Units are enemy and every other conditions are fine
BTW effects work
EDIT 2: FIXED just move the call GroupRemoveUnit(g,cu) after endif
Hey Im starting to get better
EDIT 3: Now I just need to reduce the leaks

 

[PurplePoot]

To help remove leaks, have a look at these 3 natives to replace your unit creation;

native          CreateUnit          takes player id, integer unitid, real x, real y, real face returns unit
constant native GetUnitX            takes unit whichUnit returns real
constant native GetUnitY            takes unit whichUnit returns real

 

[Need_O2]

I dont know anything about natives

 

[Arkan.]

Natives are one of reasons why you use JASS, it would be stupid to not use them.

call CreateNUnitsAtLoc

replace that with

local unit dummy = CreateUnit()

UnitDamageTargetBJ

can be

UnitDamageTarget()

´

Basically all the functions you used that ends with BJ can be replaced by native functions (that doesn't have BJ in their name). You need to study common.j to figure out what the native functins are called, this can easily be done in JASSCraft.

 

[Need_O2]

ah I use JASS for creating custom functions or making triggers shorter but thanks for tip anyway

 

[PurplePoot]

A native is just like a function, except natives are programmed in C++ (I think it's C++ anyways) (which is why they have no body in JASS) while functions are in JASS itself.

 

[Need_O2]

ah sorry its because of I didnt know what native means in my language I checked in dictionary now I got it