[JASS] What did i do wrong?

[Destroyer95]

I'm trying to learn to use structs and things like that. I came up with this:

struct lvl
     local real damage
    method level takes integer level returns real
     if level == 1 then
     set damage = 50
      elseif level == 2 then
      set damage = 75
       else
       set damage = 125
    endif
     return damage
 endmethod
endstruct

When i check it, it reports a FEW problems. So can someone help me?
Thx!

 

[GhostWolf]

method level takes integer level?

Also, struct members should be preceded with a dot when referenced inside the struct.
In your example - ".damage". This shortens "this.damage", which you can also write if you want.

Also do notice that this struct is useless.

 

[Yixx]

a struct with a local in it? Locals are placed in a function, not in a struct. You can make it 'private' though, but not local within a struct,,

 

[Mannoroth]

You can move the "local real damage" declaration inside the method. However, the struct only exists to return a calculated value through a method call, so using a simple function would be more appropriate unless you intend on adding more code to that struct or modifying struct members.

If what you wanted to do was declare "damage" as a member of the struct, you don't need to use the "local" keyword.

And as pointed out, you should use different names for methods/functions and their parameters and other vars. For example:

method GetDamage takes integer level returns real

 

[Feroc1ty]

struct lvl
    real damage
    method level takes integer l returns real
        if l == 1 then
            set .damage = 50
        elseif l == 2 then
            set .damage = 75
        else
            set .damage = 125
        endif
        return .damage
    endmethod
endstruct

That's your struct in the correct form, but as someone mentioned earlier, this struct is completely useless.