[Trigger] TriggerRegisterPlayerStateEvent --> PLAYER_STATE_RESOURCE_GOLD verbuggt?

[pred1980]

Hallo hivers,

i've found a bug in the events of wc3. I gave a player every x sekundes gold to his current gold and when you want to react to this without doing any action the event leaks

Check the map and activate/deactivate the "Gold Income Event" Trigger and take a look at the Handle Counter and your war3.exe in the task manager!!!

Workaround? Maybe save the gold every second and compare it with the current. If something has changed you can calculate the difference and you can do what ever you want... BUT WHY is the event bugged? grrr

Reg.
Patrick

edit: For Lumber is it the same... both events leaks???

 

[PurgeandFire]

Hmm.. That is a very strange bug indeed. Nice find. It seems that each time the event fires, it will register a new handle.

I'll try to run more tests later and see what happens.

 

[pred1980]

I'll try to run more tests later and see what happens.

and??


Some other opinions??

 

[deathismyfriend]

if i have time later ill try to run a few tests also.

 

[WaterKnight]

BUT WHY is the event bugged? grrr

Is this a philosophical question?

I can confirm the existence of the problem.

 

[pred1980]

Is this a philosophical question?

No, why? I just wonder about and i need this event in my map and it leaks hard... :/

 

[Dr Super Good]

The memory increase is also from all the unique strings you make.

It is quite true there does appear to be a handle leak. The big question is what handle types are leaking and can they be destroyed?

 

[Xonok]

My guess is that every time the event happens the gold or lumber is referenced in a local variable. Hope not.

 

[WaterKnight]

Don't threads also receive an agent id while running?

 

[Dr Super Good]

My guess is that every time the event happens the gold or lumber is referenced in a local variable. Hope not.

Too bad the stack is destroyed when the thread dies.

 

[Xonok]

Too bad the stack is destroyed when the thread dies.

Now that I think of it it doesn't make sense for it to leak unless it creates an agent. What agent might it create? Dunno.

 

[Malhorne]

That's very strange i tested it and i don't know why can be the source of this shitty leak :/ !

 

[PurgeandFire]

This may shed some light on the issue. I can't test all too often so I haven't been able to get back to it, but I assume this would be related to the problem:

How triggers work: when a trigger is activated (not by TriggerExecute/evaluate, but by an event) a handle is created. I have no idea what is stored in that handle. It gets removed after the trigger finishes execution. If you destroy the trigger during execution (in actions, removing it in conditions would crash the tread), it releases handles associated with the trigger including this handle, and after a triggersleepaction apparently wc3 sees that the trigger has finished execution (since it no longer exists) and releases this handle again, so it gets added to the triggerstack twice, and next 2 allocated objects would get the same handle.

Source

It may just take a while to recycle. In a realistic setting, there probably won't be any problems.

 

[Dr Super Good]

It may just take a while to recycle. In a realistic setting, there probably won't be any problems.

It should not take any time to recycle as it is freed immediately when the trigger finishes execution. Notice how the periodic event does not leak handles but that event does.

 

[PurgeandFire]

Yeah nvm, the counter will still go up even if you just enter greedisgood.

 

[pred1980]

any cool ideas for a workaround?

 

[Dr Super Good]

Periodic poll (10 times a second) with some intelligence so that it can tell if multiple gold miners/lumberjacks dropped resources in that time. All triggered income sources could be done using a custom function that executes triggers attached to the custom income system. Even still it might have problem with resource expenditure.

 

[WaterKnight]

There are multiple sources you cannot well detect. Like queuing up unit trainings or said harvesting.