1. Updated Resource Submission Rules: All model & skin resource submissions must now include an in-game screenshot. This is to help speed up the moderation process and to show how the model and/or texture looks like from the in-game camera.
    Dismiss Notice
  2. DID YOU KNOW - That you can unlock new rank icons by posting on the forums or winning contests? Click here to customize your rank or read our User Rank Policy to see a list of ranks that you can unlock. Have you won a contest and still havn't received your rank award? Then please contact the administration.
    Dismiss Notice
  3. The Lich King demands your service! We've reached the 19th edition of the Icon Contest. Come along and make some chilling servants for the one true king.
    Dismiss Notice
  4. The 4th SFX Contest has started. Be sure to participate and have a fun factor in it.
    Dismiss Notice
  5. The poll for the 21st Terraining Contest is LIVE. Be sure to check out the entries and vote for one.
    Dismiss Notice
  6. The results are out! Check them out.
    Dismiss Notice
  7. Don’t forget to sign up for the Hive Cup. There’s a 555 EUR prize pool. Sign up now!
    Dismiss Notice
  8. The Hive Workshop Cup contest results have been announced! See the maps that'll be featured in the Hive Workshop Cup tournament!
    Dismiss Notice
  9. Check out the Staff job openings thread.
    Dismiss Notice
Dismiss Notice
60,000 passwords have been reset on July 8, 2019. If you cannot login, read this.

Starcraft II Beta Key Spell Contest

Discussion in 'Triggers & Scripts' started by TriggerHappy, Apr 25, 2010.

  1. Fate

    Fate

    Joined:
    Apr 27, 2010
    Messages:
    12
    Resources:
    0
    Resources:
    0
    I followed the rules. Noone said there has to be a minum nummber of code lines.
    You didnt review it ? Did you even click the "test"-button?

    My spell has a name, if you would have tested the map you´d know it.

    That really makes me angry

    Edit: I agree with anachron
     
  2. Piranha89

    Piranha89

    Joined:
    Aug 22, 2008
    Messages:
    128
    Resources:
    1
    Maps:
    1
    Resources:
    1
    I disagree on many points that Triggerhappy mentioned in the reviews, but I was really surprised not to see him flaming about "non-vJass". Coding experienced?:wink:

    By the way... Dark_gandalfs spell has been already uploaded by somebody long time ago, referring to that tentacle pulling and throwing.
    I don't know whether it has been himself, but this should be a greater malus, since you even accused my teleporting beam with it's effects of unoriginality, though I cannot find even one similar spell here on THW.

    Please get some more moderators for judging next time, several things have been really not justified. Most spells that got a low rating on the competition deserve some more points, while most wellpointed submissions do not really deserve the points on certain issues.
     
  3. Anachron

    Anachron

    Joined:
    Sep 9, 2007
    Messages:
    6,167
    Resources:
    66
    Icons:
    49
    Packs:
    2
    Tools:
    1
    Maps:
    3
    Spells:
    9
    Tutorials:
    1
    JASS:
    1
    Resources:
    66
    That's because he allowed GUI.

    All together I can't imagine this was a real contest.
     
  4. Lambdadelta

    Lambdadelta

    Joined:
    Jul 6, 2009
    Messages:
    719
    Resources:
    1
    Maps:
    1
    Resources:
    1
    oh. nice.

    anyways,
    wait.

    LOL? Did you just copy and paste the 'rules' for each spell?
     
  5. Anachron

    Anachron

    Joined:
    Sep 9, 2007
    Messages:
    6,167
    Resources:
    66
    Icons:
    49
    Packs:
    2
    Tools:
    1
    Maps:
    3
    Spells:
    9
    Tutorials:
    1
    JASS:
    1
    Resources:
    66
  6. Equal

    Equal

    Joined:
    Mar 23, 2007
    Messages:
    306
    Resources:
    1
    Maps:
    1
    Resources:
    1
    The mb best part of this "contest" was like Piranha89's flamewarcrussade against vJass, the rest was a joke.
    Orginaly this was supposed to be a speed-contest thingy but whatsoever nearly 3 weaks after end we got the results.

    The other thing is, that there was nothing about coding-style mentioned:

    NONE of this points was mentioned...

    I followed all the "coding rules"

    or did i just missed the hidenallyoushouldhavethesamecodingstylepart ?
    That was not worth waiting all this time..
    greets equal
     
  7. Anachron

    Anachron

    Joined:
    Sep 9, 2007
    Messages:
    6,167
    Resources:
    66
    Icons:
    49
    Packs:
    2
    Tools:
    1
    Maps:
    3
    Spells:
    9
    Tutorials:
    1
    JASS:
    1
    Resources:
    66
    You get -points for not having the points, not +points for having them.
    Also, just having a good style isn't enough.

    Only thing I can agree with here.
     
  8. D4RK_G4ND4LF

    D4RK_G4ND4LF

    Joined:
    Feb 4, 2009
    Messages:
    1,196
    Resources:
    20
    Models:
    3
    Spells:
    15
    Tutorials:
    2
    Resources:
    20
    ROFL I won o_O

    thanks for judging and congratulations to the second and third winner and all other participants as well
     
    Last edited: May 17, 2010
  9. DrEvil

    DrEvil

    Joined:
    Dec 21, 2008
    Messages:
    25
    Resources:
    1
    Spells:
    1
    Resources:
    1
    lol... good job D4RK_G4ND4LF,

    I guess my eye candy and concept sucked eggs like hell xD
    But it was fun...

    I think I came somewhere... near the end :thumbs_up:
     
  10. TriggerHappy

    TriggerHappy

    Code Moderator

    Joined:
    Jun 23, 2007
    Messages:
    3,666
    Resources:
    22
    Spells:
    11
    Tutorials:
    2
    JASS:
    9
    Resources:
    22
    Can you guys stop bitching at me please. Compared to most spell contests this was graded fairly fast. There have been contests where you would have to wait months for results.

    Oh, and another thing. I focused more on the actual spell than the coding when grading. I kept in mind that this is a spell contest where the idea was the focus point, not the coding. So don't get pissed if someone won because they used GUI or you lost even if your coding was better.

    And like I said before, don't expect long reviews, I tried doing this as quickly as possible as I have been fairly inactive lately and I actually got a day where I had literally nothing going on.

    The reviews may have sucked, but what are you going to do about it =\
    I'll just never judge a contest again.
     
  11. Deaod

    Deaod

    Joined:
    Nov 18, 2007
    Messages:
    805
    Resources:
    12
    Maps:
    1
    Spells:
    11
    Resources:
    12
    @Equal: If you want to make reading your code hell on earth, you can do that, but dont expect anyone to give you good marks for that. I personally can understand TriggerHappy when he reduces your coding points for not even indenting your code.

    Seems like you dont believe in vJass, do you? Using StringHash for hashtable keys kinda seems dumb. You could just use constant global integers (read up on keys in the JassHelper manual). That would be efficient. And using global arrays (structs) would be even more efficient.
    Also, your spell will desync Macs from PCs because you use UnitDamagePoint.
    You leak timers.
    You inlined all constants, which makes your spell a pain to adjust to other maps. I dont even know which objects are used for what.

    So let me summarize, your spell leaks, is inefficient without any good reason and has problems adjusting to new environments. However, ive yet to find that it is not MUI.
     
    Last edited: May 17, 2010
  12. elfian

    elfian

    Joined:
    Jun 28, 2008
    Messages:
    350
    Resources:
    2
    Maps:
    2
    Resources:
    2
    Oh come on =_= Everyone is mad. I am mad too, but... just stfu all of you. Everyone wants a key you don't have to bitch at the judge that he didn't pick you. Yeah ok, let's say the judging wasn't fair. So what? You know you can't reverse it. On the other hand, maybe we should just use polls where the users vote for all contests? That would be most fair probably, but it's not like every user knows JASS so well that he can view every single line and determine which spell is the best...
     
  13. Anachron

    Anachron

    Joined:
    Sep 9, 2007
    Messages:
    6,167
    Resources:
    66
    Icons:
    49
    Packs:
    2
    Tools:
    1
    Maps:
    3
    Spells:
    9
    Tutorials:
    1
    JASS:
    1
    Resources:
    66
    I am just mad at him because
    1.) I told him not to review it alone.
    2.) I told him that the review should be done quickly
    3.) ... One judge is not fair
    4.) ... he already is busy...

    but he didn't care of it, now (I hope) he learned from it.
     
  14. Fate

    Fate

    Joined:
    Apr 27, 2010
    Messages:
    12
    Resources:
    0
    Resources:
    0
    And why didnt you juge my spell then?
     
  15. Berb

    Berb

    Joined:
    Jan 21, 2006
    Messages:
    2,539
    Resources:
    2
    JASS:
    2
    Resources:
    2
    Unless there is an outstanding, breath-taking spell idea that nobody else even came close to competing against then I can understand how an idea would take you as far as a victory, but in any other situation judging a spell based on the idea is pretty stupid. Almost every spell submission in this contest was predictable and unpolished, despite whatever trendy idea they were trying to imitate.

    An idea isn't worth anything, it's the work that is put behind the idea that makes it worth a damn. If you've presented a spell that has 1 line of triggered GUI code and another contestant presents a spell with a diverse system of code setup for his/her spell then the victor would be an obvious choice.

    The only thing the idea can really be used for is edging a submission past another, but there's no way that a 3-line GUI code spell should have any chance of winning, as there was no real work put into it. It doesn't matter how long it takes a user to add up 2 + 2, they're still going to get 4.
     
  16. ikillforeyou

    ikillforeyou

    Joined:
    Jun 10, 2008
    Messages:
    1,341
    Resources:
    33
    Models:
    22
    Icons:
    9
    Packs:
    1
    Tutorials:
    1
    Resources:
    33
    rofl! the second the results came out i got an invitation into sc2 beta.

    soo happeh.
     
  17. PurplePoot

    PurplePoot

    Joined:
    Dec 14, 2005
    Messages:
    11,161
    Resources:
    3
    Maps:
    1
    Spells:
    1
    Tutorials:
    1
    Resources:
    3
    My god you guys are asses. I thought you were bad enough with your bitching a day or so after the contest ended about how he hadn't started judging yet, but... wow.
     
  18. Cokemonkey11

    Cokemonkey11

    Wurst Reviewer

    Joined:
    May 9, 2006
    Messages:
    3,240
    Resources:
    18
    Tools:
    1
    Maps:
    5
    Spells:
    3
    Tutorials:
    2
    JASS:
    7
    Resources:
    18
    Cheers to those that ranked in the contest, and TriggerHappy for making it possible.

    That was my first contest here at the hive and I'm glad I participated.
     
  19. darkrider

    darkrider

    Joined:
    Dec 31, 2007
    Messages:
    780
    Resources:
    1
    Maps:
    1
    Resources:
    1
    I know im not going to win the game because of this... but


    • Finish Spell
      • Events
        • Unit - A unit Dies
      • Conditions
        • (Unit-type of (Triggering unit)) Equal to Buff Caster
      • Actions
        • For each (Integer x) from 1 to GranadeCounter, do (Actions)
          • Loop - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Triggering unit) Equal to WanderTester[x]
              • Then - Actions
                • Unit - Remove (Triggering unit) from the game
                • Unit Group - Pick every unit in Targets[x] and do (Actions)
                  • Loop - Actions
                    • Unit - Remove Wander (Neutral) from (Picked unit)
                • Set WanderTester[x] = No unit
                • Set Caster[x] = No unit
                • Custom script: call DestroyGroup(udg_Targets[udg_x])
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • (JumpingBombs is empty) Equal to True
                  • Then - Actions
                    • Set GranadeCounter = 0
                  • Else - Actions
              • Else - Actions


    I do recicle the variable here and the only thing i do not recycle is the "udg_Targets" unit group

    nevermind. I know i did the coding the best i could :p
     
  20. sephiroth1234

    sephiroth1234

    Joined:
    Oct 11, 2009
    Messages:
    455
    Resources:
    0
    Resources:
    0
    Damn! My spell has not been placed! I must practice JASSing more and more! Anyway congrats to the placers!!!:grin: