Spellweaver's Talent Kitchen

[Mediumunwell]

Thank you so much for making this per my request. I'm sure it will be a great tool for many other map makers as well

 

[SpasMaster]

At first glance, this looks really cool and really customizeable. Great job.

I have a question.
If I understand correctly (after looking around the code for a bit), when a Talent has more than one dependency (like your "Coming of the Lambs"), currently you need to have both fulfilled in order to unlock it.

Is it possible to have 2 paths leading to a talent, but only needing one of the two dependencies to unlock it?

If not, is it something you can see being added to the system?

Thanks!

 

[The_Spellweaver]

It's great that you've noticed it, I appreciate you going through my code!

If not, is it something you can see being added to the system?

To answer your question, I haven't had this use case so I haven't implemented it. The way I would go about it would be a DependencyMode on the talent or something that would change the way CheckDependency logic works for that talent.

Specifically, the information is a number (required level) so I don't have much space to navigate in the baseline implementation. I've also had in plan to reserve the -1, -2 etc as flags. One usecase I've had was that I needed a disabled link no matter what, so I would set it to -1 (and handle it appropriately), then later programmatically change it to 0 if I want to unlock it (from perspective of dependencies no matter what).

So yeah it shouldn't be hard to add. Though like I said, it's a bit harder to design a user defined, out of the box boolean expression between the links lol
So saying two links need to be fulfilled + one of the other two is not something I'm thinking to add. It should be possible to do using Requirements callback + modifying talents' dependency values dynamically per talent! It's how I did it anyway.

 

[The_Spellweaver]

Made a different version of TalentTreeViewModel that allows multiple panels at the same time (such as 3 of them in WoW).
The problem is that they don't share talent points, and I'm not going to implement it. It needs to be done custom. I can implement additional functionalities (such as tree-wide callbacks) that will make it easier.

It will be able to be used in the Setup trigger.

Update:
I decided to make it a stub method, by default it keeps internal state of points, but it can be overriden in the implementation. In this case, it uses "lumber resource" as talent points.

method GetTalentPoints takes nothing returns integer
    return GetPlayerState(this.ownerPlayer, PLAYER_STATE_RESOURCE_LUMBER)
endmethod

method SetTalentPoints takes integer points returns nothing
    call SetPlayerState(this.ownerPlayer, PLAYER_STATE_RESOURCE_LUMBER, points)
endmethod

method Initialize takes nothing returns nothing
    local STKTalent_Talent t
    call this.SetColumnsRows(3, 4)
    set this.title = "Shepherd"
    call this.SetTalentPoints(6)
    ...

 

[The_Spellweaver]

Okay I did some more features and I tried to make a representative example, to show people what can be made with it

I would say configuring this took me 2-3 hours

Spoiler: Image

Functionally it works and everything. But I started feeling the drawbacks of jass itself, having tiny lags between actions like 0.05 seconds. During massive Cancel presses (like 30 or more unconfirmed points) it's even more present, maybe even 0.3-1 seconds or so.

The reason behind this could also be the amount of links (they are inefficient right now due to adding them just earlier and didn't optimize them, they also require some recursive calls due to how update works)

Confirming 30+ points doesn't make a delay however.
The "5 points per row" would have to be implemented through requirements.

In any case, I'm quite pleased how it works, in singleplayer it shouldn't be any trouble, and for few points here and there, shouldn't be any delay.
I have yet to start optimizing so I'll see how much performance I can get out of it.

I'm open to any questions.

 

[SpasMaster]

This is looking better and better by the minute!

Would you mind attaching this version of yours with the Druid example to your post to mess with and explore?

Aside from that, personally, I feel like you could have the system display by default the maximum points that can be put into a talent (eg; 0/5), just like how it is in your Druid example and unlike how it currently is by default where it just shows the current points.

 

[The_Spellweaver]

This is looking better and better by the minute!

Would you mind attaching this version of yours with the Druid example to your post to mess with and explore?

Aside from that, personally, I feel like you could have the system display by default the maximum points that can be put into a talent (eg; 0/5), just like how it is in your Druid example and unlike how it currently is by default where it just shows the current points.

Thank you

I will attach this version when I've cleaned it up a bit. In this version I'm importing talent tree frames from RUID output although modified a bit, and using a configured Talent (button etc) views in an easy to change form. So I would like clean examples of that to be available too.

I can leave the current/maximum rank showing as default, though because it's dependency injected, one can always switch between the two view generating functions.

I've played around a bit with the performance and it seems Cancel is the biggest culprit and I'll see how to resolve it. I've kind of fixed the micro delay on putting points by delaying the update with a timer, but Cancel is so ingrained in the system that it'll be hard to delay it without messing up the system code.

I'll see what I can do ^^

Edit:
It seems the Cancel was causing lag cause the talent trees kept redrawing themselves every time Talent Points changed (which is a LOT during Cancel).
I've extracted the redraw logic to the outside of the viewmodel, so I'm passing an onViewUpdate that will update the views in a different trigger context (using a timer)

 

[FlameofChange]

What a lovely system, even if I found League of Legends and World of Warcraft heresy.
However I won't be of any technical advice, since it's a bit out of my league.

 

[Kick King]

Any chance you could port this to typescript or lua??

 

[The_Spellweaver]

Any chance you could port this to typescript or lua??

I have a typescript version which I wrote this one from, but I didn't publish it cause there was no interest. Also there's a very early lua version of it somewhere in the code lab.

In any case, publishing it would require some cleaning, making examples etc.

I'll gladly share it if anyone's ready to play around with it.

 

[Kick King]

I would have A LOT of interest in a typescript version. This is exactly the type of system I'm looking for in my thing and everything is in typescript already. One thing I haven't spent any time in is custom UI stuff so this would save me a ton of time.

 

[Coldgamer]

This my friend is absolut amazing! Ty for the druid example!

Edit: Little question aside, how could I make like in wow a requirment of points set in a line? For example u have to set 5 points overall to unlock the 2nd line, 10 points to unlock the 3rd line and so on

 

[The_Spellweaver]

This my friend is absolut amazing! Ty for the druid example!

Edit: Little question aside, how could I make like in wow a requirment of points set in a line? For example u have to set 5 points overall to unlock the 2nd line, 10 points to unlock the 3rd line and so on

Hey,
well you would do it using the Requirements functionality. Make a function that calculates minimum points based on row of that talent, then return an error if it's lower than necessary. I can help if you need, you can find me on discord.

Good luck!

 

[Ugabunda]

This looks amazing. Are you considering doing a GUI version?

 

[SmitingDevil]

You can't access functions for frames in GUI, so most of the backbone code would be in custom script either way.

A GUI configuration would be possible with those set and get functions. And perhaps using real variables or triggers for events.

 

[The_Spellweaver]

This looks amazing. Are you considering doing a GUI version?

Not any time soon, but I was considering/planning to make it possible to define talent trees in GUI, it would look something like this

• Run trigger CreateTalentTree
• // Talent 1
• set variable TalentName = "Blah"
• set variable TalentDescription = "Does this and that"
• set variable OnActivate = Some GUI Trigger
• set variable TalentCost = 2
• set variable TalentX = 1
• set variable TalentY = 2
• Run trigger AddTalent
• // Talent 2
• set variable TalentName = "Blah2"
• set variable TalentDescription = "Does this and that"
• set variable OnActivate = Some other GUI Trigger
• set variable TalentCost = 2
• set variable TalentX = 1
• set variable TalentY = 3
• Run trigger AddTalent

Since that's the actual part where you "use" the system is by creating talent trees, and using the system should be easy.
But I don't intend on making the system customizable from GUI because the system itself is quite complex and it would do good for people to know code if they wanted to play around with how it works.

 

[Coldgamer]

This looks amazing. Are you considering doing a GUI version?

I mostly also use GUI but take a look at the examples (especially the druid examp), in my opinion they are so easy to read/reproduce, even I could use this system

 

[The_Spellweaver]

I mostly also use GUI but take a look at the examples (especially the druid examp), in my opinion they are so easy to read/reproduce, even I could use this system

Hey! That's the goal, at least out of the box, it should be clear, readable and easy to work with, regardless if you're an experienced coder or a casual GUI user.

Thanks :3

 

[MatiasPalacios]

This work on Multiplayer?

 

[The_Spellweaver]

This work on Multiplayer?

Of course, it should. There's no point in it otherwise

 

[Lt_Hawkeye]

Is it possible using this system to have a specific talent point type per talent tree?

 

[The_Spellweaver]

Is it possible using this system to have a specific talent point type per talent tree?

Yes, in fact that's the default behavior. I had to change the example code so it would work like in WoW. Are you checking out the jass or ts version?

I'm willing to give an example but only if you ask

 

[Lt_Hawkeye]

Yes, in fact that's the default behavior. I had to change the example code so it would work like in WoW. Are you checking out the jass or ts version?

I'm willing to give an example but only if you ask

Using the jass version, I see, I thought that wasn't the case due to the druid example showing the same talent point used for all three trees.

I also saw in the druid example, you manually set up the UI stuff? So will it be the case that if one were to want to change the background, one would need to manually do so using the UI natives? I'm not familar at all with the new UI natives.

 

[The_Spellweaver]

So will it be the case that if one were to want to change the background, one would need to manually do so using the UI natives?

You can definitely customize the way ui is rendered ("View" scripts) if you have the skills.

But if you only need to change the picture/background on the talent tree, then that's already part of the api. Check the druid example and see how it's done there

set this.backgroundImage = "balancebg.blp"

 

[Lt_Hawkeye]

Some suggestions to make this more versatile

1. Provide the ability to specific which talent tree and unit you wish to open for.
There are cases where a person may have multiple talent trees but not want them open at the same time.
For instance, an evolutionary tree would be fundamentally different from a ability talent tree.

2. Make the height and width of the talent tree configurable per talent tree.

 

[d3v1lk1n]

Hey this looks interesting, any chance to upload test map for non reforged users-1.31?
I tried porting it to test map but it crashes after 2 seconds in game.

 

[The_Spellweaver]

Hey, the jass or the typescript version? Because some natives I used might not be available in 1.31. I'll have to check. Sadly I haven't paid mind to backwards compatibility

 

[d3v1lk1n]

Hey, the jass or the typescript version? Because some natives I used might not be available in 1.31. I'll have to check. Sadly I haven't paid mind to backwards compatibility

The jass version.