Lumber Income via Upgrade

[Antares]

You want to put the configurable parts of your system into the header of your script as constants, such as

globals
    constant real INCOME_PER_LUMBER_MILL = 25
endglobals

That way, the user doesn't have to scour your code for the point of where to edit that number. This is not a problem for a script as small as this one, but it becomes a necessity if it grows.

The filter of using 100% health to determine whether the Lumber Mill is fully constructed is quite awkward. You can use

GetUnitAbilityLevel(structure, 'ABnP') == 0 //Ability Building in Progress

to determine whether a building is fully constructed.

Even with those fixes, this is a overly simple and specific system and I don't see a reason why someone looking for something like this wouldn't just write it themselves. For it to be approved, it needs to be more flexible or do something less basic.

Rejected

 

[domagatos]

You want to put the configurable parts of your system into the header of your script as constants, such as

globals
    constant real INCOME_PER_LUMBER_MILL = 25
endglobals

That way, the user doesn't have to scour your code for the point of where to edit that number. This is not a problem for a script as small as this one, but it becomes a necessity if it grows.

The filter of using 100% health to determine whether the Lumber Mill is fully constructed is quite awkward. You can use

GetUnitAbilityLevel(structure, 'ABnP') == 0 //Ability Building in Progress

to determine whether a building is fully constructed.

Even with those fixes, this is a overly simple and specific system and I don't see a reason why someone looking for something like this wouldn't just write it themselves. For it to be approved, it needs to be more flexible or do something less basic.

Rejected

thank you for the feedback @Antares!!

 

[Pyrogasm]

Isn't there a section for 'samples' and the like that would be appropriate for this, or am I having an old wc3c brain moment?

 

[Antares]

I'll try to get more moderators' opinions on this.

But I think @domagatos should post his or her code snippets in the Triggers & Scripts forum or in the hive discord modding channel to get feedback.

Sorry for rejecting both your resources. I don't want to discourage you from posting your code here on hive, but I think this is just the wrong section for them at the moment.

 

[domagatos]

I'll try to get more moderators' opinions on this.

But I think @domagatos should post his or her code snippets in the Triggers & Scripts forum or in the hive discord modding channel to get feedback.

Sorry for rejecting both your resources. I don't want to discourage you from posting your code here on hive, but I think this is just the wrong section for them at the moment.

I'am new to everything related to WE, and even more so on JASS, so sorry for any trouble here, and thank you for the consideration @Antares , I don't feel discouraged, you are just doing your part, I get that.

Also your tip on "GetUnitAbilityLevel(structure, 'ABnP') == 0 //Ability Building in Progress" is woking far better, thank you for that aswell!