UI-Custom Race System

[MyPad]

That would currently be beyond the scope of this system, given the initial difficulty I encountered setting this up. I might consider making such a system later on, but it will not inherently be a part of this system.

 

[Wrda]

I've only looked at the lua version yet, and wanted to give you a heads up of what I saw.

It displays an error when clicking on the frame to select the race. "Trying to read undeclared global : gg_snd_MouseClick1". (Used Debug Utils). Also: "Trying to read undeclared global : id" every time a unit enters the map (at least that's what it feels like). They don't look critical though.

local t = {...} assumes that the varargs are continuous and have no nil values between them. While most cases certainly will be continuous, I would prefer to be safe and use table.pack(...)

undefined function is comparing player slot state, and is called from CustomRace.initialization, which is therefore called on map initialization. It's said that such comparisons on map initalization can cause desync (although I don't think I've ever experienced this myself). Also startRaceSelection uses it.

Spoiler: Leak

    local function pauseAll()
        SuspendTimeOfDay(true)
        CustomRace.pauseFlag    = true
        CustomRace.pauseTrig    = CreateTrigger()
        TriggerAddCondition(CustomRace.pauseTrig, Condition(function()
            if CustomRace.pauseFlag then
                PauseUnit(GetTriggerUnit(), true)
            end
        end))      
        local rect, reg         = GetWorldBounds(), CreateRegion()
        RegionAddRect(reg, rect)
        TriggerRegisterEnterRegion(CustomRace.pauseTrig, reg, nil)

        local grp               = CreateGroup()
        GroupEnumUnitsInRect(grp, rect, nil)
        ForGroup(grp, function()
            PauseUnit(GetEnumUnit(), true)
        end)
        DestroyGroup(grp)
    end

rect is a one time leak at the moment.

Only internal.getKeyStructureCountEnum doesn't pass the parameter "id" when calling internal.getKeyStructureCountGroup while internal.getKeyStructureCount does. I suppose you wanted to avoid calling GetEnumPlayer() again as GetPlayerId(GetEnumPlayer()). But you could in fact just pass the player parameter and then use a local variable for the id. Feels less complicated that way.

internal.getForceSize doesn't look like it's being used anywhere in the system at the moment. I think
internal.getForceSizeEx should be renamed to internal.getForceSizeEnum just for consistency, since you've always been using Enum for groups or forces.
internal.registerAlliedVictory function looks incomplete? It doesn't use the parameter, nor the trigger is able to be executed anywhere.
The equivalent of GUI On Setup in pure lua code is one running their own function inside
CustomRaceSetup.createSetupHelper?

The system overall is pretty nice and very well put together.

 

[Wrda]

Spoiler: Lua Version

It displays an error when clicking on the frame to select the race. "Trying to read undeclared global : gg_snd_MouseClick1". (Used Debug Utils). Also: "Trying to read undeclared global : id" every time a unit enters the map (at least that's what it feels like). They don't look critical though.

local t = {...} assumes that the varargs are continuous and have no nil values between them. While most cases certainly will be continuous, I would prefer to be safe and use table.pack(...)

undefined function is comparing player slot state, and is called from CustomRace.initialization, which is therefore called on map initialization. It's said that such comparisons on map initalization can cause desync (although I don't think I've ever experienced this myself). Also startRaceSelection uses it.

Spoiler: Leak

    local function pauseAll()
        SuspendTimeOfDay(true)
        CustomRace.pauseFlag    = true
        CustomRace.pauseTrig    = CreateTrigger()
        TriggerAddCondition(CustomRace.pauseTrig, Condition(function()
            if CustomRace.pauseFlag then
                PauseUnit(GetTriggerUnit(), true)
            end
        end))  
        local rect, reg         = GetWorldBounds(), CreateRegion()
        RegionAddRect(reg, rect)
        TriggerRegisterEnterRegion(CustomRace.pauseTrig, reg, nil)

        local grp               = CreateGroup()
        GroupEnumUnitsInRect(grp, rect, nil)
        ForGroup(grp, function()
            PauseUnit(GetEnumUnit(), true)
        end)
        DestroyGroup(grp)
    end

rect is a one time leak at the moment.

Only internal.getKeyStructureCountEnum doesn't pass the parameter "id" when calling internal.getKeyStructureCountGroup while internal.getKeyStructureCount does. I suppose you wanted to avoid calling GetEnumPlayer() again as GetPlayerId(GetEnumPlayer()). But you could in fact just pass the player parameter and then use a local variable for the id. Feels less complicated that way.

internal.getForceSize doesn't look like it's being used anywhere in the system at the moment. I think
internal.getForceSizeEx should be renamed to internal.getForceSizeEnum just for consistency, since you've always been using Enum for groups or forces.
internal.registerAlliedVictory function looks incomplete? It doesn't use the parameter, nor the trigger is able to be executed anywhere.

Spoiler: JASS Version

I believe the boolexpr will still leak if a new trigger is created.

Spoiler: Custom Race Core - Leak

    method defSetup takes code setupfunc returns nothing
        if this.setupTrig != null then
            call DestroyTrigger(this.setupTrig)
        endif
        set this.setupTrig      = CreateTrigger()
        call TriggerAddCondition(this.setupTrig, Condition(setupfunc))
    endmethod

    method defAISetup takes code setupfunc returns nothing
        if this.setupTrigAI != null then
            call DestroyTrigger(this.setupTrigAI)
        endif
        set this.setupTrigAI    = CreateTrigger()
        call TriggerAddCondition(this.setupTrigAI, Condition(setupfunc))
    endmethod

Note: static method warningReady is currently unused.

Spoiler: Reference Leak

private function IsPlayerOpponent takes integer id, integer opID returns boolean
    local player thePlayer      = Player(id)
    local player theOpponent    = Player(opID)
    // The player himself is not an opponent.
    // Players that aren't playing aren't opponents.
    // Neither are players that are already defeated.
    if (id == opID) or /*
    */ (GetPlayerSlotState(theOpponent) != PLAYER_SLOT_STATE_PLAYING) or /*
    */ (bj_meleeDefeated[opID]) then
        return false
    endif
    // Allied players with allied victory set are not opponents.
    if (GetPlayerAlliance(thePlayer, theOpponent, ALLIANCE_PASSIVE)) and /*
    */ (GetPlayerAlliance(theOpponent, thePlayer, ALLIANCE_PASSIVE)) and /*
    */ (GetPlayerState(thePlayer, PLAYER_STATE_ALLIED_VICTORY) == 1) and /*
    */ (GetPlayerState(theOpponent, PLAYER_STATE_ALLIED_VICTORY) == 1) then
        return false
    endif
    return true
endfunction

There are other leaks of this type in CustomRaceMatchConditions library, such as
TeamGainControl, OnEnumAllyStructureCount and OnStructureDeath, to name a few.
CustomRaceMatch, CustomRaceObserverUI, CustomRaceUserUI
libraries also have some.

private function EaseOutResponse takes real x returns real
    return (x*(x*(x*(x*(0.20*x-0.55)+0.47)-0.1))) / 0.02
endfunction

Where are these numbers coming from?

Bug in Lua version (attached file)
Happened if I focused on the Warcraft instance that was the host during the countdown and loading screen.

I was unable to get both players choice for custom race. Only the 2nd one has the frame options.
The Lua version compared to the JASS one looks incomplete, as in, there's no progress bar and no icons of the techtree.
It works well and has no performance issues and I like the frame interpolation of the JASS version. However, that bug hesitates me to approve the resource.
I think it's safer to fix that first.

 

[FlameofChange]

Spoiler

I was messing around with the disposition (since the default is clumsy at best), but it is very difficult to customize it. When changing the size of elements it dilates the content instead of keeping their right size.
When I add the number of chunks to 3, the techtree icon lists expands but doesn't show heroes. Is it normal ?