Level up hero using JASS

FRENGERS · Apr 11, 2016

JASS:

scope Level initializer Pick
    globals
        private constant player PLAYER = Player(0)
    endglobals
    private function Okay takes nothing returns nothing
        call SetHeroLevelBJ(GetEnumUnit(), (GetHeroLevel(GetEnumUnit()) +1), false)
    endfunction
    private function Pick takes nothing returns nothing
        call ForGroupBJ(GetUnitsOfPlayerAll(PLAYER), function Okay)
    endfunction
    private function Level takes nothing returns nothing
        local trigger THIS = CreateTrigger()
        call TriggerRegisterPlayerChatEvent(THIS, PLAYER, "-lvl", true)
        call TriggerAddAction(THIS, function Pick)
    endfunction
endscope

I need a system that could level up selected hero by 1 level.
I did my code with little functions.

Arad MNK · Apr 11, 2016

Leaking references, BJ's, Bad naming conventions, ugh.

What's your point? Is this a resource or something -__-

IcemanBo · Apr 11, 2016

Should be initializer Level.

Please always try to state a clear question, and point out what is not working.

FRENGERS · Apr 11, 2016

Arad MNK said:
Leaking references, BJ's, Bad naming conventions, ugh.

What's your point? Is this a resource or something -__-

I need help, need to make it something like that

IcemanBo said:
Should be initializer Level.

Please always try to state a clear question, and point out what is not working.

I'm bad at english, I'm stupid.
if I initialize Level, it'll level up at 1 second :/ :/
I just want when player chat "-lvl" it'll level up by 1 level

IcemanBo · Apr 11, 2016

Why would it?
I recommend you to use GUI.

Dehua_Darbuya · Apr 11, 2016

I'm not proficient in vJass so if someone with more experience can correct the following code, please don't hesitate to do so! Not sure if the local trigger needs to be nulled in vJass or if it takes care of itself. My Vanilla Jass version should run though; I fixed all the BJs except the unit group ones and cleaned up a few other things. It's not much of a system but it gets the job done.

JASS:

scope HeroLevelUp initializer Hero_Level
    private function Hero_Check takes nothing returns nothing
        call SetHeroLevel(GetEnumUnit(), (GetHeroLevel(GetEnumUnit())+1), false)
    endfunction

    private function Hero_Pick takes nothing returns boolean
        call ForGroup(GetUnitsOfPlayerAll(GetTriggerPlayer(), function Hero_Check)
        return false
    endfunction

    private function Hero_Level takes nothing returns nothing
        local trigger t = CreateTrigger()
        call TriggerRegisterPlayerChatEvent(t, Player(0), "-lvlup", true)
        call TriggerAddCondition(t, Condition(function Pick))
        set t = null
    endfunction
endscope

JASS:

function Hero_Check takes nothing returns boolean
    return IsUnitType(GetFilterUnit(), UNIT_TYPE_HERO) == true
endfunction
                                          
function Hero_Up takes nothing returns nothing
    call SetHeroLevel( GetEnumUnit(), GetHeroLevel(GetEnumUnit())+1, false )
endfunction

function Hero_Pick takes nothing returns boolean
    local group heroes = GetUnitsOfPlayerMatching(GetTriggerPlayer(), Condition(function Hero_Check))
    call ForGroup(heroes, function Hero_Up)
    call DestroyGroup(heroes)
    set heroes = null
    return false
endfunction

//===========================================================================
function InitTrig_Hero_Level_Up takes nothing returns nothing
    local trigger t = CreateTrigger(  )
    call TriggerRegisterPlayerChatEvent( t, Player(0), "-lvlup", true )
    call TriggerAddCondition( t, Condition(function Hero_Pick) )
    set t = null
endfunction

FRENGERS · Apr 11, 2016

IcemanBo said:
Why would it?
I recommend you to use GUI.

Sorry, can't.

Dehua_Darbuya said:

I'm not proficient in vJass so if someone with more experience can correct the following code, please don't hesitate to do so! Not sure if the local trigger needs to be nulled in vJass or if it takes care of itself. My Vanilla Jass version should run though; I fixed all the BJs except the unit group ones and cleaned up a few other things. It's not much of a system but it gets the job done.

JASS:

scope HeroLevelUp initializer Hero_Level
    private function Hero_Check takes nothing returns nothing
        call SetHeroLevel(GetEnumUnit(), (GetHeroLevel(GetEnumUnit())+1), false)
    endfunction

    private function Hero_Pick takes nothing returns boolean
        call ForGroup(GetUnitsOfPlayerAll(GetTriggerPlayer(), function Hero_Check)
        return false
    endfunction

    private function Hero_Level takes nothing returns nothing
        local trigger t = CreateTrigger()
        call TriggerRegisterPlayerChatEvent(t, Player(0), "-lvlup", true)
        call TriggerAddCondition(t, Condition(function Pick))
        set t = null
    endfunction
endscope

JASS:

function Hero_Check takes nothing returns boolean
    return IsUnitType(GetFilterUnit(), UNIT_TYPE_HERO) == true
endfunction
                                          
function Hero_Up takes nothing returns nothing
    call SetHeroLevel( GetEnumUnit(), GetHeroLevel(GetEnumUnit())+1, false )
endfunction

function Hero_Pick takes nothing returns boolean
    local group heroes = GetUnitsOfPlayerMatching(GetTriggerPlayer(), Condition(function Hero_Check))
    call ForGroup(heroes, function Hero_Up)
    call DestroyGroup(heroes)
    set heroes = null
    return false
endfunction

//===========================================================================
function InitTrig_Hero_Level_Up takes nothing returns nothing
    local trigger t = CreateTrigger(  )
    call TriggerRegisterPlayerChatEvent( t, Player(0), "-lvlup", true )
    call TriggerAddCondition( t, Condition(function Hero_Pick) )
    set t = null
endfunction

Thanks, trying...
EDIT:

WOW, you did it!
thank you so much
+REP

IcemanBo · Apr 11, 2016

Why you can't use GUI?

FRENGERS · Apr 11, 2016

IcemanBo said:
Why you can't use GUI?

It's not cool dude.

IcemanBo · Apr 11, 2016

If one lacks basic knowledge, then GUI is "cool" enough.

The vJASS version does leak and does not filter for hero typed units.

The JASS version is implemented better, but the implementation does not really differ much from plain GUI.

Here are some tutorials, if you insist to write code in JASS: http://www.hiveworkshop.com/forums/miscellaneous-tutorials-456/elemental-coder-guide-274346/

Bribe · Apr 11, 2016

GUI is awesome for some simple things and even complex things if you know to use custom script when needed. This is a simple thing. JASS should be reserved for times when it is too custom-script heavy or takes too long in GUI.

FRENGERS · Apr 12, 2016

IcemanBo said:
If one lacks basic knowledge, then GUI is "cool" enough.

The vJASS version does leak and does not filter for hero typed units.

The JASS version is implemented better, but the implementation does not really differ much from plain GUI.

Here are some tutorials, if you insist to write code in JASS: http://www.hiveworkshop.com/forums/miscellaneous-tutorials-456/elemental-coder-guide-274346/

Thanks

Bribe said:
GUI is awesome for some simple things and even complex things if you know to use custom script when needed. This is a simple thing. JASS should be reserved for times when it is too custom-script heavy or takes too long in GUI.

Alright then.

Arad MNK · Apr 12, 2016

vJASS is used for complex and often hypothetical situations when there is no hope, it's not for being "cool".

GUI is probably what you currently need; it's pretty fine for what you currently need.

Dehua_Darbuya · Apr 12, 2016

IcemanBo said:
If one lacks basic knowledge, then GUI is "cool" enough.

The vJASS version does leak and does not filter for hero typed units.

The JASS version is implemented better, but the implementation does not really differ much from plain GUI.

Here are some tutorials, if you insist to write code in JASS: http://www.hiveworkshop.com/forums/miscellaneous-tutorials-456/elemental-coder-guide-274346/

If I could just hijack this thread for a moment,

Yes, the Jass version is a slightly more efficient GUI equivalent.
Forgot about the Hero-type check in the vJass version.
In what way does that same trigger leak?

Cheers.

IcemanBo · Apr 12, 2016

In the vJass version the creted group isn't destroyed.

Dehua_Darbuya · Apr 12, 2016

Wow, can't believe I kept missing that! Thanks Bo!

FRENGERS · Apr 12, 2016

Arad MNK said:
vJASS is used for complex and often hypothetical situations when there is no hope, it's not for being "cool".

GUI is probably what you currently need; it's pretty fine for what you currently need.

I won't, I currently learning JASS / vJASS

Dehua_Darbuya said:
If I could just hijack this thread for a moment,

Yes, the Jass version is a slightly more efficient GUI equivalent.

Forgot about the Hero-type check in the vJass version.

In what way does that same trigger leak?

Cheers.

Dehua_Darbuya said:
Wow, can't believe I kept missing that! Thanks Bo!

Alright.

Wrda · Apr 13, 2016

Wait, didn't want the trigger to level up a selected hero? This one will level alll heroes of a player.

I won't, I currently learning JASS / vJASS

So you are learning GUI. GUI is JASS but JASS isn't GUI.
Seriously what makes me more annoyed is the fact that people try to code in vJASS because it is "cool" and makes people think they are the best while writing in a complex script. In fact, I hate it because if you take a look at some systems out there you will see many library requirements and those libraries require others which makes trigger editor a big mess. I would only use it as a last resort or if it doesn't require anything. Even with GUI people can make complex things than in vJASS, just take a look at bribe's DDS, that's splendid work. Not only GUI is faster to work with but also is easier to work with because you can do simple things faster.

FRENGERS · Apr 13, 2016

Wrda said:
Wait, didn't want the trigger to level up a selected hero? This one will level alll heroes of a player.

So you are learning GUI. GUI is JASS but JASS isn't GUI.
Seriously what makes me more annoyed is the fact that people try to code in vJASS because it is "cool" and makes people think they are the best while writing in a complex script. In fact, I hate it because if you take a look at some systems out there you will see many library requirements and those libraries require others which makes trigger editor a big mess. I would only use it as a last resort or if it doesn't require anything. Even with GUI people can make complex things than in vJASS, just take a look at bribe's DDS, that's splendid work. Not only GUI is faster to work with but also is easier to work with because you can do simple things faster.

Well it's alright for me.
No, I want it to level up selected Hero (if you can)
All hero level up is an optional choice.

Dehua_Darbuya · Apr 14, 2016

Wrda said:
Wait, didn't want the trigger to level up a selected hero? This one will level all heroes of a player.

I know. The codes I provided were MPI because I assumed that this was for an AoS-type map. Besides it wouldn't take much effort in adjusting the code to make it level up only the selected Hero.

FRENGERS said:
Well it's alright for me.
No, I want it to level up selected Hero (if you can)
All hero level up is an optional choice.

If there is only 1 Hero per player, then the codes should be fine. Otherwise I could edit them so that they're MUI. I have to leave soon though, so if someone else wants to do it, then by all means go ahead. You could even try it yourself Frengers!

FRENGERS · Apr 14, 2016

Dehua_Darbuya said:
I know. The codes I provided were MPI because I assumed that this was for an AoS-type map. Besides it wouldn't take much effort in adjusting the code to make it level up only the selected Hero.

If there is only 1 Hero per player, then the codes should be fine. Otherwise I could edit them so that they're MUI. I have to leave soon though, so if someone else wants to do it, then by all means go ahead. You could even try it yourself Frengers!

It has more than one hero

Wietlol · Apr 15, 2016

LevelUp Command
- Events
  - Player - Player 1 (Red) types a chat message containing /levelup as An exact match
  - Player - Player 2 (Blue) types a chat message containing /levelup as An exact match
  - Player - Player 3 (Teal) types a chat message containing /levelup as An exact match
  - Etc...
- Conditions
- Actions
  - Set TempGroups[0] = (Units currently selected by (Triggering player))
  - Unit Group - Pick every unit in TempGroups[0] and do (Actions)
    - Loop - Actions
      - Set TempUnits[0] = (Picked unit)
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        (TempUnits[0] is A Hero) Equal to True
        
        Then - Actions
        
        Hero - Set TempUnits[0] Hero-level to ((Hero level of TempUnits[0]) + 1), Show level-up graphics
        
        Else - Actions
  - Custom script: call DestroyGroup(udg_TempGroups[0])

This trigger will levelup all selected heroes.
You can add a check that the owner of the selected unit is equal to the triggering player, but that is merely optional.

There is no drawback from using GUI in this case except hyper-efficiency and the events (they can be made easily as generic player writes a string in JASS).
Maybe the reputation as scripter is at stake but I doubt that anyone except yourself cares.

FRENGERS · Apr 15, 2016

Wietlol said:
LevelUp Command

Events

Player - Player 1 (Red) types a chat message containing /levelup as An exact match

Player - Player 2 (Blue) types a chat message containing /levelup as An exact match

Player - Player 3 (Teal) types a chat message containing /levelup as An exact match

Etc...

Conditions

Actions

Set TempGroups[0] = (Units currently selected by (Triggering player))

Unit Group - Pick every unit in TempGroups[0] and do (Actions)

Loop - Actions

Set TempUnits[0] = (Picked unit)

If (All Conditions are True) then do (Then Actions) else do (Else Actions)

If - Conditions

(TempUnits[0] is A Hero) Equal to True

Then - Actions

Hero - Set TempUnits[0] Hero-level to ((Hero level of TempUnits[0]) + 1), Show level-up graphics

Else - Actions

Custom script: call DestroyGroup(udg_TempGroups[0])

This trigger will levelup all selected heroes.
You can add a check that the owner of the selected unit is equal to the triggering player, but that is merely optional.

There is no drawback from using GUI in this case except hyper-efficiency and the events (they can be made easily as generic player writes a string in JASS).
Maybe the reputation as scripter is at stake but I doubt that anyone except yourself cares.

It's been solved, but is my code above optimal??

Wietlol · Apr 15, 2016

"No, I want it to level up selected Hero (if you can)"
Optimal is hard to say in programming.
But good enough is something that both are in this case.

FRENGERS · Apr 15, 2016

Wietlol said:
"No, I want it to level up selected Hero (if you can)"
Optimal is hard to say in programming.
But good enough is something that both are in this case.

I mean, does it lacking?? (check every 0.1 second)

Wietlol · Apr 15, 2016

lagging or leaking?
Neither.
Also, you dont check it every 0.1 second.
You check it every time you write /levelup... which you cant write 10 times a second.

FRENGERS · Apr 15, 2016

Wietlol said:
lagging or leaking?
Neither.
Also, you dont check it every 0.1 second.
You check it every time you write /levelup... which you cant write 10 times a second.

oh lol sorry, didn't post it
It's HERE

Wietlol · Apr 15, 2016

Well... first of all, that is definately not what this thread was about.
Secondly, you leak a unit group of all units on the map per 0.1 interval... which is horrible to even think about.
And next to that, I assume that you are spamming creep respawns as soon as someone dies... I assume that that is not how it is supposed to be in every single way that I can see your code.

FRENGERS · Apr 15, 2016

Wietlol said:
Well... first of all, that is definately not what this thread was about.
Secondly, you leak a unit group of all units on the map per 0.1 interval... which is horrible to even think about.
And next to that, I assume that you are spamming creep respawns as soon as someone dies... I assume that that is not how it is supposed to be in every single way that I can see your code.

haha yeah, wrong topic. Sorry.
I was not focus, I think you were commenting on those thread, but it's not haha.
lol

Now, how about this??
This works, but I dunno if there's any lacking :/ :/

JASS:

call TriggerRegisterAnyUnitEventBJ(THIS, EVENT_PLAYER_UNIT_DEATH)

Wietlol · Apr 15, 2016

I dont know how the system should be used but I assume that you shouldnt group all units in the entire map.

Just do the Go function as action of the trigger and use the death event indeed.

At least that is my guess.

FRENGERS · Apr 15, 2016

Wietlol said:
I dont know how the system should be used but I assume that you shouldnt group all units in the entire map.

Just do the Go function as action of the trigger and use the death event indeed.

At least that is my guess.

Alright, that makes sense now.
I used those current code and I got this result: sometimes the hero won't revive.

Level up hero using JASS

Similar threads