[JASS] jass trigger not working

[Cheshire]

hey,

this is my first trigger in jass. it doesn't have any traceback malfunctions, but for some reason it just does absolutely nothing in game. what did I do wrong here?

function taken_conditions takes nothing returns boolean
    if (GetManipulatedItem() == udg_Bait ) then
    call BJDebugMsg("item moved")
    //call DisplayTextToForce( GetPlayersAll(), "moved" )
        return true
    endif
    call BJDebugMsg("not item?")
    //call DisplayTextToForce( GetPlayersAll(), "not?" )
    return false
endfunction


function taken_actions takes nothing returns nothing
    call BJDebugMsg("got trig unit")
    set udg_Carrier = GetTriggerUnit()
    if (IsTriggerEnabled(gg_trg_ChaseLoop) == false) then
    call EnableTrigger(gg_trg_ChaseLoop)
    endif
endfunction


function InitTrig_taken takes nothing returns nothing
    local trigger taken = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(taken,EVENT_PLAYER_UNIT_PICKUP_ITEM)
    call TriggerAddCondition(taken,Condition(function taken_conditions))
    call TriggerAddAction(taken,function taken_actions)
endfunction

thanks...

obv there are more parts to it, but it doesn't even show the debug stuff here that shouldn't be dependant on anything else...

 

[Dr Super Good]

Make sure InitTrig_taken is being run. If that function never gets called, either due to missing a call to it or due to the caller suffering a thread crash before it can make the call, then no other parts of the trigger will run.

 

[Cheshire]

I picked up the item with a unit. doesn't that call the function?

 

[Dr Super Good]

I picked up the item with a unit. shouldn't that make it run?

The InitTrig_taken function seems as if it should run when the map is being initialized as it is responsible for creating the trigger and associated events, conditions and actions. If it does not get called once then all other functions are effectively unreachable and cannot ever be run unless called by some other script.

 

[Cheshire]

The InitTrig_taken function seems as if it should run when the map is being initialized as it is responsible for creating the trigger and associated events, conditions and actions. If it does not get called once then all other functions are effectively unreachable and cannot ever be run unless called by some other script.

do I need to add something to make that initialize? I thought that calling it "InitTrig", does that automatically...

 

[GIMLI_2]

do I need to add something to make that initialize? I thought that calling it "InitTrig", does that automatically...

This requires an equal function and trigger name.
Basically you need to call your trigger "taken"

 

[Dr Super Good]

do I need to add something to make that initialize? I thought that calling it "InitTrig", does that automatically...

At the bottom of the custom script window there should be a field to specific initial function name to call. This was the case with JNGP and WEX long ago.

Otherwise you can use vJASS library or scope features to achieve something similar. Declare the library with the appropriate initialization function to call at map initialization.

 

[Cheshire]

This requires an equal function and trigger name.
Basically you need to call your trigger "taken"

so, change that line from:

'function InitTrig_taken takes nothing returns nothing'

to:

'function taken takes nothing returns nothing'?

 

[Cheshire]

At the bottom of the custom script window there should be a field to specific initial function name to call. This was the case with JNGP and WEX long ago.

Otherwise you can use vJASS library or scope features to achieve something similar. Declare the library with the appropriate initialization function to call at map initialization.

oh. I just have all of my jass "triggers" the same way I had GUI. just seperate trigger tabs in the editor. somehow I don't think the jass tutorial I read covered this...

and I'm not sure where I'm supposed to find "a field to specific initial function name to call"... are you talking about in the trigger editor of the WE or in the text editor (I'm using jasscraft)...?

 

[GIMLI_2]

so, change that line from:

'function InitTrig_taken takes nothing returns nothing'

to:

'function taken takes nothing returns nothing'?

No,
whenever you create a trigger, you have to give it a certain name, right?

For example "My Spell"

Now, if you want a function of this trigger to run on map init, you need to call the function InitTrig_My_Spell

 

[Cheshire]

No,
whenever you create a trigger, you have to give it a certain name, right?

For example "My Spell"

Now, if you want a function of this trigger to run on map init, you need to call the function InitTrig_My_Spell

sorry for being thick, but I still don't get it. isn't that line where I defined the name of that trigger? where else would I write it?

 

[GIMLI_2]

Think about creating a GUI trigger. You open the trigger editor, and create a new trigger which has event/conditions/actions. Now, you usually give it some name.

This is what i mean by trigger name. Now we are in jass, so if you want a function of that trigger to run at init, you need to give it the name InitTrig_TRIGGERNAME, you just need to replace placeholders with underscores

Example:

Trigger with the name "Thunder Clap"

function foo takes nothing returns nothing
call BJDebugMsg("foo")
endfunction

// runs at map init
function InitTrig_Thunder_Clap takes nothing returns nothing
call BJDebugMsg("init")
endfunction

 

[Cheshire]

If you mean the name of the tab in the trigger editor, it is "taken" and was to begin with, but it is defined as "custom script", and not as a trigger. does that matter?

 

[GIMLI_2]

That is probably the issue, it has to be a trigger

 

[Cheshire]

thanks! that seems to have done it. Is that the normal way to write maps in jass, with converted triggers, or is there a better more cohesive and fluid way that is the norm?

and do triggers with other suffixes act differently in this respect? (i.e. gg_trg etc')

 

[GIMLI_2]

I do only use "converted" triggers, but i never use the InitTrig_ prefix to initialize.
As DSG mentioned, you can use library/scope/struct initializer when using vJass.

library l initializer init

    private function init takes nothing returns nothing
        // runs on map init
    endfunction
  
endlibrary

scope s initializer init

    private function init takes nothing returns nothing
        // runs on map init
    endfunction
  
endscope

struct s

    method onInit takes nothing returns nothing
        // runs on map init
    endmethod

endstruct

 

[Cheshire]

I do only use "converted" triggers, but i never use the InitTrig_ prefix to initialize.
As DSG mentioned, you can use library/scope/struct initializer when using vJass.

Isn't vjass something different then jass? I think I'm just using regular jass...

 

[GIMLI_2]

jass is natural to wc3, while vJass is more like.. an extension to jass. It allows additional keywords, but everything else is basically the same.
If you use the newest patch of wc3, vJass is implemented anyways.

 

[Cheshire]

So in reforged all maps are using vjass anyways... cool. thanks, that really helps!

 

[Cheshire]

1. when you use a library for initialization, do you only need to stick the function of the initialization inside of it, or all related code (i.e. the condition and action functions of the trigger)?

2. Do I need to change the way I have been writing functions in order to have them in libraries, or just stick the word "private" at the beginning?

If you can point me in the direction of a relevant tutorial on libraries that would be great too, I couldn't find anything that specifies on vjass libraries...

thanks!

 

[GIMLI_2]

1. You dont need to put all related code into the library, but i would suggest it. See it as a wrapper for your trigger.
2. No, you dont even have to make them private. Private keyword means, that the function is not visible outside the library. So you can call the function ONLY inside the library.
Private keyword is very important to protect your stuff from wrong usage.

You can take a look at the JassHelper Manual: WC3 Modding Information Center - VJASS Documentation