is there a way to repair buildings damaged by saving the map

[andreasaspenberg]

in my faction war project i have saved a lot of times and custom buildings have started to degrade to the point where they crash the game when built. is there a way to fix the problem other than creating them from scratch?

 

[Wolf_Wing]

did mean you build the building but the building was ready for use??

 

[andreasaspenberg]

in my maps i usually create custom stuff. in faction war however some of that custom stuff have started to degrade so that constructing them inside the game crash the game. is there a way to fix that.(the buildings did work originally but started crashing the game after saving the map after adding more stuff.)

 

[Dr Super Good]

Maybe it is the result of unexpected trigger interaction? Could you post the map with the problem?

 

[andreasaspenberg]

i dont mind posting the map. just dont get me flagged again.

 

[Dr Super Good]

just dont get me flagged again.

What do you mean by flagged?

(the buildings did work originally but started crashing the game after saving the map after adding more stuff.)

Could you give an example of such a building? I just played the outlaw humans and no crash occured.

 

[andreasaspenberg]

i got flagged as problematic after you responded to one of my topics, while you got demoted. try playing as the animals and build the barracks.

 

[Dr Super Good]

i got flagged as problematic after you responded to one of my topics, while you got demoted.

I do not think that had anything to do with me in particular.

try playing as the animals and build the barracks.

1. Choose animal race
2. Built Animal Barracks using Sheep Builder that was supplied to me
3. Game did not crash?!

If step 3 is a game crash for you then this problem has just become a lot more complicated. The crash would then be coupled to the execution environment in some way.

 

[andreasaspenberg]

i just posted the wrong map. this should be the right one.

 

[Dr Super Good]

The crash only happens when you select the barracks. The problem is with the requirements on some of the units that the barracks can build. When the barracks is selected it loads all the object data for the units it can build. When it gets to requirements of the units such as that on the Flying Sheep it crashes. If you remove all units that have requirements or remove all requirements from all units the barracks can train then the crash goes away.

The exact reason why the requirements are causing the crash needs more investigation still. I thought I would tell you my findings in the mean time incase they are of any help to you.

EDIT:
Seems that it is getting into an unrecoverable state when resolving the animal townhall as a requirement. Still trying to find out why.

EDIT 2:
Found it...
The [Techtree - Dependency Equivalents] field of the unit "Animal townhall level 3 sheep only" was set to a value resulting in the crash experienced. Clearing this field fixed all crashes with the Animal Barracks unit being selected.

 

[andreasaspenberg]

the crash did happen when it finished its construction as well. i have experienced a similar issue before though. when units are damaged in the map and appear on the build menu they might cause a crash. i once had to recreate a building because of that. i copied all of the data from the all building to the new one and it worked. a certain blacksmith also crash the game when it is on the build menu. your solution did however remove a part of the problem. there is however still issues present so i still need help. please help me out.

 

[Dr Super Good]

the crash did happen when it finished its construction as well.

No, I could do any number of stuff for as long as I wanted until I selected the building. As soon as I selected the animal barracks the game hanged and crashed.

there is however still issues present so i still need help. please help me out.

It is not present, I have built the animal barracks unit a large number of times after deploying my fix and no crash occurred. If there are still crashes then they are unrelated to that instance and will need to be dealt with separately. More specifically, you will need to tell me what problems still remain so I can look into them on a case-by-case basis as I have little knowledge about your map. There is no simple "fix it" button for these problems as these crashes are being caused by very specific and obscure engine bugs.

I advise treating each event that causes a crash as a separate problem. Some may be related to each other but knowing how to crash your map will be really useful when finding the problem causing the crash. Both object editor values (as I just shown) and triggers could be causing a crash so it is very important I can recreate such crashes easilly until I find the cause.

 

[andreasaspenberg]

seems that you didnt encounter the crash i encountered but a different crash.(the one i encountered didnt hang the game but just closed it.) please help me fix the other problems that i described. a certain blacksmith crash the game when it is on the build menu.(law blacksmith.) there could be other problems that i havent found yet though. i also need a solution to the data degradation problem or i will be forced to create buildings from scratch. please help me out.

 

[Dr Super Good]

i also need a solution to the data degradation problem or i will be forced to create buildings from scratch. please help me out.

There is no data degredation problem, as I just proved they are game engine bugs caused by silly values (which are hard to know about because WC3 makes no sense).

seems that you didnt encounter the crash i encountered but a different crash.(the one i encountered didnt hang the game but just closed it.)

That was the one I encountered. It would hang the game for about 3-5 frames and then close with no error or crash dialog.

please help me fix the other problems that i described. a certain blacksmith crash the game when it is on the build menu.(law blacksmith.)

Cannot find how to build such a building. I go humans/lawful and all I get is the normal blacksmith.

there could be other problems that i havent found yet though.

I can only fix what I know about.

EDIT:

 

[andreasaspenberg]

law and lawful is different factions but, i removed the blacksmith from the build menu as a workaround so you will need to add it back in. it worked at the start and none of the values got changed. it was the same with the elven building that crashed the game.(i recreated the building an copied over the old values and it worked perfectly.) the data degradation problem was in the starcraft campaign editor as well without any changes done to the building.(after saving there i couldnt upgrade to greater spire without it crashing and saving more times cause even more stuff to cause crashes.) please help me out and please dont explode so that i get flagged again.

 

[Dr Super Good]

(after saving there i couldnt upgrade to greater spire without it crashing and saving more times cause even more stuff to cause crashes.) please help me out and please dont explode so that i get flagged again.

I have never truely exploded. I was and still am a highly respected member of this community.

you will need to add it back in

I like spending more time trying to recreate the problems than fixing them...

Anyway the problem with the law smith is the requirement for the "village Hall Faction Choice". Something is wrong with that building that causes a game crash when resolving the requirements. To be more precise, something is wrong with the building it can upgrade into called "Town Hall good faction choice". Even more precise, something is wrong with the unit "Command Core faction choice". Still yet more precise, something is wrong with the unit "Vanguard from level 1 buildings".

To be exact, the problem is the unit "Vanguard from level 1 buildings". It is not a building yet you try to allow a building to upgrade into it. The WarCraft III game engine does not support this when it comes to resolving requirements and thus causes a game crash. If you change the unit "Command Core faction choice" to upgrade into something else (such as nothing or a unit that is a building and does not upgrade into something that cannot be resolved) you will see that the crash that occurs when resolving the requirements of "law blacksmith" disappears.

As a rough guess, any other crashes you are getting under the same conditions are a result of similar unresolvable requirements. To trace where the problem is you will need to find which building causes the crashes and then go up its upgrade path unit by unit. This can be done by testing each requirement separatly until the crash happens. Then you test each upgrade of that required unit separatly until the crash happens. Repeat up the chain until you reach the unit causing the crash.

Deleting and making a new copy of the unit will not make things magicly work. The crashes are caused by some requirement resolution problem due to the way the unit is configured. In the first case this was due to an equivelent dependiency. In law blacksmith case this was due to a building upgrading into a non-building.

it worked at the start and none of the values got changed. it was the same with the elven building that crashed the game.(i recreated the building an copied over the old values and it worked perfectly.) the data degradation problem was in the starcraft campaign editor as well without any changes done to the building.(

WarCraft III has no object editor degredation problems. The problems you are experiencing are game bugs caused by silly (as far as the game engine is concerned) values in object editor fields.

 

[andreasaspenberg]

buildings upgrading into units works perfectly. the animal barracks doesnt have any special values at all. i didnt actually delete the building i had problems with i believe. the new building had the same values as the old but the new one worked while the old one crashed the game. the command core doesnt crash the game an neither does the vanguard, what i had trouble with there was the resource system but it just didnt work as intended.