[General] How does VJASS remove one-time triggers.

[Tal'Rarity]

How do vjass'ers clean their one time triggers? Does endfunction do it for them?

 

[Ceday]

Are you talking about triggers which is like runs at map init, or when some time elapsed etc?

 

[Tal'Rarity]

Yeah

 

[edo494]

what do you mean by one time triggers?

 

[Tal'Rarity]

Map init or stuff similar, triggers that run once and that's it.

 

[edo494]

if you mean GUI "Map Initialization" triggers, it doesnt. If you mean initializer, they are not actually hooked to trigger, but injected into main, which runs when the map loads. function main also calls Init..., which calls the init functions for each separate GUI Trigger, shall there be one of course

 

[Ceday]

Nobody cares about clearing them much.

 

[Tal'Rarity]

if you mean GUI "Map Initialization" triggers, it doesnt. If you mean initializer, they are not actually hooked to trigger, but injected into main, which runs when the map loads. function main also calls Init..., which calls the init functions for each separate GUI Trigger, shall there be one of course

So the extra memory that sits there isn't cleaned?

Nobody cares about clearing them much.

They should. The memory limit isn't even 2GB before fatal/crash.

 

[Ceday]

You won't get to 500mb with leakless coding anyway.

 

[Tal'Rarity]

Your right however that isn't WC3.

It adds up quickly, and the memory doesn't get reduced unless the process is shut down or restarted. In WC3 there is no such thing as leakless coding, there is only Reduced leaks because there is stuff we don't have access too so it does matter to remove one-time triggers, every little bit helps. Especially considering you can crash even when not at the max memory limit of WC3 due to stuff overwriting its own stuff.

 

[Ceday]

Blah blah blah, when did you last time received a crash?

 

[Tal'Rarity]

Blah blah blah, when did you last time received a crash?

Yesterday

It happens quite often.

 

[Zeatherann]

The only reason to simplify and optimize the initialization functions is to get a faster start-up time for the map. The handful of bytes left over from such functions will never affect anything.

 

[Tal'Rarity]

They add onto the already amount of steady leaks created by everything else such as objects. Basically I learned VJASS'ers don't clean all their code.

I did want to know how VJASS cleans this however nobody wants to answer it. So please don't respond unless your responding to what the thread is about. No going off-topic please.

 

[edo494]

it is not JassHelper's responsibility to clear "Map Initialization" GUI Triggers. Its the responsibility of the creator of the map.

However code like:

struct s
    private static method onInit takes nothing returns nothing
        //code
    endmethod
endstruct

never leaks, because it is not run with trigger, but as I said, inside "main" function, which runs when map loads

Example of compiled code:

globals
    // Generated
trigger gg_trg_h= null


//JASSHelper struct globals:
constant integer si__s=1
integer si__s_F=0
integer si__s_I=0
integer array si__s_V

endglobals


//Generated allocator of s
function s__s__allocate takes nothing returns integer
 local integer this=si__s_F
    if (this!=0) then
        set si__s_F=si__s_V[this]
    else
        set si__s_I=si__s_I+1
        set this=si__s_I
    endif
    if (this>8190) then
        return 0
    endif

    set si__s_V[this]=-1
 return this
endfunction

//Generated destructor of s
function s__s_deallocate takes integer this returns nothing
    if this==null then
        return
    elseif (si__s_V[this]!=-1) then
        return
    endif
    set si__s_V[this]=si__s_F
    set si__s_F=this
endfunction

//===========================================================================
// 
// Just another Warcraft III map
// 
//   Warcraft III map script
//   Generated by the Warcraft III World Editor
//   Date: Mon Jul 07 20:33:10 2014
//   Map Author: Unknown
// 
//===========================================================================

//***************************************************************************
//*
//*  Global Variables
//*
//***************************************************************************


function InitGlobals takes nothing returns nothing
endfunction

//***************************************************************************
//*
//*  Triggers
//*
//***************************************************************************

//===========================================================================
// Trigger: h
//===========================================================================
//TESH.scrollpos=0
//TESH.alwaysfold=0
    function s__s_onInit takes nothing returns nothing
        //code
    endfunction
a//===========================================================================
function InitCustomTriggers takes nothing returns nothing
    //Function not found: call InitTrig_h()
endfunction

//***************************************************************************
//*
//*  Players
//*
//***************************************************************************

function InitCustomPlayerSlots takes nothing returns nothing

    // Player 0
    call SetPlayerStartLocation(Player(0), 0)
    call SetPlayerColor(Player(0), ConvertPlayerColor(0))
    call SetPlayerRacePreference(Player(0), RACE_PREF_HUMAN)
    call SetPlayerRaceSelectable(Player(0), true)
    call SetPlayerController(Player(0), MAP_CONTROL_USER)

endfunction

function InitCustomTeams takes nothing returns nothing
    // Force: TRIGSTR_002
    call SetPlayerTeam(Player(0), 0)

endfunction

//***************************************************************************
//*
//*  Main Initialization
//*
//***************************************************************************

//===========================================================================
function main takes nothing returns nothing
    call SetCameraBounds(- 3328.0 + GetCameraMargin(CAMERA_MARGIN_LEFT), - 3584.0 + GetCameraMargin(CAMERA_MARGIN_BOTTOM), 3328.0 - GetCameraMargin(CAMERA_MARGIN_RIGHT), 3072.0 - GetCameraMargin(CAMERA_MARGIN_TOP), - 3328.0 + GetCameraMargin(CAMERA_MARGIN_LEFT), 3072.0 - GetCameraMargin(CAMERA_MARGIN_TOP), 3328.0 - GetCameraMargin(CAMERA_MARGIN_RIGHT), - 3584.0 + GetCameraMargin(CAMERA_MARGIN_BOTTOM))
    call SetDayNightModels("Environment\\DNC\\DNCLordaeron\\DNCLordaeronTerrain\\DNCLordaeronTerrain.mdl", "Environment\\DNC\\DNCLordaeron\\DNCLordaeronUnit\\DNCLordaeronUnit.mdl")
    call NewSoundEnvironment("Default")
    call SetAmbientDaySound("LordaeronSummerDay")
    call SetAmbientNightSound("LordaeronSummerNight")
    call SetMapMusic("Music", true, 0)
    call InitBlizzard()

call ExecuteFunc("jasshelper__initstructs44332426")

    call InitGlobals()
    call InitCustomTriggers()

endfunction

//***************************************************************************
//*
//*  Map Configuration
//*
//***************************************************************************

function config takes nothing returns nothing
    call SetMapName("Just another Warcraft III map")
    call SetMapDescription("Nondescript")
    call SetPlayers(1)
    call SetTeams(1)
    call SetGamePlacement(MAP_PLACEMENT_USE_MAP_SETTINGS)

    call DefineStartLocation(0, - 1856.0, 832.0)

    // Player setup
    call InitCustomPlayerSlots()
    call SetPlayerSlotAvailable(Player(0), MAP_CONTROL_USER)
    call InitGenericPlayerSlots()
endfunction




//Struct method generated initializers/callers:

function jasshelper__initstructs44332426 takes nothing returns nothing


    call ExecuteFunc("s__s_onInit")
endfunction

As you see, JassHelper never spawns any trigger to run the initializers

 

[Tal'Rarity]

So the triggers are branches of main in vjass?

I see, thank you edo494.

 

[Zeatherann]

Wow, all those execute functions...