[JASS] Help with GetLocalPlayer() for masking effect

[bbfreak]

Hey guys,
I've seen lots of posts about the GetLocalPlayer() function. And I really want to use it for my map except im not quite the expert on JASS. Basically im making an underwater part of the map. And want to make a fog effect for one person. After doing lots of researching i found that it isnt possible to create an effect like this using GUI. (Which is what im good with) I know JASS is so much better which is why im going to be learning it over the summer. But this is bugging me so i thought i would ask you JASS experts for help.

Basically what I want to do is set an underwater effect on someone when they enter a region. I know how to set the variable to the player but then i need the code to assign the mask to that player or playergroup. Prefferably i would like it so it just assigns it to the player group so that i can enter/exit the players out of the group whenver i want.

The effect are this.

• Environment - Set fog to style Linear, z-start 10.00, z-end 5000.00, density 0.02 and color (5.00%, 70.00%, 100.00%)

It looks like it could be done in like 1 minute using JASS. So if any1 could help me make some JASS script basically making it so every player in a player group (You can call it UnderwaterPlayers) gets the effect. That would be so great! You will get credit in the map and it would be greatly apprectiated.

Thanks
-bbfreak

 

[PurgeandFire]

This may work, but it may cause a desync:

function test takes nothing returns nothing
    if GetLocalPlayer() == Player(0) then
        call SetTerrainFogEx( 0, 10.,5000.,0.02,5.,70.,100.)
    endif
endfunction

It might work better if you do this instead though:

function test takes nothing returns nothing
// Player 1 //
    call SetTerrainFogEx(0,10.,5000.,0.02,5.,70.,100.)
    call FogEnable(false)
    if GetLocalPlayer() == Player(0) then
        call FogEnable(true)
        return
    endif
// Player 2 //
    call SetTerrainFogEx(0,10.,4000.,0.04,10.,75.,35.)
    call FogEnable(false)
    if GetLocalPlayer() == Player(1) then
        call FogEnable(true)
        return
    endif
//etc.//
endfunction

I hope this helps!

 

[bbfreak]

That looks great. But is there anyway to make it so its a playergroup instead of every player individually? So i can turn the mask off when they surface. I dont know enough JASS to edit it myself

 

[Diablo-dk]

function SetFogForForce takes force f returns nothing
    local integer i=0
    local player p
    call SetTerrainFogEx(0, 10.00, 6000.00, 0.05, 7.00, 80.00, 100.00)
    call FogEnable(false)
    loop
        exitwhen i=12 // No need to take neutral players.
        set p=Player(i)
        if IsPlayerInForce(p, f)
            call FogEnable(GetLocalPlayer() == p )
        endif
        set i=i+1
    endloop
endfunction

I believe this would work.

 

[PurplePoot]

Would this work?

call FogEnable( IsPlayerInForce( GetLocalPlayer(), f ) )

I would think that it would work just as well as that loop.

Also, you leak a null (player).

 

[PurgeandFire]

Also, you leak a null (player).

Players do not need to be nulled.

@Diablo-dk:

Ermm... But I don't think that forces allow you to choose what exact players you want to show the fog for. Or am I wrong?

He wanted to be able to set fog for only one player, not a force.

 

[PurplePoot]

Players do not need to be nulled.

I haven't tested it directly, but what gave you that idea?

And if he wanted it single-player, it would be

call FogEnable( GetLocalPlayer() == somePlayer )

 

[bbfreak]

Ya i want it to be each player individual. So when they enter the region the effect is enabled for them only. And when they leave the region the effect is disabled for them only.

 

[PurplePoot]

Well then, just try

if GetLocalPlayer() == GetOwningPlayer( GetTriggerUnit() ) then
    call FogEnable( true )
endif

 

[PurgeandFire]

@Poot:

Straight-up Answer:

players do not need to be nulled

More explained answer but still not that much explained:

Anyway you only need to null variables that either are or will be destroyed at some point. This includes almost every type, but heroes (unless you remove them manually) and players are, for example, exceptions, they don't need to be nulled.
However, if it makes you feel safer, there is nothing wrong in nulling these as well.

So simply, I think that you don't need to null them, but it is ok to null them.

Got it?

EDIT: *LINK*:
Local variables and Leaks

 

[Diablo-dk]

I do think they have to be nulled(i usually do) just forgot to in that trigger. the reason why i didn't want to edit it was because each time i edit it the text gets un-indented.

 

[PurgeandFire]

I do think they have to be nulled(i usually do) just forgot to in that trigger. the reason why i didn't want to edit it was because each time i edit it the text gets un-indented.

Why do you think they have to be nulled? I'm just curious.

 

[PurplePoot]

Because they're handles, and it's generally said that handles have to be nulled.