Give Gold and / or Lumber System v 1.0.1.4

[Moderator]

15:56, 20th Aug 2013
PurgeandFire: Approved. Useful.

 

[Doomlord]

You can just combine this and the gold system instead of c'n'p the code (plus minor modifications) purely for the sake of resource count.

 

[deathismyfriend]

You can just combine this and the gold system instead of c'n'p the code (plus minor modifications) purely for the sake of resource count.

it wasnt for resource count. it was because they are 2 completely different systems. Yes the code is very much the same but not a lot of ppl want gold and lumber in the same system as some of them dont use lumber.

 

[Doomlord]

You can just make 2 triggers

 

[deathismyfriend]

ya i might as well combine it.

 

[Doomlord]

Nice to hear that then

 

[deathismyfriend]

Nice to hear that then

ya u were right lol. It was pointless to submit 2 resources for this.

 

[Chaosy]

I dont get it

How is it useful? You can add gold and lumber with the trigger action.

so how do this work

 

[deathismyfriend]

this isnt an add gold system. this is a give gold system.

It is preset to go by the command -giveGold02 500
this will give 500 gold to player 2 if i have it. it will then subtract the gold i give from my gold. It is protected from giving to much gold. lets say i have 200 gold and i try to give 500. It will only allow me to give 200 gold no matter what.

 

[Chaosy]

oh then I get it.

ok, so for suggestions:
1. make this 100% GUI to make it understandable for everyone
2. add a bonus option, like if I give 100 gold it takes 120 and gives 100 (20% extra) so you cant abuse trading
3. setup which event you want to use for giving gold

 

[deathismyfriend]

1) I don't think ill do that because the only part they need to understand is the config. Which is all in GUI
2)sounds good ill do that one
3) not sure what u mean ?

 

[Chaosy]

1. well it's better to make them understand it so they can modify it if needed. Also they can learn and improve ther triggering skills.

3. like atm as I get it you allways use the chat event for giving gold. What if I want to change that?

 

[deathismyfriend]

U mean the -giveGold ? That can easily be changed by changing it in the config trigger.

 

[Chaosy]

that changed he string used in the event. I mean like when I press "esc" (skips cinematic) I give 100 gold to player 2. Bad example I know, just trying to explain

 

[deathismyfriend]

I didn't make it with Esc because that would need a simple trigger to register player to player transfer. Where this allows player to player to player and so on transfer.

I'm not sure what u mean since u can change the giveGold command to anything u want simply by changing the string.

Also if I switch this to GUI I would just use all custom script anyways and looking at the white screen gives me migraines after a while

 

[Chaosy]

you still don't get it

If I change that variable it just changes the command. Like -givegoldforcharity 01
but if I want to change the event complete..

Like I dont want to use chat msg, I want to give lets say 10% of my current gold to the killer when I die

 

[deathismyfriend]

Ooo like that. I believe that would be just a simple trigger and I don't think it would sit right with this. Although I will look into it when I get home. Hopefully ill update this with the tax type like u said earlier then ill see about the other thing. I think it would just be a small trigger for that.

 

[Wrda]

2. add a bonus option, like if I give 100 gold it takes 120 and gives 100 (20% extra) so you cant abuse trading

I don't get this, why would someone abuse trading?

 

[deathismyfriend]

Well in case someone wants to enable the percentage it's a good idea.
Also remember wrda if anyone can find something to give them an advantage they will.

@ Chaosy
u think i should add a boolean array so they can turn of certain players when wanted ?
Like one that simply says true and it will let them trade gold. False for not able to trade gold. I can also add another so it will be true if they can receive gold ? this counts for the lumber system also.

 

[Chaosy]

player 1 could only collect gold while player collect lumber. Then spamm send between.

also if player 1 managed to survive with a peasant and basicly got 0 recources. Player 2 can carry that player to thetop in no time

 

[deathismyfriend]

updated this. for info read changelog.

Thanks for looking at this and giving feedback chaosy +rep

 

[Chaosy]

Now that is a awesome solution!

the disable/enable giving/reciveing boolean was just perfect.

more gui would still be good

 

[deathismyfriend]

Now that is a awesome solution!

the disable/enable giving/reciveing boolean was just perfect.

more gui would still be good

thanks lol. i try to keep all of the config in GUI. but the code is all in jass because i hate GUI lol but i prefer it that everyone is able to use my resource. Making the config in GUI is rather easy and it solves this problem a lot. They dont really need to know how the main code works anyways lol.

 

[Chaosy]

I know, they dont "need" to.

you could just include a disabled GUI version included. I admit that jass is better but people dont like it alot. I am somewhere between

 

[deathismyfriend]

i dont feel like writing it in GUI because 95% of it will be custom scripts lol.

 

[Chaosy]

meh! I will do it tomarrow then.

 

[deathismyfriend]

meh! I will do it tomarrow then.

huh ?

 

[Chaosy]

aka I will make a gui version and see if I can make it without jass

 

[deathismyfriend]

ooo u definitely can. nothing in there is jass only lol.

 

[Chaosy]

this is too much of a chat atm, I leave after this post.

well you said 95% jass, so I thought I would do insteaf. Afterall triggering is fun

 

[deathismyfriend]

triggering used to be fun then i found jass haha.
i would just code it in custom scripts. thats y i said 95 % jass lol

 

[Adiktuz]

ooh a give gold/lumber system... pretty neat...

 

[deathismyfriend]

ooh a give gold/lumber system... pretty neat...

lol thanks. glad u think its neat haha.

other than that how do u think it is for ease of use and functions ?

 

[Adiktuz]

well, it's pretty easy to use... it's just a simple command entry anyways... and it checks if the sender has enough gold/lumber...

 

[deathismyfriend]

well, it's pretty easy to use... it's just a simple command entry anyways... and it checks if the sender has enough gold/lumber...

lol thanks haha

 

[deathismyfriend]

fixed a bug were users without JNGP couldnt use.

This will now work for everyone

 

[deathismyfriend]

Fixed the bug purge pointed out.

Also the users can simply look in the config trigger to see the commands.

 

[-Kobas-]

local timer tmr = CreateTimer()
call TimerStart( tmr, 0.00, false, function GiveGoldSystemSetup)
set tmr = null

/* can be */
call TimerStart( CreateTimer(), 0.00, false, function GiveGoldSystemSetup)
/* same for */
call DestroyTimer( GetExpiredTimer() )

Both lumber and gold could be in same function
Also interface could look like this:
- G 01 500
or
- L 11 500

There is no need to write give because you always give, also gold, lumber can be just G or L.

 

[deathismyfriend]

local timer tmr = CreateTimer()
call TimerStart( tmr, 0.00, false, function GiveGoldSystemSetup)
set tmr = null

/* can be */
call TimerStart( CreateTimer(), 0.00, false, function GiveGoldSystemSetup)
/* same for */
call DestroyTimer( GetExpiredTimer() )

Both lumber and gold could be in same function
Also interface could look like this:
- G 01 500
or
- L 11 500

There is no need to write give because you always give, also gold, lumber can be just G or L.

I forgot about the first part.

The commands are completely configurable. They can easily be made like that by changing the command.

 

[deathismyfriend]

Updated to make improvements like Kobas pointed out.

@Kobas
I didn't combine these because i wanted two systems so people can decide if they want gold / lumber or both.

 

[deathismyfriend]

Thanks purge.

 

[RCS12]

Uhhh, hey death... I would like to add this system to my map and how can I make this system work or what should I write in the chatbox?

 

[deathismyfriend]

All instructions are above. You need to copy the triggers to your map and change the things you want to. Like the chat command which is preset to -giveGold01 1000
The above will give 1000 gold to player 1 red.

 

[RCS12]

All instructions are above. You need to copy the triggers to your map and change the things you want to. Like the chat command which is preset to -giveGold01 1000
The above will give 1000 gold to player 1 red.

Ok... it works now... i suggest that there should be a text appearing after the trade so that they know if the gold / lumber was given to the target player and the amount of it. And the text should only appear on the trading players (i.e. the one who is paying and recieving the gold) and it should look like this: "Player 1 has given Player 2 1000 Gold" Without the quotes. Ok, bye now and your system is nice it works well in my map.

 

[aple]

Why not just this?

• Give Gold
  • Events
    • Player - Player 1 (Red) types a chat message containing gold as An exact match
  • Conditions
  • Actions
    • Set Player = (Triggering player)
    • Player - Set Player Current gold to ((Player Current gold) + 500)

Then copy for each Player.

Much easier and I don't see why it wouldn't work.

EDIT: Oh I see, this is meant for like Trade Systems I guess. Probably still a less-complex way to go about things, but to each their own.

 

[deathismyfriend]

Why not just this?

• Give Gold
  • Events
    • Player - Player 1 (Red) types a chat message containing gold as An exact match
  • Conditions
  • Actions
    • Set Player = (Triggering player)
    • Player - Set Player Current gold to ((Player Current gold) + 500)

Then copy for each Player.

Much easier and I don't see why it wouldn't work.

EDIT: Oh I see, this is meant for like Trade Systems I guess. Probably still a less-complex way to go about things, but to each their own.

This system does much more than allow easier trading for gold. It allows whatever amount you want to exchange. So exchanging 500 and 1234 is as simple as typing in that amount.
It allows for much more also.

 

[Opex]

Hello. I have been trying to make a gold/ lumber pooling system for 6 months now without luck. I don't want you to feel bad for me I'm just extremely stupid. I've found over 10 gold pooling systems on this site as well as youtube/ google. For some reason I cannot get any of them to work and it drives me insane. -goldGive13 1000 (I have 4 player slots, pink 08, maroon 13, navy 14, emerald 23) and does nothing. I know I'm an idiot but I'm trying to just be able to pool resources. I can't pool resources by the allies tab either (which is all I need it to do). I've been studying this problem for way too long and still I barely even know what an integer or variable is, let alone how to make a simple pool a character resources. I'm at the point I'm ready to pay someone to make me this trigger(s). I've copy/ pasted/ edited way too many pooling resource systems which has never worked for me yet. I can't tell if I'm just really stupid or I'm really stupid and my map won't allow for resource pooling? Like a bug?

 

[Bribe]

That's because the JASS script is hardcoded for 12 players. Do this script instead:

    // Give Lumber System v 1.0.1.4
    // by deathismyfriend

    function GiveLumberSystemActions takes nothing returns boolean
        local string entered
        local string sub1
        local integer recp // recieving player
        local integer lumber
        local integer p = GetPlayerId( GetTriggerPlayer())
        local integer i
        local playerstate psrl
        if udg_giveLumberBoolGiverPlayer[ p+1] then
            set entered = GetEventPlayerChatString()
            set sub1 = SubString( entered, 0, udg_giveLumberLength1)
            set recp = S2I( SubString( entered, udg_giveLumberLength1, udg_giveLumberLength2))
            if recp != p + 1 then
                if sub1 == udg_giveLumberString and udg_giveGoldBoolReceivePlayer[ recp] then
                    set lumber = S2I( SubString( entered, udg_giveLumberLength2, StringLength( entered)))
                    set psrl = PLAYER_STATE_RESOURCE_LUMBER
                    set i = GetPlayerState( Player( p), psrl)
                  
                    if lumber < i then
                        call SetPlayerState( Player( recp), psrl, GetPlayerState( Player( recp), psrl) + R2I( I2R( lumber) * udg_giveLumberTax))
                    else
                        call SetPlayerState( Player(recp), psrl, GetPlayerState( Player( recp), psrl) + R2I( I2R( i) * udg_giveLumberTax))
                    endif
                    call SetPlayerState( Player( p), psrl, i - lumber)
                    set psrl = null
                endif
            endif
        endif
        return false
    endfunction

    function GiveLumberSystemSetup takes nothing returns nothing
        local trigger t = CreateTrigger()
        local integer L = 0
        local integer i = StringLength( udg_giveLumberString)
        loop
            exitwhen L > bj_MAX_PLAYER_SLOTS
            call TriggerRegisterPlayerChatEvent( t, Player( L), udg_giveLumberString, false)
            set L = L + 1
        endloop
        call TriggerAddCondition( t, Condition( function GiveLumberSystemActions))
        set udg_giveLumberLength1 = i
        set udg_giveLumberLength2 = i + 2
        call DestroyTimer( GetExpiredTimer())
        set t = null
    endfunction

    //===========================================================================
    function InitTrig_GiveLumberSystemCode takes nothing returns nothing
        call TimerStart( CreateTimer(), 0.00, false, function GiveLumberSystemSetup)
    endfunction

 

[Opex]

OK i switched this with the other one (i couldn't tell a difference in the scripts), should there be one for the gold pooling too?
So it looks to me like this is the same exact script or am i missing something?